Changesets: bareos

master ffbf368e

2020-02-07 11:05

franku

Ported: N/A

Details Diff
tests: evaluate REGRESS_DEBUG in messages test
mod - core/src/tests/messages.cc Diff File

bareos-19.2 82ea5b0b

2020-02-07 11:05

franku

Ported: N/A

Details Diff
tests: evaluate REGRESS_DEBUG in messages test
mod - core/src/tests/messages.cc Diff File

master 3800ebc0

2020-02-06 23:10

franku

Ported: N/A

Details Diff
systemtests: add stdout and stderr as destination to messages
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

bareos-19.2 795666ef

2020-02-06 23:10

franku

Ported: N/A

Details Diff
systemtests: add stdout and stderr as destination to messages
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

master 249ca157

2020-02-06 18:00

franku

Ported: N/A

Details Diff
systemtest: add more test pattern to message test
mod - core/src/tests/CMakeLists.txt Diff File
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

bareos-19.2 a7cc9e28

2020-02-06 18:00

franku

Ported: N/A

Details Diff
systemtest: add more test pattern to message test
mod - core/src/tests/CMakeLists.txt Diff File
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

master 93cef661

2020-02-06 17:59

franku

Ported: N/A

Details Diff
lib: prepare callbacks for mockup callbacks in unittests
mod - core/src/lib/message.cc Diff File
mod - core/src/lib/message.h Diff File

bareos-19.2 d56539bd

2020-02-06 17:59

franku

Ported: N/A

Details Diff
lib: prepare callbacks for mockup callbacks in unittests
mod - core/src/lib/message.cc Diff File
mod - core/src/lib/message.h Diff File

master 8af04707

2020-02-06 16:25

frank

Ported: N/A

Details Diff
webui: Fix sorting of job selection in restore module

A recent bconsole command change in the getClientBackups method
of the client model lead to a wrong population of the backup job
selection to choose from in the restore module.

To fix this issue the population of the backup job selection list is
still done by the getClientBackups method but with the proper bconsole
command as it has been before.

The client details action now calls the getClientJobs method of the
client model to get a job list with all status instead a list of
successful backup jobs only.

Fixes 0001174: reversed sort order on the restore client selection
Affected Issues
0001174
mod - webui/module/Client/src/Client/Controller/ClientController.php Diff File
mod - webui/module/Client/src/Client/Model/ClientModel.php Diff File
mod - webui/module/Client/view/client/client/details.phtml Diff File

bareos-19.2 6ec9b548

2020-02-06 16:25

frank

Ported: N/A

Details Diff
webui: Fix sorting of job selection in restore module

A recent bconsole command change in the getClientBackups method
of the client model lead to a wrong population of the backup job
selection to choose from in the restore module.

To fix this issue the population of the backup job selection list is
still done by the getClientBackups method but with the proper bconsole
command as it has been before.

The client details action now calls the getClientJobs method of the
client model to get a job list with all status instead a list of
successful backup jobs only.

Fixes 0001174: reversed sort order on the restore client selection
Affected Issues
0001174
mod - webui/module/Client/src/Client/Controller/ClientController.php Diff File
mod - webui/module/Client/src/Client/Model/ClientModel.php Diff File
mod - webui/module/Client/view/client/client/details.phtml Diff File

master d3983ba1

2020-02-06 16:03

arogge

Ported: N/A

Details Diff
lib: make IsAclEntryValid() more robust

Fixes 0001175: bareos crashes with invalid character in ACL

Previously IsAclEntryValid() took a char* as a parameter that was
expected to be a POOLMEM (and would have been resized when an error
occured).
This char* has been replaced by a std::vector<char>& and the new
overload for Mmsg() is now used to format a message.
Affected Issues
0001175
mod - core/src/dird/dird_conf.cc Diff File
mod - core/src/lib/edit.cc Diff File
mod - core/src/lib/edit.h Diff File
mod - core/src/tests/test_acl_entry_syntax.cc Diff File

bareos-19.2 208119f1

2020-02-06 16:03

arogge

Ported: N/A

Details Diff
lib: make IsAclEntryValid() more robust

Fixes 0001175: bareos crashes with invalid character in ACL

Previously IsAclEntryValid() took a char* as a parameter that was
expected to be a POOLMEM (and would have been resized when an error
occured).
This char* has been replaced by a std::vector<char>& and the new
overload for Mmsg() is now used to format a message.

(cherry picked from commit d3983ba1d08d9bda69ed58c36ec4253353106344)
Affected Issues
0001175
mod - core/src/dird/dird_conf.cc Diff File
mod - core/src/lib/edit.cc Diff File
mod - core/src/lib/edit.h Diff File
mod - core/src/tests/test_acl_entry_syntax.cc Diff File

master ffc074b0

2020-02-06 15:59

arogge

Ported: N/A

Details Diff
lib: add overload Mmsg() for std::vector<char>

Previously Mmsg() would only write into a POOLMEM or PoolMem. This patch
adds another overload that allows Mmsg() to write to a std::vector<char>
and to automatically resize that vector as needed.
mod - core/src/include/baconfig.h Diff File
mod - core/src/lib/message.cc Diff File
mod - core/src/lib/message.h Diff File

bareos-19.2 427000f5

2020-02-06 15:59

arogge

Ported: N/A

Details Diff
lib: add overload Mmsg() for std::vector<char>

Previously Mmsg() would only write into a POOLMEM or PoolMem. This patch
adds another overload that allows Mmsg() to write to a std::vector<char>
and to automatically resize that vector as needed.

(cherry picked from commit ffc074b00db41d50591eee9036407596617e3a69)
mod - core/src/include/baconfig.h Diff File
mod - core/src/lib/message.cc Diff File
mod - core/src/lib/message.h Diff File

master 8aaf7b2c

2020-02-06 15:50

franku

Ported: N/A

Details Diff
systemtests: write testrunner script for the messages test

- call the messages unittest to distribute a message
- check if the desired files exist and contain the expected message
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

bareos-19.2 c7f40644

2020-02-06 15:50

franku

Ported: N/A

Details Diff
systemtests: write testrunner script for the messages test

- call the messages unittest to distribute a message
- check if the desired files exist and contain the expected message
mod - core/src/tests/messages.cc Diff File
mod - systemtests/tests/messages-test/testrunner Diff File

master 69ade742

2020-02-06 15:02

frank

Ported: N/A

Details Diff
docs: Add 19.2.6 release notes
mod - docs/manuals/source/Appendix/ReleaseNotes.rst Diff File

bareos-19.2 253c4a73

2020-02-06 15:02

frank

Ported: N/A

Details Diff
docs: Add 19.2.6 release notes
mod - docs/manuals/source/Appendix/ReleaseNotes.rst Diff File

master 8d92e8f7

2020-02-06 13:36

arogge

Ported: N/A

Details Diff
systemtests: check crash on invalid ACL

Bug 0001175 - bareos crashes with invalid character in ACL

When a profile configuration contains an entry that is detected as
invalid, the director crashes. This test reproduces this problem.
Affected Issues
0001175
mod - systemtests/CMakeLists.txt Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/catalog/MyCatalog.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/client/bareos-fd.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/console/bareos-mon.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/director/bareos-dir.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/fileset/Catalog.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/fileset/SelfTest.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/job/BackupCatalog.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/job/RestoreFiles.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/job/backup-bareos-fd.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/jobdefs/DefaultJob.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/messages/Daemon.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/pool/Differential.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/pool/Full.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/pool/Incremental.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/pool/Scratch.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/profile/operator.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-dir.d/storage/File.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-fd.d/client/myself.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-fd.d/director/bareos-dir.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-fd.d/director/bareos-mon.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-fd.d/messages/Standard.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-sd.d/device/FileStorage.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-sd.d/director/bareos-dir.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-sd.d/director/bareos-mon.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-sd.d/messages/Standard.conf Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bareos-sd.d/storage/bareos-sd.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/bconsole.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/tray-monitor.d/client/FileDaemon-local.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/tray-monitor.d/director/Director-local.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/tray-monitor.d/monitor/bareos-mon.conf.in Diff File
add - systemtests/tests/config-syntax-crash/etc/bareos/tray-monitor.d/storage/StorageDaemon-local.conf.in Diff File
add - systemtests/tests/config-syntax-crash/testrunner Diff File

master 6328afd2

2020-02-06 13:32

franku

Ported: N/A

Details Diff
systemtests: add messages-test
rm - core/src/tests/configs/messages/bareos-dir.d/catalog/MyCatalog.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/client/bareos-fd.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/Catalog.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/LinuxAll.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/Windows All Drives.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/messages/Standard.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/schedule/WeeklyCycle.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/schedule/WeeklyCycleAfterBackup.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/storage/File.conf Diff File
mod - systemtests/CMakeLists.txt Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/catalog/MyCatalog.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/client/bareos-fd.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/fileset/Catalog.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Daemon.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/storage/File.conf.in Diff File
add - systemtests/tests/messages-test/testrunner Diff File

bareos-19.2 a81b4be6

2020-02-06 13:32

franku

Ported: N/A

Details Diff
systemtests: add messages-test
rm - core/src/tests/configs/messages/bareos-dir.d/catalog/MyCatalog.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/client/bareos-fd.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/Catalog.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/LinuxAll.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/fileset/Windows All Drives.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/messages/Standard.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/schedule/WeeklyCycle.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/schedule/WeeklyCycleAfterBackup.conf Diff File
rm - core/src/tests/configs/messages/bareos-dir.d/storage/File.conf Diff File
mod - systemtests/CMakeLists.txt Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/catalog/MyCatalog.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/client/bareos-fd.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/fileset/Catalog.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Daemon.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/messages/Standard.conf.in Diff File
add - systemtests/tests/messages-test/etc/bareos/bareos-dir.d/storage/File.conf.in Diff File
add - systemtests/tests/messages-test/testrunner Diff File

master fcf73700

2020-02-06 13:29

frank

Ported: N/A

Details Diff
cats: Fix upgrading MySQL database from version 2171 to 2192

"CREATE INDEX IF NOT EXISTS ..." does not work on MySQL.

Instead "ALTER TABLE Job ADD INDEX (JobTDate);" is compatible to
MariaDB and MySQL. This also works if an index is already in place.

Unfortunately we could end up having multiple indexes on
JobTDate this way, so manually cleaning up could be required.

Perform also a key distribution analysis on the PathVisibility
table after index drop.

Fixes 0001176: Upgrade 18.2.5 to 19.2.5 failed ...
Affected Issues
0001176
mod - core/src/cats/ddl/updates/mysql.2171_2192.sql Diff File

bareos-19.2 79efe166

2020-02-06 13:29

frank

Ported: N/A

Details Diff
cats: Fix upgrading MySQL database from version 2171 to 2192

"CREATE INDEX IF NOT EXISTS ..." does not work on MySQL.

Instead "ALTER TABLE Job ADD INDEX (JobTDate);" is compatible to
MariaDB and MySQL. This also works if an index is already in place.

Unfortunately we could end up having multiple indexes on
JobTDate this way, so manually cleaning up could be required.

Perform also a key distribution analysis on the PathVisibility
table after index drop.

Fixes 0001176: Upgrade 18.2.5 to 19.2.5 failed ...
Affected Issues
0001176
mod - core/src/cats/ddl/updates/mysql.2171_2192.sql Diff File

master a9a9f63c

2020-02-06 13:13

franku

Ported: N/A

Details Diff
lib: move getenv_std_string function from tests to lib/util
mod - core/src/lib/util.cc Diff File
mod - core/src/lib/util.h Diff File
mod - core/src/tests/catalog.cc Diff File
mod - core/src/tests/messages.cc Diff File

bareos-19.2 47b6244f

2020-02-06 13:13

franku

Ported: N/A

Details Diff
lib: move getenv_std_string function from tests to lib/util
mod - core/src/lib/util.cc Diff File
mod - core/src/lib/util.h Diff File
mod - core/src/tests/catalog.cc Diff File
mod - core/src/tests/messages.cc Diff File
 First  Prev  1 2 3 ... 60 ... 120 ... 180 ... 238 239 240 241 242 243 244 ... 300 ... 360 ... 420 ... 480 ... 540 ... 600 ... 607 608 609  Next  Last