Changesets: bareos

master 689cc224

2024-03-07 10:00

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dird-jcr: fix bad use of condition variable
mod - core/src/dird/director_jcr_impl.h Diff File
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/jobq.cc Diff File
mod - core/src/dird/msgchan.cc Diff File

master 385bc7ad

2024-03-07 09:45

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
jcr: switch to std::mutex/std::unique_lock
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/msgchan.cc Diff File
mod - core/src/dird/ndmp_fhdb_common.cc Diff File
mod - core/src/dird/ndmp_fhdb_lmdb.cc Diff File
mod - core/src/dird/ndmp_fhdb_mem.cc Diff File
mod - core/src/filed/backup.cc Diff File
mod - core/src/filed/restore.cc Diff File
mod - core/src/filed/status.cc Diff File
mod - core/src/filed/verify.cc Diff File
mod - core/src/filed/verify_vol.cc Diff File
mod - core/src/include/jcr.h Diff File
mod - core/src/lib/jcr.cc Diff File
mod - core/src/stored/reserve.cc Diff File
mod - core/src/stored/status.cc Diff File

master 4ad05901

2024-03-07 09:44

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
thread-util: introduce locked::wait_until()
mod - core/src/lib/thread_util.h Diff File

master 20682c92

2024-03-07 09:35

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
stored: fix jcr->authenticate data race

The condition variable is not used correctly:

// reader
1| while (!unprotected) {
2| wait(cond_var)
}
// writer

3| unprotected = true;
4| signal(cond_var)

The execution order 1->3->4->2 will cause a deadlock. This is why the
wait command takes a mutex: Everything that might change the
condition to be true needs to lock the mutex, this way we can ensure
that we either see the updated value or the wait sees the signal.

Since jcr->authenticate is used all over the place in a lot of
different situations, this problem could not be easily fixed by just
protecting that variable (we do not want weird deadlocks to happen
after all).

We just do not rely on jcr->authenticate anymore when it comes to
waiting on job start. Instead we have a single, properly protected
bool `client_available` that we can wait on.
This bool obviously needs to be set by whoever authenticates the FD/SD
connection, otherwise the job will deadlock. But at least that is
easily fixable.
mod - core/src/stored/dir_cmd.cc Diff File
mod - core/src/stored/fd_cmds.cc Diff File
mod - core/src/stored/job.cc Diff File
mod - core/src/stored/ndmp_tape.cc Diff File
mod - core/src/stored/sd_cmds.cc Diff File
mod - core/src/stored/stored.cc Diff File
mod - core/src/stored/stored_jcr_impl.h Diff File

master 8a72eef9

2024-03-06 21:18

slederer


Committer: Bareos Bot

Ported: N/A

Details Diff
docs: fix Pool explanation for migration jobs

- describe the effect of the Pool statement for Copy and Migration jobs
correctly in case of "SQL Query" selection type
- fix example configuration
mod - docs/manuals/source/TasksAndConcepts/MigrationAndCopy.rst Diff File
mod - docs/manuals/source/include/config/DirSelectionPatterns-sql1.conf Diff File
mod - docs/manuals/source/manually_added_config_directive_descriptions/dir-job-Pool.rst.inc Diff File
mod - docs/manuals/source/manually_added_config_directive_descriptions/dir-job-SelectionPattern.rst.inc Diff File

master 48271b59

2024-03-06 14:00

arogge


Committer: GitHub

Ported: N/A

Details Diff
Merge pull request #1639

Add backport tool
mod - CHANGELOG.md Diff File
add - devtools/pip-tools/.gitignore Diff File
mod - devtools/pip-tools/Pipfile Diff File
mod - devtools/pip-tools/Pipfile.lock Diff File
rm - devtools/pip-tools/check_sources.egg-info/PKG-INFO Diff File
rm - devtools/pip-tools/check_sources.egg-info/SOURCES.txt Diff File
rm - devtools/pip-tools/check_sources.egg-info/dependency_links.txt Diff File
rm - devtools/pip-tools/check_sources.egg-info/entry_points.txt Diff File
rm - devtools/pip-tools/check_sources.egg-info/top_level.txt Diff File
add - devtools/pip-tools/pr_tool/backport.py Diff File
add - devtools/pip-tools/pr_tool/backport_pr_template.md Diff File
add - devtools/pip-tools/pr_tool/github.py Diff File
mod - devtools/pip-tools/pr_tool/main.py Diff File

master b1de0ac9

2024-03-06 13:59

arogge

Ported: N/A

Details Diff
Update CHANGELOG.md
mod - CHANGELOG.md Diff File

master efed11bd

2024-03-05 08:14

Sebastian Sura

Ported: N/A

Details Diff
wrap: add official test data

See: https://datatracker.ietf.org/doc/html/rfc3394.html#section-4.1
mod - core/src/tests/wrap.cc Diff File

master 16731f3d

2024-03-05 00:04

stephand


Committer: Bareos Bot

Ported: N/A

Details Diff
VMware Plugin: Backup and Restore NVRAM

The NVRAM of VMs is now backed up and restored when a VM is recreated.
This ensures that EFI enabled VMs will boot successfully.

Additionally, the exception handling and error messages in the functions
connect_vmware() and retrieve_vcthumbprint() were enhanced.

The plugin now makes sure to store all files belonging to a recreated VM
in the same directory in VMFS.

This commit also contains some changes to improve the pylint score.
mod - core/src/plugins/filed/python/vmware/bareos-fd-vmware.py Diff File
mod - docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc Diff File

master e075c867

2024-03-04 12:49

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dird-cmd: fix using unchanging bool inside loop
mod - core/src/filed/dir_cmd.cc Diff File

master 0ac6b2cd

2024-02-28 18:45

smarsching


Committer: Bareos Bot

Ported: N/A

Details Diff
Fix warning about missing delcandidates table in director.

Pruning jobs would cause the following warning in the output of the
director (e.g. visible through
“systemctl status bareos-director.service”):

table "delcandidates" does not exist, skipping

This warning is harmless but clutters the output. With this commit, this
problem is fixed by disabling warnings for the PostgreSQL connection
that is established by the director.

See https://bugs.bareos.org/view.php?id=1561 and
https://bugs.bareos.org/view.php?id=1606.
mod - AUTHORS Diff File
mod - core/src/cats/postgresql.cc Diff File

master a688c4d0

2024-02-28 14:39

tuxmaster5000


Committer: Bareos Bot

Ported: N/A

Details Diff
Require python3 explicit
mod - contrib/misc/bsmc/bin/bsmc Diff File
mod - contrib/misc/triggerjob/bareos-triggerjob.py Diff File

master fe612821

2024-02-27 17:59

slederer

Ported: N/A

Details Diff
expand documentation for the LDAP plugin
mod - docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/LDAPPlugin.rst.inc Diff File

master a4fb7800

2024-02-27 17:53

joergs


Committer: slederer

Ported: N/A

Details Diff
systemtests py3plug-fd-ldap: add another test case

Also test how the plugin behaves with wrong credentials.
add - systemtests/tests/py3plug-fd-ldap/etc/bareos/bareos-dir.d/fileset/PluginFailingTest.conf.in Diff File
add - systemtests/tests/py3plug-fd-ldap/testrunner-wrong_credentials Diff File

master cbf53c44

2024-02-27 16:57

joergs


Committer: slederer

Ported: N/A

Details Diff
systemtests py3plug-fd-ldap: accept port number

Accept SYSTEMTEST_LDAP_ADDRESS with port number, like
SYSTEMTEST_LDAP_ADDRESS=127.0.0.1:389
mod - systemtests/tests/py3plug-fd-ldap/CMakeLists.txt Diff File
mod - systemtests/tests/py3plug-fd-ldap/etc/bareos/bareos-dir.d/fileset/PluginTest.conf.in Diff File

master fb003630

2024-02-27 15:18

Sebastian Sura

Ported: N/A

Details Diff
wrap-test: add additional assertions
mod - core/src/tests/wrap.cc Diff File

master 7c303ebb

2024-02-23 13:26

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
weird-files: add additional files with weird names

I added some files that specifically have names containing

< (less than)
> (greater than)
: (colon)
" (double quote)
/ (forward slash)
\ (backslash)
| (vertical bar or pipe)
? (question mark)
* (asterisk)

as there are illegal in normal windows paths.
mod - systemtests/data/weird-files.tar.gz Diff File
mod - systemtests/tests/py3plug-fd-libcloud/test-setup Diff File
mod - systemtests/tests/testfind/testrunner Diff File
mod - systemtests/tests/virtualfull-basic/testrunner Diff File

master 214702f1

2024-02-23 09:22

Sebastian Sura

Ported: N/A

Details Diff
crypto_wrap: switch to opessl wrap

The test now has the old implementation instead.
mod - core/src/dird/ua_label.cc Diff File
mod - core/src/lib/crypto_wrap.cc Diff File
mod - core/src/lib/crypto_wrap.h Diff File
mod - core/src/plugins/stored/scsicrypto/scsicrypto-sd.cc Diff File
mod - core/src/tests/wrap.cc Diff File
mod - core/src/tools/bscrypto.cc Diff File

master 619c1736

2024-02-22 09:30

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
systemtests: print tracebacks on cleanup
mod - systemtests/scripts/cleanup Diff File
mod - systemtests/scripts/functions Diff File

master bec287fb

2024-02-22 07:34

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
functions: add timeout to run_bareos

once that timeout is reached, we kill the daemons and create a trace.
mod - core/scripts/bareos-ctl-dir.in Diff File
mod - core/scripts/bareos-ctl-fd.in Diff File
mod - core/scripts/bareos-ctl-sd.in Diff File
mod - systemtests/scripts/functions Diff File

master d2a8706c

2024-02-21 13:39

Bareos Bot


Committer: GitHub

Ported: N/A

Details Diff
Merge pull request #1648

jcr: fix some compiler warnings
mod - CHANGELOG.md Diff File
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/reload.cc Diff File
mod - core/src/dird/socket_server.cc Diff File
mod - core/src/filed/backup.cc Diff File
mod - core/src/filed/dir_cmd.cc Diff File
mod - core/src/filed/filed_jcr_impl.h Diff File
mod - core/src/filed/heartbeat.cc Diff File
mod - core/src/filed/heartbeat.h Diff File
mod - core/src/filed/restore.cc Diff File
mod - core/src/lib/bsock_tcp.cc Diff File
mod - core/src/lib/bsys.cc Diff File
mod - core/src/plugins/filed/bpipe/bpipe-fd.cc Diff File
mod - core/src/stored/backends/droplet_device.cc Diff File
mod - core/src/stored/fd_cmds.cc Diff File
mod - core/src/tests/ktls.cc Diff File
mod - systemtests/CMakeLists.txt Diff File
mod - systemtests/cmake/BareosSystemtestFunctions.cmake Diff File
mod - systemtests/scripts/functions Diff File
mod - systemtests/tests/checkpoints/testrunner-checkpoints-on-cancel Diff File

master 6ad76445

2024-02-21 13:39

Bareos Bot

Ported: N/A

Details Diff
Update CHANGELOG.md
mod - CHANGELOG.md Diff File

master 4c07e921

2024-02-21 11:26

Sebastian Sura

Ported: N/A

Details Diff
askdir: fix leaking poll mode to caller

dev->poll disables AutoLabeling, as such we should not leak it into
the caller context.
mod - core/src/stored/askdir.cc Diff File

master f9d2f926

2024-02-21 08:58

Sebastian Sura

Ported: N/A

Details Diff
wrap-test: add randomization

Now the plaintext that is getting wrapped/unwrapped is not static but
instead is randomised.
mod - core/src/tests/wrap.cc Diff File

master 0260a1cb

2024-02-21 08:26

Sebastian Sura

Ported: N/A

Details Diff
unit-tests: add test comparing openssl wrap with ours
mod - core/src/tests/CMakeLists.txt Diff File
add - core/src/tests/wrap.cc Diff File
 First  Prev  1 2 3 4 5 6 ... 60 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 600 ... 604 605 606  Next  Last