View Issue Details

IDProjectCategoryView StatusLast Update
0001118bareos-core[All Projects] installer / packagespublic2019-10-16 11:22
ReporterwolfabaAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformLinuxOSanyOS Version3
Product Version18.2.5 
Target VersionFixed in Version 
Summary0001118: Incorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake
DescriptionIncorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake



Dear Bareos developers,
we have found some ugly values in BareosSetVariableDefaults.cmake.
IF(NOT DEFINED job_email)
   SET(job_email "root@localhost")
ENDIF()
IF(NOT DEFINED dump_email)
   SET(dump_email "root@localhost")
ENDIF()
IF(NOT DEFINED smtp_host)
   SET(smtp_host "root@localhost")
ENDIF()

If the bareos process crash it uses btraceback script to generate backtrace and sends the email using bsmtp.
In btraceback.in is the last line
@sbindir@/bsmtp -h @smtp_host@ -f @dump_email@ -s "Bareos ${DEBUGGER} traceback of ${PNAME}" @dump_email@
bsmtp man page says that option -h should take mailhost:port (not email address), so the "root@localhost" for smtp_host is really incorrect. Could you replace this value with simple localhost?

Than if the email is generated with sender root@localhost, it will not be accepted on those mail servers, which check the sender address. Could you replace the sender address with simple "root" and let the localhost MTA generate correct domain?

The same thing for recipient. If you use root@localhost and the email will be passed to some mail server, it can land anywhere. Please, use simple "root", which delivers email either to local root or (if there is some alias defined) devliers email to destination address for local alias "root".

I have created pull request 0000297 "use simple default email values".

Thank you.

Regards,

Robert Wolf.
TagsNo tags attached.
bareos-master: impact
bareos-master: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Activities

wolfaba

wolfaba

2019-10-16 11:22

reporter   ~0003604

Fix committed to bareos master branch with changesetid 11941.

Related Changesets

bareos: master 8050764f

2019-10-08 15:30:56

wolfaba

Ported: N/A

Details Diff
Fixes 0001118: Incorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake

This patch fixes default mail values for smtp_host, job_email and dump_email.
Affected Issues
0001118
mod - core/cmake/BareosSetVariableDefaults.cmake Diff File

bareos: master 4a56d556

2019-10-16 10:27:42

arogge


Committer: GitHub

Ported: N/A

Details Diff
Merge pull request 0000301 from wolfaba/master

Fixes 0001118: Incorrect and ugly default mail values
Affected Issues
0001118
mod - core/cmake/BareosSetVariableDefaults.cmake Diff File

Issue History

Date Modified Username Field Change
2019-10-07 10:54 wolfaba New Issue
2019-10-16 11:22 arogge Changeset attached => bareos master 4a56d556
2019-10-16 11:22 wolfaba Changeset attached => bareos master 8050764f
2019-10-16 11:22 wolfaba Note Added: 0003604