View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0001118 | bareos-core | installer / packages | public | 2019-10-07 10:54 | 2023-07-05 16:13 |
| Reporter | wolfaba | Assigned To | bruno-at-bareos | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Linux | OS | any | OS Version | 3 |
| Product Version | 18.2.5 | ||||
| Summary | 0001118: Incorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake | ||||
| Description | Incorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake Dear Bareos developers, we have found some ugly values in BareosSetVariableDefaults.cmake. IF(NOT DEFINED job_email) SET(job_email "root@localhost") ENDIF() IF(NOT DEFINED dump_email) SET(dump_email "root@localhost") ENDIF() IF(NOT DEFINED smtp_host) SET(smtp_host "root@localhost") ENDIF() If the bareos process crash it uses btraceback script to generate backtrace and sends the email using bsmtp. In btraceback.in is the last line @sbindir@/bsmtp -h @smtp_host@ -f @dump_email@ -s "Bareos ${DEBUGGER} traceback of ${PNAME}" @dump_email@ bsmtp man page says that option -h should take mailhost:port (not email address), so the "root@localhost" for smtp_host is really incorrect. Could you replace this value with simple localhost? Than if the email is generated with sender root@localhost, it will not be accepted on those mail servers, which check the sender address. Could you replace the sender address with simple "root" and let the localhost MTA generate correct domain? The same thing for recipient. If you use root@localhost and the email will be passed to some mail server, it can land anywhere. Please, use simple "root", which delivers email either to local root or (if there is some alias defined) devliers email to destination address for local alias "root". I have created pull request 0000297 "use simple default email values". Thank you. Regards, Robert Wolf. | ||||
| Tags | No tags attached. | ||||
|
bareos: master 8050764f 2019-10-08 17:30 Ported: N/A Details Diff |
Fixes 0001118: Incorrect default value for smtp_host and ugly default values for job_email and dump_email in BareosSetVariableDefaults.cmake This patch fixes default mail values for smtp_host, job_email and dump_email. |
Affected Issues 0001118 |
|
| mod - core/cmake/BareosSetVariableDefaults.cmake | Diff File | ||
|
bareos: master 4a56d556 2019-10-16 12:27 Committer: GitHub Ported: N/A Details Diff |
Merge pull request 0000301 from wolfaba/master Fixes 0001118: Incorrect and ugly default mail values |
Affected Issues 0001118 |
|
| mod - core/cmake/BareosSetVariableDefaults.cmake | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2019-10-07 10:54 | wolfaba | New Issue | |
| 2019-10-16 11:22 | arogge | Changeset attached | => bareos master 4a56d556 |
| 2019-10-16 11:22 | wolfaba | Changeset attached | => bareos master 8050764f |
| 2019-10-16 11:22 | wolfaba | Note Added: 0003604 | |
| 2023-07-05 16:13 | bruno-at-bareos | Assigned To | => bruno-at-bareos |
| 2023-07-05 16:13 | bruno-at-bareos | Status | new => closed |
| 2023-07-05 16:13 | bruno-at-bareos | Resolution | open => fixed |
| 2023-07-05 16:13 | bruno-at-bareos | Note Added: 0005147 |
