Changesets: bareos

Search Browse Back to Index

bareos-15.2 0b6435d7

2015-11-12 18:39

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fix random crashes on sd

The block variable was set to the dcr->block, but that can be altered in
the call to dev->set_label_blocksize(dcr).

When that happens, the code goes on with the wrong block.
We removed the whole local variable as it makes no sense and is only
referenced 3 times when calling empty_block()

Fixes 0000414: Bareos storage daemon crashes during backups
Fixse 0000483: bareos-sd crash during backup
Fixes 0000522: storage daemon crashes ocassionally when starting a new job
Fixes 0000552: SD crashes in -current

Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>		 Affected Issues
0000414, 0000483, 0000522, 0000552, 0000564
mod - src/stored/label.c Diff File

bareos-14.2 3a09212c

2015-11-12 18:39

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fix random crashes on sd

The block variable was set to the dcr->block, but that can be altered in
the call to dev->set_label_blocksize(dcr).

When that happens, the code goes on with the wrong block.
We removed the whole local variable as it makes no sense and is only
referenced 3 times when calling empty_block()

Fixes 0000414: Bareos storage daemon crashes during backups
Fixse 0000483: bareos-sd crash during backup
Fixes 0000522: storage daemon crashes ocassionally when starting a new job
Fixes 0000552: SD crashes in -current

Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>		 Affected Issues
0000414, 0000522, 0000552
mod - src/stored/label.c Diff File

master cf0f92fe

2015-11-11 16:45

Frank Bergkemper

Ported: N/A

Details Diff		 Use API 2 with compact mode enabled

Signed-off-by: Frank Bergkemper <frank.bergkemper@dass-it.de>
mod - vendor/Bareos/library/Bareos/BSock/BareosBSock.php Diff File

master f77ef94e

2015-11-11 16:31

Frank Bergkemper

Ported: N/A

Details Diff		 Restore improvements

Signed-off-by: Frank Bergkemper <frank.bergkemper@dass-it.de>
mod - module/Job/src/Job/Controller/JobController.php Diff File
mod - module/Job/src/Job/Form/JobForm.php Diff File
mod - module/Job/view/job/job/index.phtml Diff File
mod - module/Restore/src/Restore/Controller/RestoreController.php Diff File
mod - module/Restore/src/Restore/Form/RestoreForm.php Diff File
mod - module/Restore/src/Restore/Model/RestoreModel.php Diff File
mod - module/Restore/view/restore/restore/index.phtml Diff File

master ca0784d7

2015-11-10 18:03

Tad Hunt


Committer: mvwieringen

Ported: N/A

Details Diff		 SD: Refactor record write code path.

This commit centralizes the record write state management into the record
write state machine, such that the functions called to convert records
to blocks only mutates the block, and the record write state machine
manages mutation of the record state. One benefit to this approach
is the ability to pass the record to more places as const. This makes
reasoning about record modification straightforward. A second benefit is
a net code reduction due to collapsing the write block header and write
block continuation header functions into a single and simpler function

Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>
mod - src/stored/block.h Diff File
mod - src/stored/device.c Diff File
mod - src/stored/label.c Diff File
mod - src/stored/protos.h Diff File
mod - src/stored/read.c Diff File
mod - src/stored/record.c Diff File
mod - src/stored/record.h Diff File

master f43c5ffd

2015-11-10 18:03

Dirk Wilske


Committer: mvwieringen

Ported: N/A

Details Diff		 DIR: Report the secure erase settings in the jobreport

We now transfer the setting of the secure erase command to the
director in order to show what the settings were during backup

Fixes 0000520: Show "secure erase" settings in job report		 Affected Issues
0000520
mod - src/dird/backup.c Diff File
mod - src/dird/dird.h Diff File
mod - src/dird/dird_conf.c Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/job.c Diff File
mod - src/dird/msgchan.c Diff File
mod - src/dird/protos.h Diff File
mod - src/dird/restore.c Diff File
mod - src/dird/sd_cmds.c Diff File
mod - src/filed/authenticate.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/filed_conf.c Diff File
mod - src/include/jcr.h Diff File
mod - src/stored/dir_cmd.c Diff File
mod - src/stored/stored_conf.c Diff File

bareos-15.2 9848e50f

2015-11-10 11:57

mvwieringen

Ported: N/A

Details Diff		 Coverity: Fix 3 resource leaks
mod - src/win32/compat/compat.c Diff File
mod - src/win32/generic/service.c Diff File

bareos-14.2 b4e23b4b

2015-11-10 11:57

mvwieringen

Ported: N/A

Details Diff		 Coverity: Fix 3 resource leaks
mod - src/win32/compat/compat.c Diff File
mod - src/win32/generic/service.c Diff File

master c94bc27b

2015-11-09 16:34

Philipp Storz


Committer: Joerg Steffens

Ported: N/A

Details Diff		 docs for %B format string
mod - manuals/en/main/configure.tex Diff File
mod - manuals/en/main/director-resource-job-definitions.tex Diff File

bareos-15.2 d511f6e8

2015-11-09 14:34

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed double declaration of variable i

This makes the loop variable shadow the variable with a wider scope and
as such it doesn't have a defined value after the loops exits.

Fixes 0000556: File Relocation does not work		 Affected Issues
0000556
mod - src/lib/bregex.c Diff File

bareos-14.2 f941aa3e

2015-11-09 14:34

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed double declaration of variable i

This makes the loop variable shadow the variable with a wider scope and
as such it doesn't have a defined value after the loops exits.

Fixes 0000556: File Relocation does not work		 Affected Issues
0000556
mod - src/lib/bregex.c Diff File

bareos-13.2 86cc27e6

2015-11-09 14:34

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed double declaration of variable i

This makes the loop variable shadow the variable with a wider scope and
as such it doesn't have a defined value after the loops exits.

Fixes 0000556: File Relocation does not work		 Affected Issues
0000556
mod - src/lib/bregex.c Diff File

bareos-12.4 e678dfa3

2015-11-09 14:34

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed double declaration of variable i

This makes the loop variable shadow the variable with a wider scope and
as such it doesn't have a defined value after the loops exits.

Fixes 0000556: File Relocation does not work		 Affected Issues
0000556
mod - src/lib/bregex.c Diff File

master 41f82634

2015-11-09 13:54

joergs


Committer: pstorz

Ported: N/A

Details Diff		 SLES12: add support for CEPH

build the packages
- bareos-filedaemon-ceph-plugin
- bareos-storage-ceph
mod - platforms/packaging/bareos.spec Diff File

master cfdd0f3f

2015-11-09 13:54

joergs

Ported: N/A

Details Diff		 SLES12: add support for CEPH

build the packages
- bareos-filedaemon-ceph-plugin
- bareos-storage-ceph
mod - platforms/packaging/bareos.spec Diff File

master 8ca039b8

2015-11-08 19:35

Joerg Steffens

Ported: N/A

Details Diff		 added directory each_jobname_last_run
mod - bareos/fuse/node/jobs.py Diff File

bareos-15.2 a416895d

2015-11-08 15:06

mvwieringen

Ported: N/A

Details Diff		 dird: Add expansion for bytes in human readable format.

Next to %b also allow %B for Job Bytes in human readable format.
mod - src/lib/util.c Diff File

bareos-14.2 412eea58

2015-11-08 15:06

mvwieringen

Ported: N/A

Details Diff		 dird: Add expansion for bytes in human readable format.

Next to %b also allow %B for Job Bytes in human readable format.
mod - src/lib/util.c Diff File

bareos-15.2 f9fc2a52

2015-11-06 16:58

Adam Thompson


Committer: joergs

Ported: N/A

Details Diff		 Describe Linux-specific error

Add a sentence that's greppable so this documentation can be found.
mod - README.scsicrypto Diff File

master fc0af3af

2015-11-05 20:40

mvwieringen

Ported: N/A

Details Diff		 Merge branch 'bareos-15.2'
mod - platforms/packaging/bareos.spec Diff File
mod - src/dird/ndmp_fhdb_mem.c Diff File
mod - src/dird/protos.h Diff File
mod - src/dird/ua_cmds.c Diff File
mod - src/dird/ua_dotcmds.c Diff File
mod - src/dird/ua_output.c Diff File
mod - src/lib/output_formatter.c Diff File
mod - src/lib/output_formatter.h Diff File
mod - src/ndmp/ndma_comm_dispatch.c Diff File
mod - src/ndmp/ndma_cops_backreco.c Diff File
mod - src/ndmp/ndma_cops_query.c Diff File
mod - src/ndmp/ndma_ctrl_calls.c Diff File
mod - src/ndmp/ndma_ctrl_media.c Diff File
mod - src/ndmp/ndma_ctst_mover.c Diff File
mod - src/ndmp/ndma_ctst_subr.c Diff File
mod - src/ndmp/ndma_ctst_tape.c Diff File
mod - src/ndmp/ndma_data.c Diff File
mod - src/ndmp/ndma_data_fh.c Diff File
mod - src/ndmp/ndma_listmgmt.c Diff File
mod - src/ndmp/ndma_noti_calls.c Diff File
mod - src/ndmp/ndma_tape.c Diff File
mod - src/ndmp/ndma_tape_simulator.c Diff File
mod - src/ndmp/ndmagents.h Diff File
mod - src/ndmp/ndmjob_simulator.c Diff File
mod - src/ndmp/ndml_chan.c Diff File
mod - src/ndmp/ndml_fhdb.c Diff File
mod - src/ndmp/ndml_log.c Diff File
mod - src/ndmp/ndml_media.c Diff File
mod - src/ndmp/ndmlib.h Diff File
mod - src/ndmp/ndmos.h Diff File
mod - src/ndmp/ndmos_common.c Diff File
mod - src/ndmp/ndmp0.x Diff File
mod - src/ndmp/ndmp2.x Diff File
mod - src/ndmp/ndmp2_translate.c Diff File
mod - src/ndmp/ndmp2_xmt.c Diff File
mod - src/ndmp/ndmp3.x Diff File
mod - src/ndmp/ndmp3_translate.c Diff File
mod - src/ndmp/ndmp3_xmt.c Diff File
mod - src/ndmp/ndmp4.x Diff File
mod - src/ndmp/ndmp4_translate.c Diff File
mod - src/ndmp/ndmp4_xmt.c Diff File
mod - src/ndmp/ndmp9.x Diff File
mod - src/ndmp/ndmp9_xmt.c Diff File
mod - src/ndmp/ndmp_msg_buf.h Diff File
mod - src/ndmp/ndmp_translate.c Diff File
mod - src/ndmp/ndmp_translate.h Diff File
mod - src/ndmp/smc.h Diff File
mod - src/ndmp/smc_raw.h Diff File
mod - src/ndmp/wraplib.c Diff File
mod - src/ndmp/wraplib.h Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-15.2 e073a9de

2015-11-05 16:21

joergs

Ported: N/A

Details Diff		 Fix broken package dependency

The RPM package bareos-filedaemon-ldap-python-plugin had a wrong dependency
to filedaemon-python-plugin instead of bareos-filedaemon-ldap-python-plugin.

Fixes 0000551: Unable to install bareos-filedaemon-ldap-python-plugin		 Affected Issues
0000551
mod - platforms/packaging/bareos.spec Diff File

master 638de766

2015-11-04 15:23

joergs

Ported: N/A

Details Diff		 bcommand: add .jobstatus command
mod - src/cats/sql_cmds.c Diff File
mod - src/cats/sql_cmds.h Diff File
mod - src/dird/ua_cmds.c Diff File
mod - src/dird/ua_dotcmds.c Diff File

bareos-15.2 f15adf67

2015-11-03 00:12

mvwieringen

Ported: N/A

Details Diff		 NDMP: Switch ndmplib to 2015 data types.

- u_short ==> uint16_t
- u_long ==> uint32_t
- int ==> int32_t
- unsigned long long ==> uint64_t
- long long ==> int64_t
- unsigned long ==> uint32_t
- unsigned short ==> uint16_t

For GCC we now disable the following warning:

-Wunused-variable
-Wunused-but-set-variable
-Wformat
-Wenum-compare

For the Solaris Studio compiler we now disable the following warnings:

- E_ENUM_TYPE_MISMATCH_OP
- E_ENUM_TYPE_MISMATCH_ARG
- E_STATEMENT_NOT_REACHED

Those warnings are not too interesting for this code as
we are not going to fix those problems anyway.

The original problem we encountered was the following:

In solaris, the xdrrec_putlong function has the following check:

if ((*lp > INT32_MAX) || (*lp < INT32_MIN))
return (FALSE);

As the NDMP code assumes everywhere that long is 4 bytes, but on LP64 it
is 8 bytes, we get the problem that this check triggers and we get
always false back. The LP64 gets enabled when compiling your code for
64 bits on at least SPARC. We didn't see this phenomenon on 64 bits
compiled code on X86 with the Solaris Studio compiler on Illumos.

We fix this problem by using XDR_GETINT32 and XDR_PUTINT32 on LP64,
instead of XDR_GETLONG and XDR_PUTLONG which handles 4 bytes and so
works as desired.

Signed-off-by: Philipp Storz <philipp.storz@bareos.com>
mod - src/ndmp/ndma_comm_dispatch.c Diff File
mod - src/ndmp/ndma_cops_backreco.c Diff File
mod - src/ndmp/ndma_cops_query.c Diff File
mod - src/ndmp/ndma_ctrl_calls.c Diff File
mod - src/ndmp/ndma_ctrl_media.c Diff File
mod - src/ndmp/ndma_ctst_mover.c Diff File
mod - src/ndmp/ndma_ctst_subr.c Diff File
mod - src/ndmp/ndma_ctst_tape.c Diff File
mod - src/ndmp/ndma_data.c Diff File
mod - src/ndmp/ndma_data_fh.c Diff File
mod - src/ndmp/ndma_listmgmt.c Diff File
mod - src/ndmp/ndma_noti_calls.c Diff File
mod - src/ndmp/ndma_tape.c Diff File
mod - src/ndmp/ndma_tape_simulator.c Diff File
mod - src/ndmp/ndmagents.h Diff File
mod - src/ndmp/ndmjob_simulator.c Diff File
mod - src/ndmp/ndml_chan.c Diff File
mod - src/ndmp/ndml_fhdb.c Diff File
mod - src/ndmp/ndml_log.c Diff File
mod - src/ndmp/ndml_media.c Diff File
mod - src/ndmp/ndmlib.h Diff File
mod - src/ndmp/ndmos.h Diff File
mod - src/ndmp/ndmos_common.c Diff File
mod - src/ndmp/ndmp0.x Diff File
mod - src/ndmp/ndmp2.x Diff File
mod - src/ndmp/ndmp2_translate.c Diff File
mod - src/ndmp/ndmp2_xmt.c Diff File
mod - src/ndmp/ndmp3.x Diff File
mod - src/ndmp/ndmp3_translate.c Diff File
mod - src/ndmp/ndmp3_xmt.c Diff File
mod - src/ndmp/ndmp4.x Diff File
mod - src/ndmp/ndmp4_translate.c Diff File
mod - src/ndmp/ndmp4_xmt.c Diff File
mod - src/ndmp/ndmp9.x Diff File
mod - src/ndmp/ndmp9_xmt.c Diff File
mod - src/ndmp/ndmp_msg_buf.h Diff File
mod - src/ndmp/ndmp_translate.c Diff File
mod - src/ndmp/ndmp_translate.h Diff File
mod - src/ndmp/smc.h Diff File
mod - src/ndmp/smc_raw.h Diff File
mod - src/ndmp/wraplib.c Diff File
mod - src/ndmp/wraplib.h Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-14.2 f4ad97c2

2015-11-03 00:12

mvwieringen

Ported: N/A

Details Diff		 NDMP: Switch ndmplib to 2015 data types.

- u_short ==> uint16_t
- u_long ==> uint32_t
- int ==> int32_t
- unsigned long long ==> uint64_t
- long long ==> int64_t
- unsigned long ==> uint32_t
- unsigned short ==> uint16_t

For GCC we now disable the following warning:

-Wunused-variable
-Wunused-but-set-variable
-Wformat
-Wenum-compare

For the Solaris Studio compiler we now disable the following warnings:

- E_ENUM_TYPE_MISMATCH_OP
- E_ENUM_TYPE_MISMATCH_ARG
- E_STATEMENT_NOT_REACHED

Those warnings are not too interesting for this code as
we are not going to fix those problems anyway.

The original problem we encountered was the following:

In solaris, the xdrrec_putlong function has the following check:

if ((*lp > INT32_MAX) || (*lp < INT32_MIN))
return (FALSE);

As the NDMP code assumes everywhere that long is 4 bytes, but on LP64 it
is 8 bytes, we get the problem that this check triggers and we get
always false back. The LP64 gets enabled when compiling your code for
64 bits on at least SPARC. We didn't see this phenomenon on 64 bits
compiled code on X86 with the Solaris Studio compiler on Illumos.

We fix this problem by using XDR_GETINT32 and XDR_PUTINT32 on LP64,
instead of XDR_GETLONG and XDR_PUTLONG which handles 4 bytes and so
works as desired.

Signed-off-by: Philipp Storz <philipp.storz@bareos.com>
mod - src/ndmp/ndma_comm_dispatch.c Diff File
mod - src/ndmp/ndma_cops_backreco.c Diff File
mod - src/ndmp/ndma_cops_query.c Diff File
mod - src/ndmp/ndma_ctrl_calls.c Diff File
mod - src/ndmp/ndma_ctrl_media.c Diff File
mod - src/ndmp/ndma_ctst_mover.c Diff File
mod - src/ndmp/ndma_ctst_subr.c Diff File
mod - src/ndmp/ndma_ctst_tape.c Diff File
mod - src/ndmp/ndma_data.c Diff File
mod - src/ndmp/ndma_data_fh.c Diff File
mod - src/ndmp/ndma_listmgmt.c Diff File
mod - src/ndmp/ndma_noti_calls.c Diff File
mod - src/ndmp/ndma_tape.c Diff File
mod - src/ndmp/ndma_tape_simulator.c Diff File
mod - src/ndmp/ndmagents.h Diff File
mod - src/ndmp/ndmjob_simulator.c Diff File
mod - src/ndmp/ndml_chan.c Diff File
mod - src/ndmp/ndml_fhdb.c Diff File
mod - src/ndmp/ndml_log.c Diff File
mod - src/ndmp/ndml_media.c Diff File
mod - src/ndmp/ndmlib.h Diff File
mod - src/ndmp/ndmos.h Diff File
mod - src/ndmp/ndmos_common.c Diff File
mod - src/ndmp/ndmp0.x Diff File
mod - src/ndmp/ndmp2.x Diff File
mod - src/ndmp/ndmp2_translate.c Diff File
mod - src/ndmp/ndmp2_xmt.c Diff File
mod - src/ndmp/ndmp3.x Diff File
mod - src/ndmp/ndmp3_translate.c Diff File
mod - src/ndmp/ndmp3_xmt.c Diff File
mod - src/ndmp/ndmp4.x Diff File
mod - src/ndmp/ndmp4_translate.c Diff File
mod - src/ndmp/ndmp4_xmt.c Diff File
mod - src/ndmp/ndmp9.x Diff File
mod - src/ndmp/ndmp9_xmt.c Diff File
mod - src/ndmp/ndmp_msg_buf.h Diff File
mod - src/ndmp/ndmp_translate.c Diff File
mod - src/ndmp/ndmp_translate.h Diff File
mod - src/ndmp/smc.h Diff File
mod - src/ndmp/smc_raw.h Diff File
mod - src/ndmp/wraplib.c Diff File
mod - src/ndmp/wraplib.h Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-15.2 7c7148ff

2015-11-02 23:08

joergs


Committer: mvwieringen

Ported: N/A

Details Diff		 bcommand: support compact json representation

By default, compact = false.
Using ".api json compact=true" can reduce the json result string by 1/3,
so it is adviced to use this whenever human readablity is not required.
mod - src/dird/ua_dotcmds.c Diff File
mod - src/dird/ua_output.c Diff File
mod - src/lib/output_formatter.c Diff File
mod - src/lib/output_formatter.h Diff File
 First  Prev  1 2 3 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 531 532 533 534 535 536 537 ... 560 ... 630 ... 665 666 667  Next  Last