0000588: Incremental MSSQL backup fails when database name contains spaces - Bareos Bug Tracker

ID	Project	Category	View Status	Date Submitted	Last Update

0000588	bareos-core	file daemon	public	2015-12-24 17:52	2019-12-18 15:25

Reporter	jkimalane	Assigned To
Priority	high	Severity	major	Reproducibility	always
Status	closed	Resolution	fixed
Platform	MSSQL 2012	OS	Windows Server	OS Version	2012
Product Version	15.2.2
Fixed in Version	15.2.3

Summary	0000588: Incremental MSSQL backup fails when database name contains spaces
Description	Incremental database backup fails when database name contains spaces. 24-Dec 15:18 srv-xxx-01-fd JobId 7491: Fileset has no "File=" directives, ignoring FilesNotToBackup Registry key 24-Dec 15:19 srv-xxx-01-fd JobId 7491: Fatal error: mssqlvdi-fd: IClientVirtualDeviceSet2::GetConfiguration failed 24-Dec 15:19 srv-xxx-01-fd JobId 7491: Fatal error: Incorrect syntax near 'DB'. Incorrect syntax near the keyword 'with'. If this statement is a common table expression, an xmlnamespaces clause or a change tracking context clause, the previous statement must be terminated with a semicolon.
Additional Information	It's very easy to fix this issue: file "mssqlvdi-fd.c" case L_INCREMENTAL: Mmsg(ado_query, "BACKUP LOG %s TO VIRTUAL_DEVICE='%s' WITH BLOCKSIZE=%d, BUFFERCOUNT=%d, MAXTRANSFERSIZE=%d", to case L_INCREMENTAL: Mmsg(ado_query, "BACKUP LOG [%s] TO VIRTUAL_DEVICE='%s' WITH BLOCKSIZE=%d, BUFFERCOUNT=%d, MAXTRANSFERSIZE=%d",
Tags	No tags attached.

mvwieringen 2015-12-24 18:53 developer ~0002063	Seems we missed the incremental case when we implemented this recently for full backups. The patch needs to be in two places e.g. also in the restore. I added it to our internal repo it will be pushed on our next sync point to github. As that triggers a rebuild for now I won't do it as we just published a version today that we first want to finish. When we push this fix it will update this bug report and set it to resolved.

mvwieringen 2016-07-08 14:34 developer ~0002307	Fix committed to bareos bareos-14.2 branch with changesetid 6411.

bareos: master 91ebb8ed 2015-12-24 19:47 Marco van Wieringen Ported: N/A Details Diff	mssqlvdi: Fix backup/restore of incremental backups Add missing support to incremental backups and restores for MSSQL backups analog to the support we added recently for full backups. Fixes 0000588: Incremental MSSQL backup fails when database name contains spaces		Affected Issues 0000588
	mod - src/win32/plugins/filed/mssqlvdi-fd.c		Diff File
bareos: bareos-14.2 55bf15f3 2015-12-24 19:47 mvwieringen Ported: N/A Details Diff	mssqlvdi: Fix backup/restore of incremental backups Add missing support to incremental backups and restores for MSSQL backups analog to the support we added recently for full backups. Fixes 0000588: Incremental MSSQL backup fails when database name contains spaces		Affected Issues 0000588
	mod - src/win32/plugins/filed/mssqlvdi-fd.c		Diff File

Date Modified	Username	Field	Change
2015-12-24 17:52	jkimalane	New Issue
2015-12-24 18:50	mvwieringen	Assigned To	=> mvwieringen
2015-12-24 18:50	mvwieringen	Status	new => assigned
2015-12-24 18:53	mvwieringen	Note Added: 0002063
2015-12-26 23:02	mvwieringen	Changeset attached	=> bareos master 91ebb8ed
2015-12-26 23:03	mvwieringen	Assigned To	mvwieringen =>
2015-12-26 23:03	mvwieringen	Status	assigned => resolved
2015-12-26 23:03	mvwieringen	Fixed in Version	=> 15.2.3
2016-02-25 17:02	maik	Relationship added	child of 0000625
2016-07-05 11:54	joergs	Relationship added	child of 0000584
2016-07-08 14:34	mvwieringen	Changeset attached	=> bareos bareos-14.2 55bf15f3
2016-07-08 14:34	mvwieringen	Note Added: 0002307
2016-07-08 14:34	mvwieringen	Resolution	open => fixed
2019-12-18 15:25	arogge	Status	resolved => closed