View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000633 | bareos-core | director | public | 2016-03-21 14:06 | 2016-10-13 11:55 |
| Reporter | mvwieringen | Assigned To | mvwieringen | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | Solaris11 | OS | Solaris | OS Version | 11 |
| Product Version | 15.2.3 | ||||
| Summary | 0000633: Interactive run doesn't update pool on level change. | ||||
| Description | When you change the level of a backup and you have specific pools defined for Full, Differential, Incremental defined in the Job you would expect that the Pool used for the Job gets update to point to the defined Pool. | ||||
| Additional Information | In interactive mode when changing the level we correctly call apply_pool_overrides() which sets the new pool right but then we call reset_restore_context() which sets the pool back to rc.pool (e.g. restore context pool definition which still points to the original pool defined in the Job resource.) | ||||
| Tags | No tags attached. | ||||
|
bareos: master b39591ee 2016-03-21 15:07 Committer: pstorz Ported: N/A Details Diff |
dird: Interactive run doesn't update pool on level change. In interactive mode when changing the level we correctly call apply_pool_overrides() which sets the new pool right but then we call reset_restore_context() which sets the pool back to rc.pool (e.g. restore context pool definition which still points to the original pool defined in the Job resource.) This patch updates the rc.pool to point to the pool which was set by the call to apply_pool_overrides() and set a variable in the restore context which keeps track that we got a level override so we don't overwrite the pool_source which is also set by apply_pool_overrides() in reset_restore_context(). When we get a real pool override via the mod pool option we reset this level override flag so we set the right pool_source in reset_restore_context() again. Fixes 0000633: Interactive run doesn't update pool on level change. |
Affected Issues 0000633 |
|
| mod - src/dird/ua.h | Diff File | ||
| mod - src/dird/ua_run.c | Diff File | ||
|
bareos: bareos-14.2 1b085aed 2016-03-21 15:07 Ported: N/A Details Diff |
dird: Interactive run doesn't update pool on level change. In interactive mode when changing the level we correctly call apply_pool_overrides() which sets the new pool right but then we call reset_restore_context() which sets the pool back to rc.pool (e.g. restore context pool definition which still points to the original pool defined in the Job resource.) This patch updates the rc.pool to point to the pool which was set by the call to apply_pool_overrides() and set a variable in the restore context which keeps track that we got a level override so we don't overwrite the pool_source which is also set by apply_pool_overrides() in reset_restore_context(). When we get a real pool override via the mod pool option we reset this level override flag so we set the right pool_source in reset_restore_context() again. Fixes 0000633: Interactive run doesn't update pool on level change. |
Affected Issues 0000633 |
|
| mod - src/dird/ua.h | Diff File | ||
| mod - src/dird/ua_run.c | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-03-21 14:06 | mvwieringen | New Issue | |
| 2016-03-21 14:06 | mvwieringen | Status | new => assigned |
| 2016-03-21 14:06 | mvwieringen | Assigned To | => mvwieringen |
| 2016-04-01 17:44 | pstorz | Changeset attached | => bareos master b39591ee |
| 2016-04-01 17:44 | pstorz | Note Added: 0002226 | |
| 2016-04-01 17:44 | pstorz | Status | assigned => resolved |
| 2016-04-01 17:44 | pstorz | Resolution | open => fixed |
| 2016-06-14 11:28 | maik | Relationship added | child of 0000641 |
| 2016-07-05 11:39 | joergs | Relationship added | child of 0000584 |
| 2016-07-08 14:34 | mvwieringen | Changeset attached | => bareos bareos-14.2 1b085aed |
| 2016-07-08 14:34 | mvwieringen | Note Added: 0002313 | |
| 2016-10-13 11:55 | maik | Note Added: 0002386 | |
| 2016-10-13 11:55 | maik | Status | resolved => closed |
