0000062: update all volumes from all pools gives error when a pool doesnt contain volumes

ID	Project	Category	View Status	Date Submitted	Last Update

0000062	bareos-core	director	public	2013-02-12 11:53	2015-03-25 19:18

Reporter	pstorz	Assigned To
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	closed	Resolution	fixed
Platform	Linux	OS	any	OS Version	3
Product Version	12.4.2
Fixed in Version	12.4.2

Summary	0000062: update all volumes from all pools gives error when a pool doesnt contain volumes
Description	We get an error when calling "update all volumes from all pools" when one pool doesn't have any volumes. It would be better to improve the sql query to only try to update volumes if there are volumes.
Tags	No tags attached.

pstorz 2013-02-12 13:57 administrator ~0000088	*update volume Automatically selected Catalog: MyCatalog Using Catalog "MyCatalog" Parameters to modify: 1: Volume Status 2: Volume Retention Period 3: Volume Use Duration 4: Maximum Volume Jobs 5: Maximum Volume Files 6: Maximum Volume Bytes 7: Recycle Flag 8: Slot 9: InChanger Flag 10: Volume Files 11: Pool 12: Volume from Pool 13: All Volumes from Pool 14: All Volumes from all Pools 15: Enabled 16: RecyclePool 17: Action On Purge 18: Done Select parameter to modify (1-18): 14 Error updating Volume records: ERR=sql_update.c:461 Update failed: affected_rows=0 for UPDATE Media SET ActionOnPurge=0, Recycle=1,VolRetention=31536000,VolUseDuration=0,MaxVolJobs=0,MaxVolFiles=0,MaxVolBytes=0,RecyclePoolId=0 WHERE PoolId=1 All Volume defaults updated from "File" Pool record. Error updating Volume records: ERR=sql_update.c:461 Update failed: affected_rows=0 for UPDATE Media SET ActionOnPurge=0, Recycle=1,VolRetention=31536000,VolUseDuration=0,MaxVolJobs=0,MaxVolFiles=0,MaxVolBytes=0,RecyclePoolId=0 WHERE PoolId=3

~~mvwieringen adm~~ 2013-08-13 03:12 administrator ~0000628	Fix committed to bareos master branch with changesetid 864.

mvwieringen 2015-03-25 16:51 developer ~0001402	Fix committed to bareos2015 bareos-13.2 branch with changesetid 4420.

joergs 2015-03-25 19:18 developer ~0001553	Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again. Sorry for the noise.

bareos: master 73aea826 2013-05-04 11:51 pstorz Committer: ~~mvwieringen adm~~ Ported: N/A Details Diff	Ignore affected rows in UPDATE_DB We get an error message from UPDATE_DB , when the number of affected rows is < 1. In some cases, its ok to have no affected rows, like in "update all volumes from all pools", when there is a pool with no volumes inside. Fixes 0000062: update all volumes from all pools gives error when a pool doesnt contain volumes Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>	Affected Issues 0000062
	mod - src/cats/sql_update.c	Diff File
	mod - src/cats/sql.c	Diff File
	mod - src/cats/cats.h	Diff File
bareos2015: bareos-12.4 f581870b 2013-05-04 13:51 pstorz Committer: mvwieringen Ported: N/A Details Diff	Ignore affected rows in UPDATE_DB We get an error message from UPDATE_DB , when the number of affected rows is < 1. In some cases, its ok to have no affected rows, like in "update all volumes from all pools", when there is a pool with no volumes inside. Fixes 0000062: update all volumes from all pools gives error when a pool doesnt contain volumes Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>	Affected Issues 0000062
	mod - src/cats/cats.h	Diff File
	mod - src/cats/sql.c	Diff File
	mod - src/cats/sql_update.c	Diff File
bareos2015: bareos-13.2 989193c2 2013-05-04 13:51 pstorz Committer: mvwieringen Ported: N/A Details Diff	Ignore affected rows in UPDATE_DB We get an error message from UPDATE_DB , when the number of affected rows is < 1. In some cases, its ok to have no affected rows, like in "update all volumes from all pools", when there is a pool with no volumes inside. Fixes 0000062: update all volumes from all pools gives error when a pool doesnt contain volumes Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>	Affected Issues 0000062
	mod - src/cats/cats.h	Diff File
	mod - src/cats/sql.c	Diff File
	mod - src/cats/sql_update.c	Diff File

Date Modified	Username	Field	Change
2013-02-12 11:53	pstorz	New Issue
2013-02-12 13:57	pstorz	Note Added: 0000088
2013-02-12 14:48	mvwieringen	Changeset attached	=> bareos master 11554bfd
2013-02-12 14:48	mvwieringen	Assigned To	=> mvwieringen
2013-02-12 14:48	mvwieringen	Status	new => closed
2013-02-12 14:48	mvwieringen	Resolution	open => fixed
2013-02-12 16:30	mvwieringen	Target Version	=> 12.4.0
2013-02-12 16:30	mvwieringen	Fixed in Version	=> 12.4.0
2013-02-12 16:30	mvwieringen	Assigned To	mvwieringen =>
2013-03-04 10:35	mvwieringen	Product Version	=> 12.4.2
2013-03-04 10:35	mvwieringen	Fixed in Version	=> 12.4.2
2013-08-13 03:12	~~mvwieringen adm~~	Changeset attached	=> bareos master 73aea826
2013-08-13 03:12	~~mvwieringen adm~~	Note Added: 0000628
2013-08-13 03:12	~~mvwieringen adm~~	Assigned To	=> mvwieringen adm
2013-08-13 03:12	~~mvwieringen adm~~	Status	closed => resolved
2013-08-13 08:40	~~mvwieringen adm~~	Assigned To	mvwieringen adm =>
2013-08-13 08:40	~~mvwieringen adm~~	Status	resolved => closed
2015-03-25 16:51	mvwieringen	Changeset attached	=> bareos2015 bareos-12.4 f581870b
2015-03-25 16:51	mvwieringen	Changeset attached	=> bareos2015 bareos-13.2 989193c2
2015-03-25 16:51	mvwieringen	Note Added: 0001402
2015-03-25 16:51	mvwieringen	Status	closed => resolved
2015-03-25 19:18	joergs	Note Added: 0001553
2015-03-25 19:18	joergs	Status	resolved => closed

Reporting new Issues is disabled, please Report new Issues at https://github.com/bareos/bareos/issues

View Issue Details

Activities

Related Changesets

Issue History