View Issue Details

IDProjectCategoryView StatusLast Update
0000542bareos-core[All Projects] directorpublic2015-10-23 22:42
ReporterfranckAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionopen 
PlatformLinuxOSDebianOS Version7
Product Version14.2.2 
Fixed in Version14.2.6 
Summary0000542: Director crashes if a restore command is issued with an unexisting restoreclient
DescriptionPiping a restore command with an unexisting restore client crashed bareos-dir:
echo 'restore client=Mentions13 restoreclient=DR_Mentions15 fileset=Mentions13_fs pool=Mentions13-offsite-full-pool storage=Mentions13-offsite-full-storage jobid=21521 regexwhere=%/var/local/pg-backup/br150d/%/pg_dump/%,%/var/lib/postgresql/%/tmp/pg_restore/% select all done yes' | bconsole

Message in daemon.log:
Oct 23 10:37:48 k1002 bareos-dir: bsock_tcp.c:364 Socket is terminated=1 on call to client:10.0.10.201:9101
Oct 23 10:37:50 k1002 bareos-dir: BAREOS interrupted by signal 11: Segmentation violation

Steps To ReproducePipe a restore command like the one above with a restoreclient= option set to a client that doesn't exist.
Additional InformationCouldn't find this in the bug tracker, apologies if it had already been reported.
Didn't try to run the restore command with less args, or setting other args to wrong values.
The command runs perfectly when the arg value is corrected.
The command also fails when ran interactively from bconsole (it asks for existing client and fails when you abort it with '.')
TagsNo tags attached.
bareos-master: impactyes
bareos-master: actionwill care
bareos-19.2: impact
bareos-19.2: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impactyes
bareos-15.2: actionwill care
bareos-14.2: impactyes
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Activities

There are no notes attached to this issue.

Related Changesets

bareos: master 34bc6484

2015-10-23 17:45:57

joergs


Committer: mvwieringen

Ported: N/A

Details Diff
bcommand restore: fixes parameter checking

This patch prevents a crash, if an invalid client, backupclient or
restoreclient is given.

Fixes 542: Director crashes if a restore command is issued with an
unexisting restoreclient
Affected Issues
0000542
mod - src/dird/ua_restore.c Diff File
mod - src/dird/ua_run.c Diff File

Issue History

Date Modified Username Field Change
2015-10-23 12:49 franck New Issue
2015-10-23 16:03 joergs Assigned To => joergs
2015-10-23 16:03 joergs Status new => confirmed
2015-10-23 16:04 joergs bareos-master: impact => yes
2015-10-23 16:04 joergs bareos-master: action => will care
2015-10-23 16:04 joergs bareos-15.2: impact => yes
2015-10-23 16:04 joergs bareos-15.2: action => will care
2015-10-23 16:04 joergs bareos-14.2: impact => yes
2015-10-23 22:41 mvwieringen Changeset attached => bareos master 34bc6484
2015-10-23 22:42 mvwieringen Assigned To joergs =>
2015-10-23 22:42 mvwieringen Status confirmed => resolved
2015-10-23 22:42 mvwieringen Fixed in Version => 14.2.6