View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000533 | bareos-core | vmware plugin | public | 2015-10-07 12:18 | 2015-10-29 15:39 |
Reporter | mhulsman | Assigned To | |||
Priority | high | Severity | minor | Reproducibility | always |
Status | closed | Resolution | no change required | ||
Platform | Linux | OS | CentOS | OS Version | 7 |
Summary | 0000533: VMWare plugin is not detecting accurate parameter on remote FD. | ||||
Description | Got a patch from Marco v Wieringen to detect is accurate is enabled on a VMware job. This is working correctly on a host where the DIR, FD and SD is installed. But when I create a job that is running on a remote FD and SD and accurate is enabled, it is not detected. On all instances the BareosFdPluginVMware.py is modified with applied patch. Removed all *pyc files in the /usr/lib64/bareos/plugins/vmware_plugin after applying the patch. | ||||
Steps To Reproduce | This is on a remote FD and SD Enable Accurate in the global job definition JobDefs { Name = "DefaultJob Accurate = yes } Create a VMware job: FileSet { Name = "vm-test_fileset" Include { Options { signature = MD5 Compression = GZIP } Plugin = "python:module_path=/usr/lib64/bareos/plugins/vmware_plugin:module_name=bareos-fd-vmware:dc=test:folder=/test:vmname=test:vcserver=vcenter@local.com:vcuser=bareos@vsphere.loc al:vcpass=xxxxx" } } Job { Name = "vm-test" JobDefs = "DefaultJob" Client = remote-fd FileSet = "vm-test_fileset" } Joblog on a local FD and SD with Accurate global enabled: 07-Oct 11:53 local-fd JobId 168: Fatal error: start_backup_job: Accurate backup not allowed please disable in Job 07-Oct 11:53 local-fd JobId 168: Fatal error: fd_plugins.c:549 Command plugin "python:module_path=/usr/lib64/bareos/plugins/vmware_plugin:module_name=XXX:dc=YY:folder=/test:vmname=ZZ:vcserver=test.local.com:vcuser=bareos@vsphere.local:vcpass=XXXX" requested, but is not loaded. 07-Oct 11:53 local-fd JobId 168: Warning: No snapshot was taken, skipping snapshot removal Joblog on a remote FD and SD with Accurate global enabled: (an error should be raised) ....... VSS: no Encryption: no Accurate: yes Joblog on a remote FD and SD with Accurate global enabled but Accurate disabled in VM-Jobdef: ....... VSS: no Encryption: no Accurate: no | ||||
Additional Information | Patch that is applied: diff --git a/vmware_plugin/BareosFdPluginVMware.py b/vmware_plugin/BareosFdPluginVMware.py index d19ed0d..6f424ef 100644 --- a/vmware_plugin/BareosFdPluginVMware.py +++ b/vmware_plugin/BareosFdPluginVMware.py @@ -117,6 +117,13 @@ class BareosFdPluginVMware(BareosFdPluginBaseclass.BareosFdPluginBaseclass): if check_option_bRC != bRCs['bRC_OK']: return check_option_bRC + accurate_enabled = bareosfd.GetValue(context, bVariable['bVarAccurate']) + if accurate_enabled != 0: + bareosfd.JobMessage( + context, bJobMessageType['M_FATAL'], + "start_backup_job: Accurate backup not allowed please disable in Job\n") + return bRCs['bRC_Error'] + if not self.vadp.connect_vmware(context): return bRCs['bRC_Error'] | ||||
Tags | No tags attached. | ||||
I've noted that this accurate detection in the plugin code only applies for incremental and differential jobs. However, as there is no technical difference between accurate and non-accurate for full, that should be no problem. Could you check if your test with remote fd/sd was incremental or differential? |
|
You are absolutely right. I did an additional check, and it only applies for differential and incremental jobs. And the plugin is working as it should. I made the mistake of only running a Full backup, and did not test with diff and incr. Tested again on a remote FD with Accurate enabled, the first full is running fine, an incremental is raising a fatal error as it should. When disabling the Accurate and running an incremental again the snapshot is taken and the backup is finishing correctly. Please close this call, this was a misunderstanding from my side. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2015-10-07 12:18 | mhulsman | New Issue | |
2015-10-11 12:32 | stephand | Note Added: 0001874 | |
2015-10-11 12:32 | stephand | Assigned To | => stephand |
2015-10-11 12:32 | stephand | Status | new => assigned |
2015-10-11 12:33 | stephand | Status | assigned => feedback |
2015-10-12 09:43 | mhulsman | Note Added: 0001875 | |
2015-10-12 09:43 | mhulsman | Status | feedback => assigned |
2015-10-29 15:39 | mvwieringen | Assigned To | stephand => |
2015-10-29 15:39 | mvwieringen | Status | assigned => closed |
2015-10-29 15:39 | mvwieringen | Resolution | open => no change required |