0000428: bpipe plugin on windows and colon character problem

ID	Project	Category	View Status	Date Submitted	Last Update

0000428	bareos-core	file daemon	public	2015-02-27 13:05	2015-06-01 16:24

Reporter	geowulf	Assigned To
Priority	normal	Severity	feature	Reproducibility	always
Status	closed	Resolution	fixed
Platform	Linux	OS	CentOS	OS Version	6
Product Version	14.2.2

Summary	0000428: bpipe plugin on windows and colon character problem
Description	It is not possible to use colon character ":" in the READER command parameters Escape character is not working too. e.g. backup of firebird DB. See below: FileSet { Name = "firebird" EnableVSS = no Include { Options { Signature = MD5 Compression = GZIP } Plugin = "bpipe:file=DB_TEST:reader=gbak.exe -backup -user user -password password SERVER:TEST_DB STDOUT" } } Always returned with error: 2015-02-27 12:35:45 bareos-dir JobId 38: No prior Full backup Job record found. 2015-02-27 12:35:45 bareos-dir JobId 38: No prior or suitable Full backup found in catalog. Doing FULL backup. 2015-02-27 12:35:47 bareos-dir JobId 38: Start Backup JobId 38, Job=Firebird-Test.2015-02-27_12.35.45_49 2015-02-27 12:35:47 bareos-dir JobId 38: Using Device "BRSDEV_01" to write. 2015-02-27 12:35:48 test JobId 38: Fatal error: Illegal argument TEST_CZ STDOUT without value
Steps To Reproduce	E.g. use full path for READER command C:\\Program Files\\Firebird ....
Tags	No tags attached.

mvwieringen 2015-02-28 14:17 developer ~0001282	Correct bpipe and any other plugin never had support for escaping the special character ':' which is clasified as a separator and an illegal character in the current plugin parsers. As I already ran into this problem while writing the gfapi plugin for GlusterFS there is some code to escape the special character using \: in that plugin. If we backport this code it should be possible to allow this construct in the other plugins too as we implemented the same parser in each plugin available today. So this is more a matter of time before we will close this feature request. I changed it to a feature request as its a known and calculated design decision.

pstorz 2015-03-27 18:16 administrator ~0001655	Fix committed to bareos master branch with changesetid 5144.

mvwieringen 2015-05-29 18:06 developer ~0001750	Fix committed to bareos bareos-14.2 branch with changesetid 5314.

bareos: master f9214b8f 2015-02-27 21:54 mvwieringen Committer: pstorz Ported: N/A Details Diff	Add escape parsing to generic plugin option parser. Backport the new escaping of the ':' using '\:' to all existing plugin config parsers. This code comes from the new cephfs-fd and gfapi-fd plugins. Fixes 0000428: bpipe plugin on windows and colon character problem	Affected Issues 0000428
	mod - src/plugins/dird/python-dir.c	Diff File
	mod - src/plugins/filed/bpipe-fd.c	Diff File
	mod - src/plugins/filed/python-fd.c	Diff File
	mod - src/plugins/filed/rados-fd.c	Diff File
	mod - src/plugins/stored/python-sd.c	Diff File
	mod - src/win32/plugins/filed/mssqlvdi-fd.c	Diff File
bareos: bareos-14.2 c5425bd7 2015-02-27 21:54 mvwieringen Ported: N/A Details Diff	Add escape parsing to generic plugin option parser. Backport the new escaping of the ':' using '\:' to all existing plugin config parsers. This code comes from the new cephfs-fd and gfapi-fd plugins. Fixes 0000428: bpipe plugin on windows and colon character problem	Affected Issues 0000428
	mod - src/plugins/dird/python-dir.c	Diff File
	mod - src/plugins/filed/bpipe-fd.c	Diff File
	mod - src/plugins/filed/python-fd.c	Diff File
	mod - src/plugins/stored/python-sd.c	Diff File
	mod - src/win32/plugins/filed/mssqlvdi-fd.c	Diff File

Date Modified	Username	Field	Change
2015-02-27 13:05	geowulf	New Issue
2015-02-28 14:11	mvwieringen	Severity	minor => feature
2015-02-28 14:17	mvwieringen	Note Added: 0001282
2015-02-28 14:18	mvwieringen	Assigned To	=> mvwieringen
2015-02-28 14:18	mvwieringen	Status	new => feedback
2015-03-27 18:16	pstorz	Changeset attached	=> bareos master f9214b8f
2015-03-27 18:16	pstorz	Note Added: 0001655
2015-03-27 18:16	pstorz	Status	feedback => resolved
2015-03-27 18:16	pstorz	Resolution	open => fixed
2015-03-31 15:25	~~mvwieringen adm~~	Assigned To	mvwieringen =>
2015-05-27 12:51	joergs	Relationship added	child of 0000447
2015-05-29 18:06	mvwieringen	Changeset attached	=> bareos bareos-14.2 c5425bd7
2015-05-29 18:06	mvwieringen	Note Added: 0001750
2015-06-01 16:24	joergs	Status	resolved => closed