 |
As there is already support for ANSI labels are you sure that setting Check Labels = yes in the device section(s) of the storage daemon is not sufficient. It seems LTFS uses a ANSI label followed by a FileMarker and then some XML data and the again a FileMarker. From the documentation: This directive is implemented in the the SD Device resource. If you intend to read ANSI or IBM labels, this *must* be set. Even if the volume is not ANSI labeled, you can set this to yes, and Bareos will check the label type. Without this directive set to yes, Bareos will assume that labels are of Bacula type and will not check for ANSI or IBM labels. In other words, if there is a possibility of Bareos encountering an ANSI/IBM label, you must set this to yes. |
|
|
Yes, that worked - tested it just now. Thank you. Is there any reason not to enable the option by default? It would seem like a safe (and not super-inconvenient) factory setting. |
|
|
The original author of this function thought it made sense to not enable it by default. When I look at what the code does I can imagine that the default of off makes sense as almost no one mix and matches volume types in a library and the ANSI reading code read up to 5 headers. Read a maximum of 5 records VOL1, HDR1, ... HDR4 As most people don't use tapes at all making it default makes little sense as it gives overhead for the common user which is not really interested in this option. |
|
|
Ah, I see. How long do you think the overhead might become at worst? If it's no more that a second or two, IMHO, the extra safeguard against destroying a tape by accident would be worth it for the label command (which is used infrequently). Probably even for those who don't need mixed media in a autoloader, but might just manually pop in a wrong tape by mistake. Anyway, the feature request is spurious as the feature is already in there as an option. Thank you for you help, and feel free to close this. |
|
|
I tried to clarify this in the documentation: https://github.com/bareos/bareos-docs/commit/6550bdd451a054897c2a75783615d7ca11fea28f I'm not sure what impact a changed default will have. I think, most people will not operate with mixed tapes. What could be done without negative impact is to add a comment in the tape default config: https://github.com/bareos/bareos/blob/master/src/defaultconfigs/bareos-sd.d/device-tape-with-autoloader.conf like # enable "Check Label" if tapes with ANSI/IBM labels # should be preserved #Check Label = yes |
|
|
Fix committed to bareos master branch with changesetid 2434. |
|
|
Fix committed to bareos bareos-14.2 branch with changesetid 2480. |
|
|
Fix committed to bareos2015 bareos-14.2 branch with changesetid 4514. |
|
|
Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again. Sorry for the noise. |
- Anonymous
