View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000343 | bareos-core | configuration gui | public | 2014-09-27 09:20 | 2015-03-25 19:19 |
| Reporter | mvwieringen | Assigned To | |||
| Priority | normal | Severity | feature | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Platform | OpenIndiana | OS | OpenIndiana | OS Version | b151a |
| Product Version | 14.2.1 | ||||
| Summary | 0000343: Print config should suppress data from JobDefs | ||||
| Description | Some specific config items in the Job resource could be coming from a JobDef so we should not print those values in the actual Job resource. | ||||
| Additional Information | We could add a new bitmap analog to item_present bitmap already existing in the RES class. When we mark that bit when we populate the jobdef in the populate_jobdefs() function in src/dird/dird_conf.c we can check this bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes) | ||||
| Tags | No tags attached. | ||||
 |
Fix committed to bareos master branch with changesetid 2187. |
|
|
Fix committed to bareos2015 bareos-14.2 branch with changesetid 4612. |
|
|
Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again. Sorry for the noise. |
|
bareos: master 6822b3ba 2014-10-05 11:45 Ported: N/A Details Diff |
Print config should suppress data from JobDefs Some specific config items in the Job resource could be coming from a JobDef so we should not print those values in the actual Job resource. We add a new bitmap analog to item_present bitmap already existing in the RES class. When we mark that bit when we populate the jobdef in the populate_jobdefs() function in src/dird/dird_conf.c we can check this bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes) We also use the same bitmap for defaults so we can use some shortcut logic when printing the config as we then know that the default was set and never replaced by an other setting. We clear the bit in all other parse functions so we know the default is cleared. If the default is replaced with the same value as the original default that is still detected. Only real exception is when omit defaults is set to true then we just like before always print the defaults (but not the data populated from a JobDef.) Fixes 0000343: Print config should suppress data from JobDefs |
Affected Issues 0000343 |
|
| mod - src/dird/dird_conf.c | Diff File | ||
| mod - src/dird/inc_conf.c | Diff File | ||
| mod - src/dird/run_conf.c | Diff File | ||
| mod - src/filed/filed_conf.c | Diff File | ||
| mod - src/lib/parse_conf.c | Diff File | ||
| mod - src/lib/parse_conf.h | Diff File | ||
| mod - src/lib/res.c | Diff File | ||
| mod - src/stored/stored_conf.c | Diff File | ||
|
bareos2015: bareos-14.2 2d1f2b03 2014-10-05 13:45 Ported: N/A Details Diff |
Print config should suppress data from JobDefs Some specific config items in the Job resource could be coming from a JobDef so we should not print those values in the actual Job resource. We add a new bitmap analog to item_present bitmap already existing in the RES class. When we mark that bit when we populate the jobdef in the populate_jobdefs() function in src/dird/dird_conf.c we can check this bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes) We also use the same bitmap for defaults so we can use some shortcut logic when printing the config as we then know that the default was set and never replaced by an other setting. We clear the bit in all other parse functions so we know the default is cleared. If the default is replaced with the same value as the original default that is still detected. Only real exception is when omit defaults is set to true then we just like before always print the defaults (but not the data populated from a JobDef.) Fixes 0000343: Print config should suppress data from JobDefs |
Affected Issues 0000343 |
|
| mod - src/dird/dird_conf.c | Diff File | ||
| mod - src/dird/inc_conf.c | Diff File | ||
| mod - src/dird/run_conf.c | Diff File | ||
| mod - src/filed/filed_conf.c | Diff File | ||
| mod - src/lib/parse_conf.c | Diff File | ||
| mod - src/lib/parse_conf.h | Diff File | ||
| mod - src/lib/res.c | Diff File | ||
| mod - src/stored/stored_conf.c | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2014-09-27 09:20 | mvwieringen | New Issue | |
| 2014-10-06 09:51 | mvwieringen | Assigned To | => mvwieringen |
| 2014-10-06 09:51 | mvwieringen | Status | new => assigned |
| 2014-10-08 09:39 | mvwieringen | Changeset attached | => bareos master 6822b3ba |
| 2014-10-08 09:39 | mvwieringen | Note Added: 0000995 | |
| 2014-10-08 09:39 | mvwieringen | Status | assigned => resolved |
| 2014-10-08 09:39 | mvwieringen | Resolution | open => fixed |
| 2014-10-20 17:02 | mvwieringen | Status | resolved => closed |
| 2014-10-20 17:02 | mvwieringen | Assigned To | mvwieringen => |
| 2015-03-25 16:51 | mvwieringen | Changeset attached | => bareos2015 bareos-14.2 2d1f2b03 |
| 2015-03-25 16:51 | mvwieringen | Note Added: 0001461 | |
| 2015-03-25 16:51 | mvwieringen | Status | closed => resolved |
| 2015-03-25 19:19 | joergs | Note Added: 0001611 | |
| 2015-03-25 19:19 | joergs | Status | resolved => closed |
