View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000311bareos-coredirectorpublic2014-06-16 10:552015-03-25 19:18
Reporterholtkamp Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformLinuxOSRHELOS Version6
Product Version13.2.2 
Summary0000311: Multiple "Exclude Dir Containing" Flags not honored
DescriptionIf you specify multiple "Exclude Dir Containing" files in a Fileset only the last one is honored.
Steps To ReproduceFileset with:

        Exclude Dir Containing = .backupexclude
        Exclude Dir Containing = .nobackup

-> only directories with .nobackup are excluded.
Additional InformationNo biggie, just noticed this.

Suggestion: maybe just write in the documentation that this can be specified only once in a Fileset.
TagsNo tags attached.

Activities

mvwieringen

mvwieringen

2014-06-17 11:18

developer   ~0000908

Its even worse when you specify two values as the code doesn't check if
the option is already set it will leak the memory used to store the previous
value.

Its also one of the only options that only allows a single value. I think
this is just a oversight of the original author of the code as it doesn't
align with all of the other code which uses an alist to store the values.

The fix is obvious to store this also in an alist and add the extra coding
needed. Should be doable without to much effort. (Think I already have it done
just needs some testing.)
mvwieringen

mvwieringen

2014-06-17 13:01

developer   ~0000909

Fix committed to bareos master branch with changesetid 1865.
mvwieringen

mvwieringen

2014-06-18 11:17

developer   ~0000912

Fix committed to bareos bareos-13.2 branch with changesetid 1871.
mvwieringen

mvwieringen

2014-06-18 16:30

developer   ~0000914

Fix committed to bareos bareos-12.4 branch with changesetid 1874.
mvwieringen

mvwieringen

2015-03-25 16:51

developer   ~0001346

Fix committed to bareos2015 bareos-14.2 branch with changesetid 4742.
joergs

joergs

2015-03-25 19:18

developer   ~0001502

Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again.
Sorry for the noise.

Related Changesets

bareos: master b8282d29

2014-06-17 11:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

bareos: bareos-13.2 9b067fec

2014-06-17 11:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

bareos: bareos-12.4 467a786b

2014-06-17 11:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/filed/job.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

bareos2015: bareos-12.4 5e590717

2014-06-17 13:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/filed/job.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

bareos2015: bareos-13.2 5b5c5154

2014-06-17 13:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

bareos2015: bareos-14.2 64a37104

2014-06-17 13:01

mvwieringen

Ported: N/A

Details Diff		 Multiple "Exclude Dir Containing" Flags not honored

It seems when implementing the Exclude Dir Containing option in the
fileset unlike every other item it doesn't allow you to specify multiple
values for this config item. Which is kind of strange and would make it
somewhat better usable. This patch adds the missing support by just
storing the values in an alist just like all others. This also fixes a
memory leak which happens when you used to specify multiple entries as
then it would overwrite the previous string dupped value with the new
value without freeing the old value.

Fixes 0000311: Multiple "Exclude Dir Containing" Flags not honored		 Affected Issues
0000311
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/fileset.c Diff File
mod - src/findlib/find.h Diff File
mod - src/findlib/find_one.c Diff File

Issue History

Date Modified Username Field Change
2014-06-16 10:55 holtkamp New Issue
2014-06-17 11:18 mvwieringen Note Added: 0000908
2014-06-17 11:18 mvwieringen Assigned To => mvwieringen
2014-06-17 11:18 mvwieringen Status new => confirmed
2014-06-17 13:01 mvwieringen Changeset attached => bareos master b8282d29
2014-06-17 13:01 mvwieringen Note Added: 0000909
2014-06-17 13:01 mvwieringen Status confirmed => resolved
2014-06-17 13:01 mvwieringen Resolution open => fixed
2014-06-18 11:17 mvwieringen Changeset attached => bareos bareos-13.2 9b067fec
2014-06-18 11:17 mvwieringen Note Added: 0000912
2014-06-18 16:30 mvwieringen Changeset attached => bareos bareos-12.4 467a786b
2014-06-18 16:30 mvwieringen Note Added: 0000914
2014-10-20 17:02 mvwieringen Status resolved => closed
2014-10-20 17:02 mvwieringen Assigned To mvwieringen =>
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-12.4 5e590717
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-13.2 5b5c5154
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-14.2 64a37104
2015-03-25 16:51 mvwieringen Note Added: 0001346
2015-03-25 16:51 mvwieringen Status closed => resolved
2015-03-25 19:18 joergs Note Added: 0001502
2015-03-25 19:18 joergs Status resolved => closed