View Issue Details

Related ChangesetsJump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000255bareos-coredirectorpublic2013-12-01 15:572015-03-25 19:19
Reportertuxmaster Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformLinuxOSCentOSOS Version6
Product Version13.2.2 
Fixed in Version14.2.0 
Summary0000255: Bad mail subject when an backup terminates with warnings
DescriptionWhen an backup job terminates with "Backup OK -- with warnings" then the mail which is send by the director has the subject : "Bareos: Backup OK of SERVER Incremental".
But no hint of the warning.
Steps To ReproduceRun an backup and an file is change during it.
Additional InformationThis will happens, when an file is changed during backup:
"30-Nov 20:00 bacula-fd JobId 1129: Error: /var/log/journal/2347056590f9c950bb4f066c20f76a25/system.journal: mtime changed during backup."
TagsNo tags attached.

Activities

mvwieringen

mvwieringen

2013-12-01 16:38

developer   ~0000735

This is a known problem.

#ifdef xxxx
   /* The current implementation of the JS_Warning status is not
    * completed. SQL part looks to be ok, but the code is using
    * JS_Terminated almost everywhere instead of (JS_Terminated || JS_Warning)
    * as we do with is_canceled()
    */
   if (jcr->getJobStatus() == JS_Terminated &&
        (jcr->JobErrors || jcr->SDErrors || jcr->JobWarnings)) {
      TermCode = JS_Warnings;
   }
#endif

e.g. so without implementing the above TODO its never going to work corectly.
That the termination message looks ok is only because of this gross hack.

      case JS_Terminated:
         if (jcr->JobErrors || jcr->SDErrors) {
            term_msg = _("Backup OK -- with warnings");
         } else {
            term_msg = _("Backup OK");
         }
         break;
mvwieringen

mvwieringen

2013-12-01 16:42

developer   ~0000736

Its not something very high on our current list of problems. It means maybe
some trivial changes but a lot of testing to find all corner cases.
Its been in Bacula like forever so unless some volunteer comes along its not
like it will be fixed any time soon.
mvwieringen

mvwieringen

2014-01-02 13:14

developer   ~0000778

Fix committed to bareos master branch with changesetid 1403.
mvwieringen

mvwieringen

2015-03-25 16:51

developer   ~0001480

Fix committed to bareos2015 bareos-14.2 branch with changesetid 4947.
joergs

joergs

2015-03-25 19:19

developer   ~0001630

Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again.
Sorry for the noise.

Related Changesets

bareos: master d45b3c75

2013-12-27 13:07

mvwieringen

Ported: N/A

Details Diff		 First attempt at proper support for JS_Warnings

Hopefully fixes a TODO from March 2009 when the first attempt was made
to introduce JS_Warnings but things never finished.

Fixes 0000255: Bad mail subject when an backup terminates with warnings		 Affected Issues
0000255
mod - src/cats/bvfs.c Diff File
mod - src/dird/backup.c Diff File
mod - src/dird/jobq.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ndmp_dma.c Diff File
mod - src/dird/vbackup.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/include/jcr.h Diff File
mod - src/lib/runscript.c Diff File
mod - src/qt-console/util/comboutil.cpp Diff File
mod - src/stored/bscan.c Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos2015: bareos-14.2 7202a401

2013-12-27 14:07

mvwieringen

Ported: N/A

Details Diff		 First attempt at proper support for JS_Warnings

Hopefully fixes a TODO from March 2009 when the first attempt was made
to introduce JS_Warnings but things never finished.

Fixes 0000255: Bad mail subject when an backup terminates with warnings		 Affected Issues
0000255
mod - src/cats/bvfs.c Diff File
mod - src/dird/backup.c Diff File
mod - src/dird/jobq.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ndmp_dma.c Diff File
mod - src/dird/vbackup.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/include/jcr.h Diff File
mod - src/lib/runscript.c Diff File
mod - src/qt-console/util/comboutil.cpp Diff File
mod - src/stored/bscan.c Diff File
mod - src/stored/ndmp_tape.c Diff File

Issue History

Date Modified Username Field Change
2013-12-01 15:57 tuxmaster New Issue
2013-12-01 16:35 mvwieringen Assigned To => mvwieringen
2013-12-01 16:35 mvwieringen Status new => assigned
2013-12-01 16:38 mvwieringen Note Added: 0000735
2013-12-01 16:38 mvwieringen Severity major => minor
2013-12-01 16:40 mvwieringen Status assigned => feedback
2013-12-01 16:42 mvwieringen Note Added: 0000736
2014-01-02 13:14 mvwieringen Changeset attached => bareos master d45b3c75
2014-01-02 13:14 mvwieringen Note Added: 0000778
2014-01-02 13:14 mvwieringen Status feedback => resolved
2014-01-02 13:14 mvwieringen Resolution open => fixed
2014-05-16 17:25 mvwieringen adm Assigned To mvwieringen =>
2014-05-16 17:25 mvwieringen adm Status resolved => closed
2014-05-16 17:25 mvwieringen adm Fixed in Version => 14.2.0
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-14.2 7202a401
2015-03-25 16:51 mvwieringen Note Added: 0001480
2015-03-25 16:51 mvwieringen Status closed => resolved
2015-03-25 19:19 joergs Note Added: 0001630
2015-03-25 19:19 joergs Status resolved => closed