View Issue Details

IDProjectCategoryView StatusLast Update
0000240bareos-coreGeneralpublic2015-03-25 19:18
Reportertigerfoot Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Summary0000240: Cleanup systemd files
DescriptionMinors fixes to include:
- Remove Alias in bareos-dir.service (this is for .target file)
- Each service could benefit to direct link to its man page
- We certainly want to use Restart on-failure for any service
- Make bareos-dir on a more safe side by providing to systemd
  information about the fact we would like to start after database.
  This has to be safe (aka soft) if the database is a remote server.

Steps To ReproduceInstall any bareos version on a systemd powered platform
TagsNo tags attached.

Activities

tigerfoot

tigerfoot

2013-10-25 09:17

developer  

0001-Fixes-240-Improve-systemd-service-files.patch (3,191 bytes)   
From 0b8c667b66262cb74a02a393db89eb6925ffe670 Mon Sep 17 00:00:00 2001
From: Bruno Friedmann <bruno@ioda-net.ch>
Date: Fri, 25 Oct 2013 09:08:40 +0200
Subject: [PATCH] Fixes #240: Improve systemd service files

Added documentation lines for each service
Added Restart on-failure for each service
Remove Alias from -dir (only for .target unit)
Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up
---
 platforms/systemd/bareos-dir.service.in | 5 +++--
 platforms/systemd/bareos-fd.service.in  | 3 +++
 platforms/systemd/bareos-sd.service.in  | 2 ++
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/platforms/systemd/bareos-dir.service.in b/platforms/systemd/bareos-dir.service.in
index 8b9db74..fab5500 100644
--- a/platforms/systemd/bareos-dir.service.in
+++ b/platforms/systemd/bareos-dir.service.in
@@ -13,9 +13,9 @@
 #
 [Unit]
 Description=Bareos Director Daemon service
-Alias=bareos-dir
+Documentation=man:bareos-dir(8)
 Requires=nss-lookup.target network.target remote-fs.target time-sync.target
-After=nss-lookup.target network.target remote-fs.target time-sync.target
+After=nss-lookup.target network.target remote-fs.target time-sync.target postgresql.service mysql.service
 # Dependency about the database
 # We let administrators decide if they need it (if local db instance)
 # Wants=@DEFAULT_DB_TYPE@.service
@@ -35,6 +35,7 @@ StandardOutput=syslog
 ExecStart=@sbindir@/bareos-dir -c @sysconfdir@/bareos-dir.conf
 # This daemon should be able to reload the conf file
 #ExecReload=/sbin/killproc -p @piddir@/bareos-dir.pid -HUP @sbindir@/bareos-dir
+Restart=on-failure
 
 [Install]
 WantedBy=multi-user.target
diff --git a/platforms/systemd/bareos-fd.service.in b/platforms/systemd/bareos-fd.service.in
index 4626635..2d046ea 100644
--- a/platforms/systemd/bareos-fd.service.in
+++ b/platforms/systemd/bareos-fd.service.in
@@ -13,6 +13,7 @@
 #
 [Unit]
 Description=Bareos File Daemon service
+Documentation=man:bareos-fd(8)
 Requires=nss-lookup.target network.target remote-fs.target time-sync.target
 After=nss-lookup.target network.target remote-fs.target time-sync.target
 # Wants=
@@ -27,6 +28,8 @@ WorkingDirectory=@working_dir@
 PIDFile=@piddir@/bareos-fd.@fd_port@.pid
 StandardOutput=syslog
 ExecStart=@sbindir@/bareos-fd -c @sysconfdir@/bareos-fd.conf
+Restart=on-failure
+# IOSchedulingClass=idle
 
 [Install]
 WantedBy=multi-user.target
diff --git a/platforms/systemd/bareos-sd.service.in b/platforms/systemd/bareos-sd.service.in
index 85d09a8..740f6c7 100644
--- a/platforms/systemd/bareos-sd.service.in
+++ b/platforms/systemd/bareos-sd.service.in
@@ -13,6 +13,7 @@
 #
 [Unit]
 Description=Bareos Storage Daemon service
+Documentation=man:bareos-sd(8)
 Requires=nss-lookup.target network.target remote-fs.target time-sync.target
 After=nss-lookup.target network.target remote-fs.target time-sync.target
 # Wants=
@@ -28,6 +29,7 @@ PIDFile=@piddir@/bareos-sd.@sd_port@.pid
 # EnvironmentFile=-/etc/sysconfig/bareos-sd
 StandardOutput=syslog
 ExecStart=@sbindir@/bareos-sd -c @sysconfdir@/bareos-sd.conf
+Restart=on-failure
 
 [Install]
 WantedBy=multi-user.target
-- 
1.8.1.4

tigerfoot

tigerfoot

2013-10-25 09:18

developer   ~0000704

Patch fixing the issue done
pstorz

pstorz

2013-10-25 10:29

administrator   ~0000705

Hello Tigerfoot,

there is this comment in the bareos-fd.service.in file:
# IOSchedulingClass=idle
Do we need that or can it be removed?
tigerfoot

tigerfoot

2013-10-25 11:02

developer   ~0000706

The comment could be dropped, but I would let it. So administrator that want to override our default could easily copy the default to /etc/systemd/service and adjust the needed flag and options.

IOSchedulingClass would place the -fd to a lower priority if the system is busy with IO.

also -k on the exec line would normally place it as a RO capability.
tigerfoot

tigerfoot

2013-10-25 11:04

developer   ~0000707

Fix committed to bareos master branch with changesetid 1226.
tigerfoot

tigerfoot

2013-11-01 16:24

developer   ~0000716

Fix committed to bareos bareos-12.4 branch with changesetid 1298.
tigerfoot

tigerfoot

2013-11-01 16:24

developer   ~0000717

Fix committed to bareos bareos-13.2 branch with changesetid 1299.
mvwieringen

mvwieringen

2015-03-25 16:51

developer   ~0001358

Fix committed to bareos2015 bareos-14.2 branch with changesetid 5006.
joergs

joergs

2015-03-25 19:18

developer   ~0001512

Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again.
Sorry for the noise.

Related Changesets

bareos: master 005528d0

2013-10-25 09:08

tigerfoot

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

bareos: bareos-12.4 2478b277

2013-10-25 09:08

tigerfoot

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

bareos: bareos-13.2 a323d2c9

2013-10-25 09:08

tigerfoot

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

bareos2015: bareos-12.4 1ce29ae8

2013-10-25 11:08

tigerfoot


Committer: mvwieringen

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

bareos2015: bareos-13.2 7a7e4f32

2013-10-25 11:08

tigerfoot


Committer: mvwieringen

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

bareos2015: bareos-14.2 06e1154e

2013-10-25 11:08

tigerfoot


Committer: mvwieringen

Ported: N/A

Details Diff
Cleanup systemd files

- Added documentation lines for each service
- Added Restart on-failure for each service
- Remove Alias from -dir (only for .target unit)
- Added soft dependency for postgresql & mysql for bareos-dir in
After= line so systemd know we prefer to start once the db is up

Fixes 0000240: Improve systemd service files
Affected Issues
0000240
mod - platforms/systemd/bareos-dir.service.in Diff File
mod - platforms/systemd/bareos-fd.service.in Diff File
mod - platforms/systemd/bareos-sd.service.in Diff File

Issue History

Date Modified Username Field Change
2013-10-24 09:02 tigerfoot New Issue
2013-10-24 09:13 mvwieringen adm Summary Revision for systemd plateform => Cleanup systemd files
2013-10-24 09:13 mvwieringen adm Description Updated
2013-10-24 09:13 mvwieringen adm Steps to Reproduce Updated
2013-10-24 09:14 mvwieringen adm Assigned To => tigerfoot
2013-10-24 09:14 mvwieringen adm Status new => assigned
2013-10-25 09:17 tigerfoot File Added: 0001-Fixes-240-Improve-systemd-service-files.patch
2013-10-25 09:18 tigerfoot Note Added: 0000704
2013-10-25 10:29 pstorz Note Added: 0000705
2013-10-25 11:02 tigerfoot Note Added: 0000706
2013-10-25 11:04 tigerfoot Changeset attached => bareos master 005528d0
2013-10-25 11:04 tigerfoot Note Added: 0000707
2013-10-25 11:04 tigerfoot Status assigned => resolved
2013-10-25 11:04 tigerfoot Resolution open => fixed
2013-11-01 16:24 tigerfoot Changeset attached => bareos bareos-12.4 2478b277
2013-11-01 16:24 tigerfoot Note Added: 0000716
2013-11-01 16:24 tigerfoot Changeset attached => bareos bareos-13.2 a323d2c9
2013-11-01 16:24 tigerfoot Note Added: 0000717
2013-11-01 17:44 mvwieringen Status resolved => closed
2013-11-01 17:44 mvwieringen Assigned To tigerfoot =>
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-12.4 1ce29ae8
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-13.2 7a7e4f32
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-14.2 06e1154e
2015-03-25 16:51 mvwieringen Note Added: 0001358
2015-03-25 16:51 mvwieringen Status closed => resolved
2015-03-25 19:18 joergs Note Added: 0001512
2015-03-25 19:18 joergs Status resolved => closed