View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000218 | bareos-core | General | public | 2013-08-20 10:38 | 2014-05-16 17:28 |
Reporter | dpkg | Assigned To | |||
Priority | normal | Severity | minor | Reproducibility | always |
Status | closed | Resolution | fixed | ||
Platform | Linux amd64 | OS | Debian | OS Version | 7 |
Product Version | 12.4.4 | ||||
Fixed in Version | 12.4.5 | ||||
Summary | 0000218: LSB conformity of init scripts | ||||
Description | To whom it may concern, the init scripts are not LSB conform, i.e. not usable for failover setups with heartbeat/pacemaker/corosync etc. Thanks for all the work Jan | ||||
Steps To Reproduce | root@vwshare:~# service bareos-fd status Usage: /etc/init.d/bareos-fd {start|stop|restart|force-reload} root@vwshare:~# ps aux | grep bareos root 14346 0.0 0.4 60540 1080 ? Ssl 10:16 0:00 /usr/sbin/bareos-fd -c /etc/bareos/bareos-fd.conf root 16251 0.0 0.3 7828 872 pts/2 S+ 10:33 0:00 grep bareos root@vwshare:~# service bareos-fd start Starting Bareos File Daemon: bareos-fd root@vwshare:~# echo $? 1 | ||||
Additional Information | For more detail see this: http://refspecs.linuxfoundation.org/LSB_3.1.0/LSB-Core-generic/LSB-Core-generic/iniscrptact.html | ||||
Tags | No tags attached. | ||||
related to | 0000109 | closed | init scripts causes a lot of problems. Replace existing init scripts with distribution templates. |
lsb-patch (1,291 bytes)
*** bareos-fd 2013-06-11 19:46:40.000000000 +0200 --- bareos-fd-new 2013-08-20 10:43:01.035737263 +0200 *************** *** 35,40 **** --- 35,42 ---- BPORT=`getent services ${NAME} | awk '{ gsub("/tcp","",$2); print $2; }'` fi + . /lib/lsb/init-functions + if [ -f /etc/default/$NAME ]; then . /etc/default/$NAME fi *************** *** 51,57 **** case "$1" in start) echo -n "Starting ${DESC}: " ! start-stop-daemon --start --quiet --pidfile ${PIDFILE} ${USERGRP} --exec ${DAEMON} -- ${BOPTIONS} RETVAL=$? echo "${NAME}" ;; --- 53,59 ---- case "$1" in start) echo -n "Starting ${DESC}: " ! start-stop-daemon --start --oknodo --quiet --pidfile ${PIDFILE} ${USERGRP} --exec ${DAEMON} -- ${BOPTIONS} RETVAL=$? echo "${NAME}" ;; *************** *** 66,73 **** sleep 5 $0 start ;; *) ! echo "Usage: /etc/init.d/${NAME} {start|stop|restart|force-reload}" >&2 exit 1 ;; esac --- 68,78 ---- sleep 5 $0 start ;; + status) + status_of_proc -p $PIDFILE $DAEMON $NAME + ;; *) ! echo "Usage: /etc/init.d/${NAME} {start|stop|restart|force-reload|status}" >&2 exit 1 ;; esac |
|
Seems to be Debian specific? i.e. not reproduceable on Suse: --- theseus:~ # service bareos-fd status Checking for Bareos file daemon running theseus:~ # service bareos-fd start Starting the Bareos File daemon: done theseus:~ # echo $? 0 theseus:~ # rpm -q bareos-filedaemon bareos-filedaemon-13.2.0-2.1.x86_64 -- |
|
Reproduced with 12.4.4, not reproduceable with 13.2. --- 12.4.4 --- root@ci-Debian-6-0-64-53f65c85e7bf3789:/etc/apt/sources.list.d# ps auxww | grep bareos root 2678 0.0 0.4 61532 1244 ? Ssl 15:39 0:00 /usr/sbin/bareos-fd -c /etc/bareos/bareos-fd.conf root 2693 0.0 0.3 7548 824 pts/1 S+ 15:40 0:00 grep bareos root@ci-Debian-6-0-64-53f65c85e7bf3789:/etc/apt/sources.list.d# service bareos-fd start Starting Bareos File Daemon: bareos-fd root@ci-Debian-6-0-64-53f65c85e7bf3789:/etc/apt/sources.list.d# echo $? 1 ii bareos-filedaemon 12.4.4-679.1 Backup Archiving Recovery Open Sourced - file daemon Could not reproduce on Debian 6 with Bareos 13.2. (seemed to be fixed with 13.2): --- 13.2 --- root@ci-Debian-6-0-64-53f65c85e7bf3789:~# ps auxww | grep bareos-fd root 2282 0.0 0.4 63624 1248 ? Ssl 15:32 0:00 /usr/sbin/bareos-fd root 2323 0.0 0.3 7548 824 pts/1 S+ 15:32 0:00 grep bareos-fd root@ci-Debian-6-0-64-53f65c85e7bf3789:~# service bareos-fd status bareos-fd is running. root@ci-Debian-6-0-64-53f65c85e7bf3789:~# service bareos-fd start root@ci-Debian-6-0-64-53f65c85e7bf3789:~# echo $? 0 --- |
|
yes, it has been fixed by https://github.com/bareos/bareos/commit/e82b5edf2235817121624d8c1eb2cf528b61cfd8#platforms/debian for Branch-13.2 a while ago. Because this changes the baehavior of the init scripts, we decided to not backport it to 12.4. |
|
After some internal discussion we decided to backport the fix that is in 13.2 to 12.4.5. |
|
bareos: bareos-12.4 2a6523a9 2013-05-04 21:11 Committer: mvwieringen Ported: N/A Details Diff |
initscripts: use debian 6.0 skeleton recreate Debian and Ubuntu init scripts based on Debian/Ubuntu skeleton file. Advantages: - use standard skeleton - "status" is now implemented and working, see bug 0000050 - start order: if a database is installed, it is started before the bareos-director - Debian and Ubuntu are using the same init scripts - bareos-dir, bareos-sd and bareos-fd are based on the same skeleton and differ only at the variables values Changed: - Debian standard skeleton utilise the VERBOSE variable. By default, VERBOSE equals "no" and init script are completly quiet. We follow this standard, even so we don't like it. This behavior can be changed by setting "VERBOSE=yes" in /etc/defaults/rcS Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com> |
Affected Issues 0000050, 0000218 |
|
mod - debian/control | Diff File | ||
mod - platforms/debian/bareos-dir.in | Diff File | ||
mod - platforms/debian/bareos-fd.in | Diff File | ||
mod - platforms/debian/bareos-sd.in | Diff File | ||
rm - platforms/ubuntu/bareos-dir.in | Diff File | ||
add - platforms/ubuntu/bareos-dir.in | Diff File | ||
rm - platforms/ubuntu/bareos-fd.in | Diff File | ||
add - platforms/ubuntu/bareos-fd.in | Diff File | ||
rm - platforms/ubuntu/bareos-sd.in | Diff File | ||
add - platforms/ubuntu/bareos-sd.in | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2013-08-20 10:38 | dpkg | New Issue | |
2013-08-20 10:44 | dpkg | File Added: lsb-patch | |
2013-08-20 11:27 | mvwieringen | Relationship added | related to 0000109 |
2013-08-20 15:27 | maik | Note Added: 0000636 | |
2013-08-20 15:42 | maik | Note Added: 0000637 | |
2013-08-21 13:24 | joergs | Note Added: 0000641 | |
2013-08-21 13:24 | joergs | Assigned To | => joergs |
2013-08-21 13:24 | joergs | Status | new => acknowledged |
2013-09-06 19:16 | mvwieringen | Changeset attached | => bareos bareos-12.4 2a6523a9 |
2013-09-06 19:18 | mvwieringen | Note Added: 0000661 | |
2013-09-06 19:18 | mvwieringen | Assigned To | joergs => |
2013-09-06 19:18 | mvwieringen | Status | acknowledged => resolved |
2013-09-06 19:18 | mvwieringen | Fixed in Version | => 12.4.5 |
2014-05-16 17:28 | joergs | Status | resolved => closed |
2014-05-16 17:28 | joergs | Resolution | open => fixed |