0000207: Implement plugin options passing.

ID	Project	Category	View Status	Date Submitted	Last Update

0000207	bareos-core	General	public	2013-07-15 10:26	2015-03-25 19:19

Reporter	mvwieringen	Assigned To
Priority	normal	Severity	feature	Reproducibility	N/A
Status	closed	Resolution	fixed
Platform	OpenIndiana	OS	OpenIndiana	OS Version	b151a
Product Version	13.2.1
Fixed in Version	13.2.2

Summary	0000207: Implement plugin options passing.
Description	Implement a new feature to pass plugin option as part of the restore process. Most of the plugin options input was already implemented but for the restore the options were never pushed to the file daemon. We should pass it to the filed and raise a bEventPluginCommand event. This way a user can pass in extra hints to the plugin for the restore process. Currently the plugin only gets passed in the plugin options that were defined at the moment the backup was made.
Additional Information	The options defined by the user at restore time are passed before the actual options saved at backup time are passed so the plugin should take care to ignore any of the options passed in as part of the backup stream being restored.
Tags	No tags attached.

~~mvwieringen adm~~ 2013-08-13 03:12 administrator ~0000575	Fix committed to bareos master branch with changesetid 605.

mvwieringen 2013-10-06 12:04 developer ~0000689	Fix committed to bareos bareos-13.2 branch with changesetid 1184.

mvwieringen 2015-03-25 16:51 developer ~0001417	Fix committed to bareos2015 bareos-14.2 branch with changesetid 5093.

joergs 2015-03-25 19:19 developer ~0001569	Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again. Sorry for the noise.

bareos: master 73e72117 2013-07-13 17:29 ~~mvwieringen adm~~ Ported: N/A Details Diff	Implement plugin options passing. Implement a new feature to pass plugin option as part of the restore process. Most of the plugin options input was already implemented but for the restore the options were never pushed to the file daemon. We should pass it to the filed and raise a bEventPluginCommand event. This way a user can pass in extra hints to the plugin for the restore process. Currently the plugin only gets passed in the plugin options that were defined at the moment the backup was made. The options defined by the user at restore time are passed before the actual options saved at backup time are passed so the plugin should take care to ignore any of the options passed in as part of the backup stream being restored when it already got a override at restore time. We increased the FD protocol number to 52 to be able to detect if the file daemon understand the new protocol keyword. Along the way we tweaked the layout of fileset traversal code somewhat. Added some spaces and fixed the scoping of the variables somewhat. So you understand what is going on. And fixed the comments in the filed plugin code. Fixes 0000207: Implement plugin options passing.	Affected Issues 0000207
	mod - src/filed/fd_plugins.c	Diff File
	mod - src/filed/dir_cmd.c	Diff File
	mod - src/filed/authenticate.c	Diff File
	mod - src/dird/ua_run.c	Diff File
	mod - src/dird/restore.c	Diff File
	mod - src/dird/protos.h	Diff File
	mod - src/dird/fd_cmds.c	Diff File
	mod - src/dird/dird.h	Diff File
bareos: bareos-13.2 7e8e3983 2013-07-13 17:29 mvwieringen Ported: N/A Details Diff	Implement plugin options passing. Implement a new feature to pass plugin option as part of the restore process. Most of the plugin options input was already implemented but for the restore the options were never pushed to the file daemon. We should pass it to the filed and raise a bEventPluginCommand event. This way a user can pass in extra hints to the plugin for the restore process. Currently the plugin only gets passed in the plugin options that were defined at the moment the backup was made. The options defined by the user at restore time are passed before the actual options saved at backup time are passed so the plugin should take care to ignore any of the options passed in as part of the backup stream being restored when it already got a override at restore time. We increased the FD protocol number to 52 to be able to detect if the file daemon understand the new protocol keyword. Along the way we tweaked the layout of fileset traversal code somewhat. Added some spaces and fixed the scoping of the variables somewhat. So you understand what is going on. And fixed the comments in the filed plugin code. Fixes 0000207: Implement plugin options passing.	Affected Issues 0000207
	mod - src/dird/dird.h	Diff File
	mod - src/dird/fd_cmds.c	Diff File
	mod - src/dird/protos.h	Diff File
	mod - src/dird/restore.c	Diff File
	mod - src/dird/ua_run.c	Diff File
	mod - src/filed/authenticate.c	Diff File
	mod - src/filed/dir_cmd.c	Diff File
	mod - src/filed/fd_plugins.c	Diff File
bareos2015: bareos-13.2 7c1006b2 2013-07-13 19:29 mvwieringen Ported: N/A Details Diff	Implement plugin options passing. Implement a new feature to pass plugin option as part of the restore process. Most of the plugin options input was already implemented but for the restore the options were never pushed to the file daemon. We should pass it to the filed and raise a bEventPluginCommand event. This way a user can pass in extra hints to the plugin for the restore process. Currently the plugin only gets passed in the plugin options that were defined at the moment the backup was made. The options defined by the user at restore time are passed before the actual options saved at backup time are passed so the plugin should take care to ignore any of the options passed in as part of the backup stream being restored when it already got a override at restore time. We increased the FD protocol number to 52 to be able to detect if the file daemon understand the new protocol keyword. Along the way we tweaked the layout of fileset traversal code somewhat. Added some spaces and fixed the scoping of the variables somewhat. So you understand what is going on. And fixed the comments in the filed plugin code. Fixes 0000207: Implement plugin options passing.	Affected Issues 0000207
	mod - src/dird/dird.h	Diff File
	mod - src/dird/fd_cmds.c	Diff File
	mod - src/dird/protos.h	Diff File
	mod - src/dird/restore.c	Diff File
	mod - src/dird/ua_run.c	Diff File
	mod - src/filed/authenticate.c	Diff File
	mod - src/filed/dir_cmd.c	Diff File
	mod - src/filed/fd_plugins.c	Diff File
bareos2015: bareos-14.2 301e17b1 2013-07-13 19:29 mvwieringen Ported: N/A Details Diff	Implement plugin options passing. Implement a new feature to pass plugin option as part of the restore process. Most of the plugin options input was already implemented but for the restore the options were never pushed to the file daemon. We should pass it to the filed and raise a bEventPluginCommand event. This way a user can pass in extra hints to the plugin for the restore process. Currently the plugin only gets passed in the plugin options that were defined at the moment the backup was made. The options defined by the user at restore time are passed before the actual options saved at backup time are passed so the plugin should take care to ignore any of the options passed in as part of the backup stream being restored when it already got a override at restore time. We increased the FD protocol number to 52 to be able to detect if the file daemon understand the new protocol keyword. Along the way we tweaked the layout of fileset traversal code somewhat. Added some spaces and fixed the scoping of the variables somewhat. So you understand what is going on. And fixed the comments in the filed plugin code. Fixes 0000207: Implement plugin options passing.	Affected Issues 0000207
	mod - src/dird/dird.h	Diff File
	mod - src/dird/fd_cmds.c	Diff File
	mod - src/dird/protos.h	Diff File
	mod - src/dird/restore.c	Diff File
	mod - src/dird/ua_run.c	Diff File
	mod - src/filed/authenticate.c	Diff File
	mod - src/filed/dir_cmd.c	Diff File
	mod - src/filed/fd_plugins.c	Diff File

Date Modified	Username	Field	Change
2013-07-15 10:26	mvwieringen	New Issue
2013-07-15 10:26	mvwieringen	Status	new => assigned
2013-07-15 10:26	mvwieringen	Assigned To	=> mvwieringen
2013-07-15 17:24	mvwieringen	Changeset attached	=> bareos master a68e3b98
2013-07-15 17:24	mvwieringen	Status	assigned => resolved
2013-07-15 17:24	mvwieringen	Resolution	open => fixed
2013-08-13 03:12	~~mvwieringen adm~~	Changeset attached	=> bareos master 73e72117
2013-08-13 03:12	~~mvwieringen adm~~	Note Added: 0000575
2013-08-13 03:12	~~mvwieringen adm~~	Assigned To	mvwieringen => mvwieringen adm
2013-10-06 12:04	mvwieringen	Changeset attached	=> bareos bareos-13.2 7e8e3983
2013-10-06 12:04	mvwieringen	Note Added: 0000689
2013-10-06 12:04	mvwieringen	Assigned To	mvwieringen adm => mvwieringen
2014-05-16 17:41	~~mvwieringen adm~~	Assigned To	mvwieringen =>
2014-05-16 17:41	~~mvwieringen adm~~	Status	resolved => closed
2014-05-16 17:41	~~mvwieringen adm~~	Product Version	13.3.0 => 13.2.1
2014-05-16 17:41	~~mvwieringen adm~~	Fixed in Version	=> 13.2.2
2015-03-25 16:51	mvwieringen	Changeset attached	=> bareos2015 bareos-13.2 7c1006b2
2015-03-25 16:51	mvwieringen	Changeset attached	=> bareos2015 bareos-14.2 301e17b1
2015-03-25 16:51	mvwieringen	Note Added: 0001417
2015-03-25 16:51	mvwieringen	Status	closed => resolved
2015-03-25 19:19	joergs	Note Added: 0001569
2015-03-25 19:19	joergs	Status	resolved => closed

Reporting new Issues is disabled, please Report new Issues at https://github.com/bareos/bareos/issues

View Issue Details

Activities

Related Changesets

Issue History