View Issue Details

IDProjectCategoryView StatusLast Update
0000195bareos-coredirectorpublic2015-03-25 19:19
Reportermvwieringen Assigned To 
PrioritynormalSeverityfeatureReproducibilityN/A
Status closedResolutionfixed 
PlatformOpenIndianaOSOpenIndianaOS Versionb151a
Product Version12.4.4 
Summary0000195: Interactive path selection can use refactoring
DescriptionThe code in the director which is used to select interactively the files
to restore needs some cleanup. Currently the cwd (current working directory)
is stored in a fixed length buffer of sometimes 1100 and sometimes 2000 bytes.
It would be better to use a POOLMEM buffer which can extend to the actual length
needed.
Additional InformationCurrently you can also not directly mark or unmark a full path as the mark
and unmark only matches the name using fnmatch against the current working
directory. This also skips any path information and as the internal storage
of the tree is per directory node this will never work. A simple fix would
be to check if the selection pattern is a full path (e.g. has a / in it)
and then split the selection in a path and file part. Then we can do a
change directory into the wanted path and then do the same pattern matching
and restore the working directory after the selection.
TagsNo tags attached.

Activities

mvwieringen adm

mvwieringen adm

2013-08-13 03:12

administrator   ~0000581

Fix committed to bareos master branch with changesetid 629.
mvwieringen

mvwieringen

2015-03-25 16:51

developer   ~0001494

Fix committed to bareos2015 bareos-14.2 branch with changesetid 5117.
joergs

joergs

2015-03-25 19:19

developer   ~0001642

Due to the reimport of the Github repository to bugs.bareos.org, the status of some tickets have been changed. These tickets will be closed again.
Sorry for the noise.

Related Changesets

bareos: master 0b5e0243

2013-06-24 16:56

mvwieringen adm

Ported: N/A

Details Diff
Interactive path selection can use refactoring

The code in the director which is used to select interactively the files
to restore needs some cleanup. Currently the cwd (current working
directory) is stored in a fixed length buffer of sometimes 1100 and
sometimes 2000 bytes. It would be better to use a POOLMEM buffer
which can extend to the actual length needed.

Currently you can also not directly mark or unmark a full path as the mark
and unmark only matches the name using fnmatch against the current working
directory. This also skips any path information and as the internal storage
of the tree is per directory node this will never work. A simple fix would
be to check if the selection pattern is a full path (e.g. has a / in it)
and then split the selection in a path and file part. Then we can do a
change directory into the wanted path and then do the same pattern matching
and restore the working directory after the selection.

Fixes 0000195: Interactive path selection can use refactoring
Affected Issues
0000195
mod - src/lib/tree.h Diff File
mod - src/lib/tree.c Diff File
mod - src/dird/ua_tree.c Diff File

bareos2015: bareos-14.2 a09b672a

2013-06-24 18:56

mvwieringen

Ported: N/A

Details Diff
Interactive path selection can use refactoring

The code in the director which is used to select interactively the files
to restore needs some cleanup. Currently the cwd (current working
directory) is stored in a fixed length buffer of sometimes 1100 and
sometimes 2000 bytes. It would be better to use a POOLMEM buffer
which can extend to the actual length needed.

Currently you can also not directly mark or unmark a full path as the mark
and unmark only matches the name using fnmatch against the current working
directory. This also skips any path information and as the internal storage
of the tree is per directory node this will never work. A simple fix would
be to check if the selection pattern is a full path (e.g. has a / in it)
and then split the selection in a path and file part. Then we can do a
change directory into the wanted path and then do the same pattern matching
and restore the working directory after the selection.

Fixes 0000195: Interactive path selection can use refactoring
Affected Issues
0000195
mod - src/dird/ua_tree.c Diff File
mod - src/lib/tree.c Diff File
mod - src/lib/tree.h Diff File

Issue History

Date Modified Username Field Change
2013-06-24 16:55 mvwieringen New Issue
2013-06-24 16:55 mvwieringen Status new => assigned
2013-06-24 16:55 mvwieringen Assigned To => mvwieringen
2013-06-24 17:02 mvwieringen Additional Information Updated
2013-06-24 19:59 mvwieringen Changeset attached => bareos master a9fd5cdc
2013-06-24 19:59 mvwieringen Status assigned => resolved
2013-06-24 19:59 mvwieringen Resolution open => fixed
2013-08-13 03:12 mvwieringen adm Changeset attached => bareos master 0b5e0243
2013-08-13 03:12 mvwieringen adm Note Added: 0000581
2013-08-13 03:12 mvwieringen adm Assigned To mvwieringen => mvwieringen adm
2013-09-06 13:05 mvwieringen Status resolved => closed
2013-09-06 13:05 mvwieringen Assigned To mvwieringen adm =>
2015-03-25 16:51 mvwieringen Changeset attached => bareos2015 bareos-14.2 a09b672a
2015-03-25 16:51 mvwieringen Note Added: 0001494
2015-03-25 16:51 mvwieringen Status closed => resolved
2015-03-25 19:19 joergs Note Added: 0001642
2015-03-25 19:19 joergs Status resolved => closed