View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001586bareos-corefile daemonpublic2023-12-20 13:492024-01-18 10:34
Reporterhostedpower Assigned Tojoergs  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionreopened 
PlatformLinuxOSDebianOS Version12
Product Version22.1.3 
Summary0001586: Cannot use any of the "bareos_tasks" plugins
DescriptionHi,


We tried to use for example bareos_tasks.pgsql, We have setup this fileset as found in this documentation: https://github.com/bareos/bareos/tree/f2139f06cb09f61d582fd97f00c7d0fa2d429757/contrib/fd-plugins/bareos_tasks/pgsql

FileSet {
    Name = "postgresql-test"
    Include {
        Options {
            signature = SHA1
            compression = GZIP3
        }
        # Backup postgresql
        Plugin = "python:module_path=/usr/lib/bareos/plugins:module_name=bareos_tasks.pgsql"
    }
    IgnoreFileSetChanges = yes
}

But we first got errors:

Fatal error: bareosfd: Traceback (most recent call last):
File "/usr/lib/bareos/plugins/bareos_tasks/pgsql/__init__.py", line 21, in
from BareosFdPgSQLClass import BareosFdPgSQLClass
ModuleNotFoundError: No module named 'BareosFdPgSQLClass'

Very strange the classes cannot be found? However then we symlinked as following:

cd usr/lib/bareos/plugins
ln -s bareos_tasks/pgsql/BareosFdPgSQLClass.py .
bareos_tasks/BareosFdTaskClass.py .

Now the classes are "magically" found :)

However we run into new errors:

JobId 210052: Fatal error: bareosfd: Traceback (most recent call last):
File "/usr/lib/bareos/plugins/BareosFdWrapper.py", line 57, in handle_plugin_event
return bareos_fd_plugin_object.handle_plugin_event(event)
AttributeError: 'BareosFdPgSQLClass' object has no attribute 'handle_plugin_event'

Why would it need handle_plugin_event ? And where?

Are these plugins tested or what are we missing here? Thx a lot for checking this out!
TagsNo tags attached.

Activities

bruno-at-bareos

bruno-at-bareos

2023-12-20 15:01

manager   ~0005654

As said in the repository README

External contributions of unsupported code and scripts.

So we won't do anything on our own without motivation ;-)
hostedpower

hostedpower

2023-12-20 17:30

reporter   ~0005655

Hi, I'm working to fix it, I already have some copy that works at the moment. What is the easiest way to contribute this back?
bruno-at-bareos

bruno-at-bareos

2023-12-20 20:13

manager   ~0005657

The best way, is to propose a PR (pull request) on github.
So the code is reviewed, build and (not tested as certainly missing a system test) but I can ask tomorrow if there's any interest in.
hostedpower

hostedpower

2023-12-21 08:51

reporter   ~0005658

OK great, the pull request was made. We're taking the plugin in use atm.

I also see something interesting here https://github.com/marcolertora/bareos-tasks-plugins/issues/1

I suppose Joerg will know more about all this :)
bruno-at-bareos

bruno-at-bareos

2024-01-18 10:34

manager   ~0005699

Has been merge in master and 23.0.1

Issue History

Date Modified Username Field Change
2023-12-20 13:49 hostedpower New Issue
2023-12-20 15:01 bruno-at-bareos Assigned To => bruno-at-bareos
2023-12-20 15:01 bruno-at-bareos Status new => closed
2023-12-20 15:01 bruno-at-bareos Resolution open => won't fix
2023-12-20 15:01 bruno-at-bareos Note Added: 0005654
2023-12-20 17:30 hostedpower Status closed => new
2023-12-20 17:30 hostedpower Resolution won't fix => reopened
2023-12-20 17:30 hostedpower Note Added: 0005655
2023-12-20 20:13 bruno-at-bareos Note Added: 0005657
2023-12-21 08:51 hostedpower Note Added: 0005658
2023-12-21 09:55 bruno-at-bareos Assigned To bruno-at-bareos => joergs
2024-01-18 10:34 bruno-at-bareos Status new => closed
2024-01-18 10:34 bruno-at-bareos Note Added: 0005699