View Issue Details

IDProjectCategoryView StatusLast Update
0001257bareos-core[All Projects] directorpublic2020-06-29 13:22
ReporteraroggeAssigned Toarogge 
PrioritynormalSeveritycrashReproducibilityalways
Status resolvedResolutionfixed 
Product Version19.2.7 
Fixed in Version 
Summary0001257: Prune volume command may crash the director
DescriptionWhen pruning a volume the director now logs with more detail. One of the messages contains a weird volume name (i.e. »JobId 0: Volume "`4��" contains no jobs after pruning.«

Sometimes the director even crashes when emitting that message.
Steps To Reproduce1. install 19.2.7
2. run a job to fill a volume
3. wait for volume retention to pass
4. prune the volume
TagsNo tags attached.
bareos-master: impact
bareos-master: action
bareos-19.2: impact
bareos-19.2: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Activities

arogge

arogge

2020-06-29 12:22

developer   ~0004013

Fix committed to bareos master branch with changesetid 13492.
arogge

arogge

2020-06-29 13:22

developer   ~0004014

Fix committed to bareos bareos-19.2 branch with changesetid 13494.

Related Changesets

bareos: master 3964c95b

2020-06-25 13:14:24

arogge

Ported: N/A

Details Diff
systemtests: improve volume-prune test

Issue 0001257: Prune volume command may crash the director

The test now also runs manual pruning and checks that the job-message
emitted contains the correct volume name.
Affected Issues
0001257
mod - systemtests/tests/volume-pruning/testrunner Diff File

bareos: bareos-19.2 0534c113

2020-06-25 13:14:24

arogge

Ported: N/A

Details Diff
systemtests: improve volume-prune test

Issue 0001257: Prune volume command may crash the director

The test now also runs manual pruning and checks that the job-message
emitted contains the correct volume name.

(cherry picked from commit 3964c95bb03300f9177438e1cb16ebec1133c771)
Affected Issues
0001257
mod - systemtests/tests/volume-pruning-test/testrunner Diff File

bareos: master 664cd2e6

2020-06-25 13:17:18

arogge

Ported: N/A

Details Diff
dir: add missing string to Jmsg() in ua_prune.cc

Fixes 0001257: Prune volume command may crash the director

Previously the mr->VolumeName to fill the %s in the Jmsg was missing.
Affected Issues
0001257
mod - core/src/dird/ua_prune.cc Diff File

bareos: bareos-19.2 4dec4a23

2020-06-25 13:17:18

arogge

Ported: N/A

Details Diff
dir: add missing string to Jmsg() in ua_prune.cc

Fixes 0001257: Prune volume command may crash the director

Previously the mr->VolumeName to fill the %s in the Jmsg was missing.

(cherry picked from commit 664cd2e67c777c3873abd3d581309c3c00a14c62)
Affected Issues
0001257
mod - core/src/dird/ua_prune.cc Diff File

bareos: master 94a0525e

2020-06-29 12:09:28

arogge


Committer: GitHub

Ported: N/A

Details Diff
Merge pull request 0000546 from arogge/dev/arogge/master/fix-1257

Fix 0001257: Prune volume command may crash the director
Affected Issues
0001257
mod - core/src/dird/ua_prune.cc Diff File
mod - systemtests/tests/volume-pruning/testrunner Diff File

Issue History

Date Modified Username Field Change
2020-06-25 13:14 arogge New Issue
2020-06-25 13:14 arogge Status new => assigned
2020-06-25 13:14 arogge Assigned To => arogge
2020-06-29 12:22 arogge Changeset attached => bareos master 94a0525e
2020-06-29 12:22 arogge Changeset attached => bareos master 664cd2e6
2020-06-29 12:22 arogge Changeset attached => bareos master 3964c95b
2020-06-29 12:22 arogge Note Added: 0004013
2020-06-29 12:22 arogge Status assigned => resolved
2020-06-29 12:22 arogge Resolution open => fixed
2020-06-29 13:22 arogge Changeset attached => bareos bareos-19.2 4dec4a23
2020-06-29 13:22 arogge Changeset attached => bareos bareos-19.2 0534c113
2020-06-29 13:22 arogge Note Added: 0004014