View Issue Details

IDProjectCategoryView StatusLast Update
0001190bareos-core[All Projects] directorpublic2020-04-16 19:28
ReporteraroggeAssigned Tofranku 
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version19.2.6 
Fixed in Version 
Summary0001190: Schedules without a client will not be run
DescriptionWhen you configure a job without a client (only possible on some types like copy and migrate) the job will not be scheduled.
Steps To Reproduce1. Configure a joblike this:
Job {
  Name = "backup-bareos-fd"
  Type = Copy
  Messages = "Standard"
  Pool = "Full"
  Schedule = "MySchedule"
  SelectionType = PoolUncopiedJobs
}

The job will not be scheduled even though other jobs referencing MySchedule will be scheduled.
I would expect the job to be scheduled.
Additional InformationThis happens since an upgrade to 19.2.5.
TagsNo tags attached.
bareos-master: impactyes
bareos-master: actionfixed
bareos-19.2: impactyes
bareos-19.2: actionfixed
bareos-18.2: impactno
bareos-18.2: action
bareos-17.2: impactno
bareos-17.2: action
bareos-16.2: impactno
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Relationships

related to 0001187 closedarogge_adm Release Bareos 19.2.7 

Activities

arogge

arogge

2020-02-12 11:36

developer   ~0003800

Tested and confirmed.
normic

normic

2020-02-16 02:17

reporter   ~0003816

I'm not sure if this is really happening only with 19.5 or is a bug at all.
I had the same issue with an 18.2.5 installation. But after investigating this further I noticed that the exact behavior occurs if the Schedule is _not_ referenced by a Job.

I did not recheck this with 19.x
arogge

arogge

2020-02-20 14:03

developer   ~0003848

Brock Palen from the mailing list confirmed that the issue only occurs when no client is configured on a job.
franku

franku

2020-02-25 12:22

administrator   ~0003852

Fix committed to bareos master branch with changesetid 12909.
franku

franku

2020-02-26 12:22

administrator   ~0003860

Fix committed to bareos bareos-19.2 branch with changesetid 12911.

Related Changesets

bareos: master d0c9765e

2020-02-22 12:37:28

franku

Ported: N/A

Details Diff
scheduler: run jobs without client (copy/migrate)

Fixes 0001190: Schedules without a client will not be run

A misplaced pointer guard prevents copy or migrate jobs
to be run by the scheduler.

This commit fixes the bug and adds another unittest that
tests if a scheduled copy job runs, hence without client.
Affected Issues
0001190
mod - core/src/dird/scheduler_private.cc Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/catalog/MyCatalog.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/client/bareos-fd.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/console/bareos-mon.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/director/bareos-dir.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/Catalog.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/LinuxAll.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/SelfTest.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/Windows All Drives.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/job/backup-bareos-fd.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/jobdefs/DefaultJob.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/messages/Daemon.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/messages/Standard.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Differential.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Full.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Incremental.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Scratch.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/profile/operator.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/schedule/schedule.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/storage/File.conf Diff File
mod - core/src/tests/scheduler.cc Diff File

bareos: bareos-19.2 145c8731

2020-02-22 12:37:28

franku


Committer: arogge

Ported: N/A

Details Diff
scheduler: run jobs without client (copy/migrate)

Fixes 0001190: Schedules without a client will not be run

A misplaced pointer guard prevents copy or migrate jobs
to be run by the scheduler.

This commit fixes the bug and adds another unittest that
tests if a scheduled copy job runs, hence without client.

(cherry picked from commit d0c9765eeb3be722134bb1b5051d8a2f0dfb44c3)
Affected Issues
0001190
mod - core/src/dird/scheduler_private.cc Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/catalog/MyCatalog.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/client/bareos-fd.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/console/bareos-mon.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/director/bareos-dir.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/Catalog.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/LinuxAll.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/SelfTest.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/fileset/Windows All Drives.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/job/backup-bareos-fd.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/jobdefs/DefaultJob.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/messages/Daemon.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/messages/Standard.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Differential.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Full.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Incremental.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/pool/Scratch.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/profile/operator.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/schedule/schedule.conf Diff File
add - core/src/tests/configs/scheduler-on-time-noday-noclient/bareos-dir.d/storage/File.conf Diff File
mod - core/src/tests/scheduler.cc Diff File

Issue History

Date Modified Username Field Change
2020-02-12 11:36 arogge New Issue
2020-02-12 11:36 arogge Assigned To => arogge
2020-02-12 11:36 arogge Status new => confirmed
2020-02-12 11:36 arogge Note Added: 0003800
2020-02-16 02:17 normic Note Added: 0003816
2020-02-18 10:28 arogge Status confirmed => new
2020-02-18 10:28 arogge Summary Schedules without a day will not be run => Schedules without a client will not be run
2020-02-18 10:28 arogge Description Updated View Revisions
2020-02-18 10:28 arogge Steps to Reproduce Updated View Revisions
2020-02-20 14:03 arogge Note Added: 0003848
2020-02-25 12:22 franku Changeset attached => bareos master d0c9765e
2020-02-25 12:22 franku Note Added: 0003852
2020-02-25 12:22 franku Assigned To arogge => franku
2020-02-25 12:22 franku Status new => resolved
2020-02-25 12:22 franku Resolution open => fixed
2020-02-25 12:48 arogge Assigned To franku => arogge
2020-02-25 12:48 arogge Status resolved => new
2020-02-25 12:48 arogge Resolution fixed => reopened
2020-02-25 12:48 arogge Status new => assigned
2020-02-25 12:49 arogge Relationship added related to 0001187
2020-02-26 11:26 arogge bareos-master: impact => yes
2020-02-26 11:26 arogge bareos-master: action => fixed
2020-02-26 11:26 arogge bareos-19.2: impact => yes
2020-02-26 11:26 arogge bareos-19.2: action => fixed
2020-02-26 11:26 arogge bareos-18.2: impact => no
2020-02-26 11:26 arogge bareos-17.2: impact => no
2020-02-26 11:26 arogge bareos-16.2: impact => no
2020-02-26 12:22 arogge Changeset attached => bareos bareos-19.2 145c8731
2020-02-26 12:22 franku Note Added: 0003860
2020-02-26 12:22 franku Assigned To arogge => franku
2020-02-26 12:22 franku Status assigned => resolved
2020-02-26 12:22 franku Resolution reopened => fixed
2020-04-16 19:28 arogge Status resolved => closed