View Issue Details

IDProjectCategoryView StatusLast Update
0001129bareos-core[All Projects] Generalpublic2019-11-03 18:57
ReporterrjungAssigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status newResolutionopen 
PlatformSolaris10OSSolarisOS Version10
Product Version18.2.6 
Fixed in Version 
Summary0001129: OpenSSL and readline include path missing in cmake build
DescriptionActually version is 18.4.1, but that is missing in the mantis version dropdown.

The new cmake based compilation correctly detects non-system OpenSSl and readline, when run e.g. with flags

      -DOPENSSL_ROOT_DIR=/path/to/openssl
      -DReadline_ROOT_DIR=/path/to/readline

But the when running maake, it can't find the header files, because the respective include paths never get added.

As a workaround I was using the follwoing patch:

--- core/CMakeLists.txt Fri Sep 28 10:30:36 2018
+++ core/CMakeLists.txt Sun Nov 3 14:55:00 2019
@@ -435,6 +435,10 @@
    set(HAVE_TLS "1")
 ENDIF()

+IF( "${HAVE_OPENSSL}")
+include_directories(${OPENSSL_INCLUDE_DIR})
+ENDIF()
+
 IF(NOT openssl)
    unset(HAVE_OPENSSL)
    unset(HAVE_TLS)
@@ -446,6 +450,7 @@
 set(got_readline "${READLINE_FOUND}" )
 if ("${READLINE_FOUND}")
    set(HAVE_READLINE 1)
+ include_directories(${Readline_INCLUDE_DIR})
 endif()

 if ("${PAM_FOUND}")

Steps To ReproduceRun cmake against a non-system OpenSSl and readline and make sure, the OpenSSl and readline header files are not installed in teh default system header file locations. The run make.
Tagscompile cmake headers openssl readline
bareos-master: impact
bareos-master: action
bareos-19.2: impact
bareos-19.2: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2019-11-03 18:57 rjung New Issue
2019-11-03 18:57 rjung Tag Attached: compile cmake headers openssl readline