View Issue Details

IDProjectCategoryView StatusLast Update
0001106bareos-core[All Projects] directorpublic2019-08-01 18:08
Reporterb.braunger@syseleven.deAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
PlatformLinuxOSUbuntuOS Version16.04
Product Version18.2.6 
Target VersionFixed in Version 
Summary0001106: Director's not sending Plugin Options to FileDaemon
DescriptionI want to use a fileset with a python command plugin for multiple jobs and give extra key value pairs to the plug via the "FD Plugin Options" parameter.
As far as I understand the docs I can add options to the "FD Plugin Options" in the job resource which then will be passed to the Plugin additionally to the Options set in the fileset.

Sadly nothing but the Options String from the fileset is sent to the FD Plugin no matter what I define. This extends to the Plugin Options which are set via bconsole they're all ignored.
Steps To ReproduceFileSet {
  Name = "testing"
  Include {
    Plugin = "python:module_path=/usr/lib64/bareos/plugins:module_name=test_plugin:from=fileset"
  }
}
Job {
  Name = backup-bareos-test
  FileSet = testing
  FD Plugin Options = "python:from=job"
}

* run job=backup-bareos-test pluginoptions="from=bconsole" yes
Additional InformationDoc: https://docs.bareos.org/Configuration/Director.html#config-Dir_Job_FdPluginOptions

With debug over 500 one can see the "from=fileset" option being passed to the FD and parsed by the python plugin.

With TLS Enable = no and TCPdump one can see that no other Option string is sent to the FD
Tagsdirector, fd, plugin
bareos-master: impact
bareos-master: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Activities

b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 17:51

reporter   ~0003552

maybe related: https://bugs.bareos.org/view.php?id=733
b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 17:54

reporter   ~0003553

So I worked my way through the source code and roughly patched a version together which finally send all FD related plugin options to the FD:
https://github.com/bareos/bareos/pull/238
b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 18:08

reporter   ~0003554

So I need a bit of support here:
1) Is there any reason why the plugin options are split into "jcr->plugin_options" and "jcr->res.job->FdPluginOptions"?
2) Does anyone contradict to send all plugin options to the FD?
3) Any other suggestions on the PR? I have no experience in cpp at all.

Issue History

Date Modified Username Field Change
2019-08-01 17:50 b.braunger@syseleven.de New Issue
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: director
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: fd
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: plugin
2019-08-01 17:51 b.braunger@syseleven.de Note Added: 0003552
2019-08-01 17:54 b.braunger@syseleven.de Note Added: 0003553
2019-08-01 18:08 b.braunger@syseleven.de Note Added: 0003554