View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0001106bareos-coredirectorpublic2019-08-01 17:502024-03-20 14:43
Reporterb.braunger@syseleven.de Assigned Tostephand  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
PlatformLinuxOSUbuntuOS Version16.04
Product Version18.2.6 
Summary0001106: Director's not sending Plugin Options to FileDaemon
DescriptionI want to use a fileset with a python command plugin for multiple jobs and give extra key value pairs to the plug via the "FD Plugin Options" parameter.
As far as I understand the docs I can add options to the "FD Plugin Options" in the job resource which then will be passed to the Plugin additionally to the Options set in the fileset.

Sadly nothing but the Options String from the fileset is sent to the FD Plugin no matter what I define. This extends to the Plugin Options which are set via bconsole they're all ignored.
Steps To ReproduceFileSet {
  Name = "testing"
  Include {
    Plugin = "python:module_path=/usr/lib64/bareos/plugins:module_name=test_plugin:from=fileset"
  }
}
Job {
  Name = backup-bareos-test
  FileSet = testing
  FD Plugin Options = "python:from=job"
}

* run job=backup-bareos-test pluginoptions="from=bconsole" yes
Additional InformationDoc: https://docs.bareos.org/Configuration/Director.html#config-Dir_Job_FdPluginOptions

With debug over 500 one can see the "from=fileset" option being passed to the FD and parsed by the python plugin.

With TLS Enable = no and TCPdump one can see that no other Option string is sent to the FD
Tagsdirector, fd, plugin

Relationships

related to 0001110 closedbruno-at-bareos BareosFdPluginBaseclass:parse_plugin_definition() does not allow to override plugin options using FD Plugin Options in Job 

Activities

b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 17:51

reporter   ~0003552

maybe related: https://bugs.bareos.org/view.php?id=733
b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 17:54

reporter   ~0003553

So I worked my way through the source code and roughly patched a version together which finally send all FD related plugin options to the FD:
https://github.com/bareos/bareos/pull/238
b.braunger@syseleven.de

b.braunger@syseleven.de

2019-08-01 18:08

reporter   ~0003554

So I need a bit of support here:
1) Is there any reason why the plugin options are split into "jcr->plugin_options" and "jcr->res.job->FdPluginOptions"?
2) Does anyone contradict to send all plugin options to the FD?
3) Any other suggestions on the PR? I have no experience in cpp at all.
b.braunger@syseleven.de

b.braunger@syseleven.de

2019-10-14 12:10

reporter   ~0003596

This is fixed and merged by https://github.com/bareos/bareos/pull/238
bruno-at-bareos

bruno-at-bareos

2024-03-20 14:43

manager   ~0005855

PR merged

Issue History

Date Modified Username Field Change
2019-08-01 17:50 b.braunger@syseleven.de New Issue
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: director
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: fd
2019-08-01 17:50 b.braunger@syseleven.de Tag Attached: plugin
2019-08-01 17:51 b.braunger@syseleven.de Note Added: 0003552
2019-08-01 17:54 b.braunger@syseleven.de Note Added: 0003553
2019-08-01 18:08 b.braunger@syseleven.de Note Added: 0003554
2019-09-05 12:44 stephand Assigned To => stephand
2019-09-05 12:44 stephand Status new => assigned
2019-09-05 13:08 stephand Relationship added related to 0001110
2019-10-14 12:10 b.braunger@syseleven.de Note Added: 0003596
2024-03-20 14:43 bruno-at-bareos Status assigned => closed
2024-03-20 14:43 bruno-at-bareos Resolution open => fixed
2024-03-20 14:43 bruno-at-bareos Note Added: 0005855