Changesets: bareos

master 68bd762f

2013-12-27 13:07

mvwieringen

Ported: N/A

Details Diff
Change getJobType() == JT_XX into is_JobType(JT_XX)
mod - src/dird/backup.c Diff File
mod - src/dird/job.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ua_run.c Diff File
mod - src/dird/ua_status.c Diff File
mod - src/filed/verify.c Diff File
mod - src/stored/askdir.c Diff File
mod - src/stored/block.c Diff File
mod - src/stored/mac.c Diff File

master d45b3c75

2013-12-27 13:07

mvwieringen

Ported: N/A

Details Diff
First attempt at proper support for JS_Warnings

Hopefully fixes a TODO from March 2009 when the first attempt was made
to introduce JS_Warnings but things never finished.

Fixes 0000255: Bad mail subject when an backup terminates with warnings
Affected Issues
0000255
mod - src/cats/bvfs.c Diff File
mod - src/dird/backup.c Diff File
mod - src/dird/jobq.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ndmp_dma.c Diff File
mod - src/dird/vbackup.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/include/jcr.h Diff File
mod - src/lib/runscript.c Diff File
mod - src/qt-console/util/comboutil.cpp Diff File
mod - src/stored/bscan.c Diff File
mod - src/stored/ndmp_tape.c Diff File

master 41127f7b

2013-12-26 20:09

Marco van Wieringen

Ported: N/A

Details Diff
Allow history file and size to be configurable.

Up until now the readline history file always had a fixed name and size
of 100 entries in memory and 200 on disk. You could always configure a
name for the history file but it was never used. We now also always
truncate the history size to the configured size before reading it into
memory.
mod - src/console/console.c Diff File
mod - src/console/console_conf.c Diff File
mod - src/console/console_conf.h Diff File

master 6a2f04a2

2013-12-26 19:09

mvwieringen

Ported: N/A

Details Diff
Allow history file and size to be configurable.

Up until now the readline history file always had a fixed name and size
of 100 entries in memory and 200 on disk. You could always configure a
name for the history file but it was never used. We now also always
truncate the history size to the configured size before reading it into
memory.
mod - src/console/console.c Diff File
mod - src/console/console_conf.c Diff File
mod - src/console/console_conf.h Diff File

master 73d26a5e

2013-12-23 17:50

Joerg Steffens


Committer: Marco van Wieringen

Ported: N/A

Details Diff
added depency to openssl

bareos-config call openssl to generate passwords.
This patch added the package depency to openssl.

Fixes 0000262: debian packages missing openssl dependency
mod - debian/control Diff File
mod - platforms/packaging/bareos.spec Diff File

master 1c97eb0d

2013-12-23 17:41

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
Fixed build problem on centos5/rhel5

We had a packaging problem on those dists
as the python scripts are intalled during
make install but not packaged.

now we remove them in those dists.
mod - platforms/packaging/bareos.spec Diff File

master 1e42c890

2013-12-23 16:50

joergs


Committer: pstorz

Ported: N/A

Details Diff
added depency to openssl

bareos-config call openssl to generate passwords.
This patch added the package depency to openssl.

Fixes 0000262: debian packages missing openssl dependency
Affected Issues
0000262
mod - debian/control Diff File
mod - platforms/packaging/bareos.spec Diff File

master 6cae3b46

2013-12-23 16:41

pstorz

Ported: N/A

Details Diff
Fixed build problem on centos5/rhel5

We had a packaging problem on those dists
as the python scripts are intalled during
make install but not packaged.

now we remove them in those dists.
mod - platforms/packaging/bareos.spec Diff File

bareos-13.2 a70f483b

2013-12-23 16:31

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

master 15cb99ff

2013-12-23 16:31

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

master 30ae9f4f

2013-12-23 15:31

pstorz

Ported: N/A

Details Diff
Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

bareos-13.2 8be412d3

2013-12-23 15:31

pstorz

Ported: N/A

Details Diff
Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

master fbb4d1c3

2013-12-20 14:45

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
Cleanup .dsc files
mod - platforms/packaging/bareos-Debian_6.0.dsc Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos-Univention_3.1.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_10.04.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_12.04.dsc Diff File

master 510a8cb5

2013-12-20 13:45

pstorz

Ported: N/A

Details Diff
Cleanup .dsc files
mod - platforms/packaging/bareos-Debian_6.0.dsc Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos-Univention_3.1.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_10.04.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_12.04.dsc Diff File

master 41eca748

2013-12-20 11:20

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
python plugins now also for debian based dists

now we also build python plugin package for
.deb based distributions.

Now the makefiles of the plugins do install
the plugin itself and the basic *.py files.
mod - debian/bareos-director.install Diff File
mod - debian/bareos-filedaemon.install Diff File
mod - debian/bareos-storage.install Diff File
mod - debian/control Diff File
mod - debian/rules Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos.spec Diff File
mod - src/plugins/dird/Makefile.in Diff File
mod - src/plugins/filed/Makefile.in Diff File
mod - src/plugins/stored/Makefile.in Diff File

master 74ca05f1

2013-12-20 10:20

pstorz

Ported: N/A

Details Diff
python plugins now also for debian based dists

now we also build python plugin package for
.deb based distributions.

Now the makefiles of the plugins do install
the plugin itself and the basic *.py files.
mod - debian/bareos-director.install Diff File
mod - debian/bareos-filedaemon.install Diff File
mod - debian/bareos-storage.install Diff File
mod - debian/control Diff File
mod - debian/rules Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos.spec Diff File
mod - src/plugins/dird/Makefile.in Diff File
mod - src/plugins/filed/Makefile.in Diff File
mod - src/plugins/stored/Makefile.in Diff File

bareos-13.2 87213556

2013-12-19 16:40

Marco van Wieringen

Ported: N/A

Details Diff
Fix indent.
mod - src/dird/ua_select.c Diff File

master 40368e97

2013-12-19 16:40

Marco van Wieringen

Ported: N/A

Details Diff
Fix indent.
mod - src/dird/ua_select.c Diff File

master ab03ec56

2013-12-19 15:40

mvwieringen

Ported: N/A

Details Diff
Fix indent.
mod - src/dird/ua_select.c Diff File

bareos-13.2 cb17833d

2013-12-19 15:40

mvwieringen

Ported: N/A

Details Diff
Fix indent.
mod - src/dird/ua_select.c Diff File

bareos-13.2 a46d8e9a

2013-12-18 13:34

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff
Fixed wrong handling of cancel command

Fixes 0000261: cancel all" crashs often director
mod - src/dird/ua_select.c Diff File

bareos-13.2 84439d8c

2013-12-18 12:34

pstorz

Ported: N/A

Details Diff
Fixed wrong handling of cancel command

Fixes 0000261: cancel all" crashs often director
Affected Issues
0000261
mod - src/dird/ua_select.c Diff File

master 2dd77631

2013-12-18 12:34

pstorz

Ported: N/A

Details Diff
Fixed wrong handling of cancel command

Fixes 0000261: cancel all" crashs often director
Affected Issues
0000261
mod - src/dird/ua_select.c Diff File

master 9c92773e

2013-12-17 18:11

Andre Noll


Committer: Marco van Wieringen

Ported: N/A

Details Diff
lib/parse_conf.c: Don't segfault on parse errors.

During daemon startup, parse_config() calls lex_open_file() which
returns a pointer to an initialized LEX structure on success or a
NULL pointer on failure, for example because the given config file
does not exist.

In the error case parse_config() allocates a LEX structure of its own
and initializes it with zeroes. In particular, this sets its POOLMEM
pointer ->str to NULL. Since ->str is used as the destination for
bstrncpy() a few lines later, a NULL pointer dereference results:

==2957== Memcheck, a memory error detector
==2957== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==2957== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==2957== Command: /usr/local/bareos/sbin/bareos-dir -t
==2957==
==2957== Invalid write of size 1
==2957== at 0x4C2C2F7: __GI_strncpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2957== by 0x56AB800: bstrncpy(char*, char const*, int) (bsys.c:175)
==2957== by 0x547E1EF: CONFIG::parse_config() (parse_conf.c:281)
==2957== by 0x40C5BA: main (dird.c:282)
==2957== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==2957==

This patch avoids the NULL pointer dereference by using the local cf
variable instead of trying to create a copy.

This bug was probably introduced in commit 12a0fdd0 (Config engine
redesign Phase 1) a few months back, since the unpatched code would
work fine if ->str was an array, and 12a0fdd0 changed the type from
array to pointer:

- char str[MAXSTRING]; /* string being scanned */
+ POOLMEM *str; /* string being scanned */

Signed-off-by: Philipp Storz <philipp.storz@bareos.com>
mod - src/lib/parse_conf.c Diff File

master fbd5480a

2013-12-17 17:11

Andre Noll


Committer: pstorz

Ported: N/A

Details Diff
lib/parse_conf.c: Don't segfault on parse errors.

During daemon startup, parse_config() calls lex_open_file() which
returns a pointer to an initialized LEX structure on success or a
NULL pointer on failure, for example because the given config file
does not exist.

In the error case parse_config() allocates a LEX structure of its own
and initializes it with zeroes. In particular, this sets its POOLMEM
pointer ->str to NULL. Since ->str is used as the destination for
bstrncpy() a few lines later, a NULL pointer dereference results:

==2957== Memcheck, a memory error detector
==2957== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==2957== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==2957== Command: /usr/local/bareos/sbin/bareos-dir -t
==2957==
==2957== Invalid write of size 1
==2957== at 0x4C2C2F7: __GI_strncpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2957== by 0x56AB800: bstrncpy(char*, char const*, int) (bsys.c:175)
==2957== by 0x547E1EF: CONFIG::parse_config() (parse_conf.c:281)
==2957== by 0x40C5BA: main (dird.c:282)
==2957== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==2957==

This patch avoids the NULL pointer dereference by using the local cf
variable instead of trying to create a copy.

This bug was probably introduced in commit 12a0fdd0 (Config engine
redesign Phase 1) a few months back, since the unpatched code would
work fine if ->str was an array, and 12a0fdd0 changed the type from
array to pointer:

- char str[MAXSTRING]; /* string being scanned */
+ POOLMEM *str; /* string being scanned */

Signed-off-by: Philipp Storz <philipp.storz@bareos.com>
mod - src/lib/parse_conf.c Diff File
 First  Prev  1 2 3 ... 60 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 589 590 591 592 593 594 595 ... 600 ... 628 629 630  Next  Last