Changesets: bareos2015

Search Browse Back to Index

bareos-14.2 d00f6536

2014-01-12 22:30

mvwieringen

Ported: N/A

Details Diff		 BVFS reported a problem for <id> fix.

There was a mixup of the return value returned from the
bvfs_update_path_hierarchy_cache() function which returns a zero which
is interpretted as a false by the calling dot_bvfs_update() function.
Lets return a proper boolean value and only set that return value to
true when we leave the bvfs_update_path_hierarchy_cache() function due
to hitting either an empty jobid list or after processing the jobid list
successfully. Any other exit (due to joblist corruption or failing to
update the path hierarchy cache) leads to the function returning false.

Fixes 0000217: BVFS reported a problem for <id>		 Affected Issues
0000217
mod - src/cats/bvfs.c Diff File
mod - src/cats/bvfs.h Diff File
mod - src/dird/ua_dotcmds.c Diff File

bareos-14.2 e8a3864f

2014-01-08 14:02

mvwieringen

Ported: N/A

Details Diff		 Add bEventNewPluginOptions event.

When pushing explicit plugin arguments use a new event
bEventNewPluginOptions instead of reusing the bEventPluginCommand
event which is also used when parsing the fileset when doing a backup.

Most plugins should now also allow multiple plugin lines within one
include block of the fileset which was broken when it used the new
config parser. In combination with forcing certain explicit restore
options by the director using the plugin options passing this may lead
to some surprises however so when using specific plugin options its wise
to only restore one file at a time to be sure the right restore options
are used.
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/fd_plugins.h Diff File
mod - src/plugins/filed/bareos_fd_consts.py Diff File
mod - src/plugins/filed/bpipe-fd.c Diff File
mod - src/plugins/filed/python-fd.c Diff File
mod - src/win32/plugins/filed/mssqlvdi-fd.c Diff File

bareos-14.2 7c905257

2014-01-07 18:13

mvwieringen

Ported: N/A

Details Diff		 Upgrade bpipe plugin to use new plugin config parser.

Now that we use a new config parser for the mssqlvdi and python plugin
it makes sense to also let the bpipe plugin use this code. For backwards
compatability it also still supports the old plugin definitions so you
can also still restore older backups with the new plugin. Extra support
is added so that plugin options passing now also works and allows you to
override the plugin parameters.
mod - src/plugins/filed/bpipe-fd.c Diff File

bareos-14.2 de6381d9

2014-01-07 18:09

mvwieringen

Ported: N/A

Details Diff		 Make the error message a bit more explicit.

When the compat mode is enabled we report a Bacula compatible version id
for the filed protocol. But if you want things like passive mode or
plugin passing you need to disable the compat mode. Changed the error
message issued when using passive mode or plugin option passing when
talking to a Bareos filed in compat mode. This way the use a least knows
that it could also be a problem with the compat mode.
mod - src/dird/backup.c Diff File
mod - src/dird/restore.c Diff File
mod - src/dird/verify.c Diff File

bareos-14.2 05f66052

2014-01-07 14:48

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Plugin Options ACL now works.

Fixes: 0000266: pluginoptions override not working during restore		 Affected Issues
0000266
mod - src/dird/ua_acl.c Diff File

bareos-14.2 722a1ef4

2014-01-06 12:43

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 check return values of spool functions

We now check the return values of

* begin_data_spool()
* begin_attribute_spool()

as otherwise the job hangs until eternety if there is a problem with the
spool file.

Fixes: 0000265: job hangs and cannot be terminated if spool file is not writable		 Affected Issues
0000265
mod - src/stored/append.c Diff File
mod - src/stored/mac.c Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-13.2 49db247b

2014-01-06 12:43

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 check return values of spool functions

We now check the return values of

* begin_data_spool()
* begin_attribute_spool()

as otherwise the job hangs until eternety if there is a problem with the
spool file.

Fixes: 0000265: job hangs and cannot be terminated if spool file is not writable		 Affected Issues
0000265
mod - src/stored/append.c Diff File
mod - src/stored/mac.c Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-14.2 20a46676

2013-12-27 14:07

mvwieringen

Ported: N/A

Details Diff		 Change getJobType() == JT_XX into is_JobType(JT_XX)
mod - src/dird/backup.c Diff File
mod - src/dird/job.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ua_run.c Diff File
mod - src/dird/ua_status.c Diff File
mod - src/filed/verify.c Diff File
mod - src/stored/askdir.c Diff File
mod - src/stored/block.c Diff File
mod - src/stored/mac.c Diff File

bareos-14.2 7202a401

2013-12-27 14:07

mvwieringen

Ported: N/A

Details Diff		 First attempt at proper support for JS_Warnings

Hopefully fixes a TODO from March 2009 when the first attempt was made
to introduce JS_Warnings but things never finished.

Fixes 0000255: Bad mail subject when an backup terminates with warnings		 Affected Issues
0000255
mod - src/cats/bvfs.c Diff File
mod - src/dird/backup.c Diff File
mod - src/dird/jobq.c Diff File
mod - src/dird/migrate.c Diff File
mod - src/dird/ndmp_dma.c Diff File
mod - src/dird/vbackup.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/include/jcr.h Diff File
mod - src/lib/runscript.c Diff File
mod - src/qt-console/util/comboutil.cpp Diff File
mod - src/stored/bscan.c Diff File
mod - src/stored/ndmp_tape.c Diff File

bareos-14.2 41127f7b

2013-12-26 20:09

mvwieringen

Ported: N/A

Details Diff		 Allow history file and size to be configurable.

Up until now the readline history file always had a fixed name and size
of 100 entries in memory and 200 on disk. You could always configure a
name for the history file but it was never used. We now also always
truncate the history size to the configured size before reading it into
memory.
mod - src/console/console.c Diff File
mod - src/console/console_conf.c Diff File
mod - src/console/console_conf.h Diff File

bareos-14.2 73d26a5e

2013-12-23 17:50

joergs


Committer: mvwieringen

Ported: N/A

Details Diff		 added depency to openssl

bareos-config call openssl to generate passwords.
This patch added the package depency to openssl.

Fixes 0000262: debian packages missing openssl dependency		 Affected Issues
0000262
mod - debian/control Diff File
mod - platforms/packaging/bareos.spec Diff File

bareos-14.2 1c97eb0d

2013-12-23 17:41

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed build problem on centos5/rhel5

We had a packaging problem on those dists
as the python scripts are intalled during
make install but not packaged.

now we remove them in those dists.
mod - platforms/packaging/bareos.spec Diff File

bareos-14.2 15cb99ff

2013-12-23 16:31

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

bareos-13.2 a70f483b

2013-12-23 16:31

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Added Univention 3.2 Support
mod - README.md Diff File
add - platforms/packaging/bareos-Univention_3.2.dsc Diff File

bareos-14.2 fbb4d1c3

2013-12-20 14:45

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Cleanup .dsc files
mod - platforms/packaging/bareos-Debian_6.0.dsc Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos-Univention_3.1.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_10.04.dsc Diff File
mod - platforms/packaging/bareos-xUbuntu_12.04.dsc Diff File

bareos-14.2 41eca748

2013-12-20 11:20

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 python plugins now also for debian based dists

now we also build python plugin package for
.deb based distributions.

Now the makefiles of the plugins do install
the plugin itself and the basic *.py files.
mod - debian/bareos-director.install Diff File
mod - debian/bareos-filedaemon.install Diff File
mod - debian/bareos-storage.install Diff File
mod - debian/control Diff File
mod - debian/rules Diff File
mod - platforms/packaging/bareos-Debian_7.0.dsc Diff File
mod - platforms/packaging/bareos.spec Diff File
mod - src/plugins/dird/Makefile.in Diff File
mod - src/plugins/filed/Makefile.in Diff File
mod - src/plugins/stored/Makefile.in Diff File

bareos-14.2 40368e97

2013-12-19 16:40

mvwieringen

Ported: N/A

Details Diff		 Fix indent.
mod - src/dird/ua_select.c Diff File

bareos-13.2 87213556

2013-12-19 16:40

mvwieringen

Ported: N/A

Details Diff		 Fix indent.
mod - src/dird/ua_select.c Diff File

bareos-13.2 a46d8e9a

2013-12-18 13:34

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed wrong handling of cancel command

Fixes 0000261: cancel all" crashs often director		 Affected Issues
0000261
mod - src/dird/ua_select.c Diff File

bareos-14.2 9c92773e

2013-12-17 18:11

Andre Noll


Committer: mvwieringen

Ported: N/A

Details Diff		 lib/parse_conf.c: Don't segfault on parse errors.

During daemon startup, parse_config() calls lex_open_file() which
returns a pointer to an initialized LEX structure on success or a
NULL pointer on failure, for example because the given config file
does not exist.

In the error case parse_config() allocates a LEX structure of its own
and initializes it with zeroes. In particular, this sets its POOLMEM
pointer ->str to NULL. Since ->str is used as the destination for
bstrncpy() a few lines later, a NULL pointer dereference results:

==2957== Memcheck, a memory error detector
==2957== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al.
==2957== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info
==2957== Command: /usr/local/bareos/sbin/bareos-dir -t
==2957==
==2957== Invalid write of size 1
==2957== at 0x4C2C2F7: __GI_strncpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==2957== by 0x56AB800: bstrncpy(char*, char const*, int) (bsys.c:175)
==2957== by 0x547E1EF: CONFIG::parse_config() (parse_conf.c:281)
==2957== by 0x40C5BA: main (dird.c:282)
==2957== Address 0x0 is not stack'd, malloc'd or (recently) free'd
==2957==

This patch avoids the NULL pointer dereference by using the local cf
variable instead of trying to create a copy.

This bug was probably introduced in commit 12a0fdd0 (Config engine
redesign Phase 1) a few months back, since the unpatched code would
work fine if ->str was an array, and 12a0fdd0 changed the type from
array to pointer:

- char str[MAXSTRING]; /* string being scanned */
+ POOLMEM *str; /* string being scanned */

Signed-off-by: Philipp Storz <philipp.storz@bareos.com>
mod - src/lib/parse_conf.c Diff File

bareos-14.2 b8292a5e

2013-12-13 17:23

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fix for SLES

Fixed spec file to also build for SLES
mod - platforms/packaging/bareos.spec Diff File

bareos-14.2 714fcb27

2013-12-13 16:23

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Fixed disappeared status message

somehow we lost the status output when the console
connects to the director.

This is now readded, thanks to Olivier DELESTRE for
finding this problem.
mod - src/console/console.c Diff File

bareos-14.2 fcbdd16d

2013-12-13 15:35

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 also package .pyc and .pyo files

On rh/centos/fedora we now also package
the .pyc and .pyo files
mod - platforms/packaging/bareos.spec Diff File

bareos-14.2 33d13871

2013-12-12 14:17

pstorz


Committer: mvwieringen

Ported: N/A

Details Diff		 Packaging of the python plugins added

As we now have the python plugin infrastructure running,
we now also package that plugins and additional files into
extra packages

As RHEL5 and CentOS5 do have a too old python version we
do not build the python plugins there and remove
the dummy plugis
mod - platforms/packaging/bareos.spec Diff File

bareos-14.2 49562357

2013-12-12 12:21

mvwieringen

Ported: N/A

Details Diff		 Fix compiler warning.
mod - src/plugins/filed/python-fd.c Diff File
 First  Prev  1 2 3 ... 10 ... 20 ... 26 27 28 29 30 31 32 ... 40 ... 50 ... 57 58 59  Next  Last