Changesets: bareos
|
bareos-13.2 84439d8c 2013-12-18 12:34 Ported: N/A Details Diff |
Fixed wrong handling of cancel command Fixes 0000261: cancel all" crashs often director |
Affected Issues 0000261 |
|
| mod - src/dird/ua_select.c | Diff File | ||
|
master 2dd77631 2013-12-18 12:34 Ported: N/A Details Diff |
Fixed wrong handling of cancel command Fixes 0000261: cancel all" crashs often director |
Affected Issues 0000261 |
|
| mod - src/dird/ua_select.c | Diff File | ||
|
master 9c92773e 2013-12-17 18:11 Andre Noll Committer: Marco van Wieringen Ported: N/A Details Diff |
lib/parse_conf.c: Don't segfault on parse errors. During daemon startup, parse_config() calls lex_open_file() which returns a pointer to an initialized LEX structure on success or a NULL pointer on failure, for example because the given config file does not exist. In the error case parse_config() allocates a LEX structure of its own and initializes it with zeroes. In particular, this sets its POOLMEM pointer ->str to NULL. Since ->str is used as the destination for bstrncpy() a few lines later, a NULL pointer dereference results: ==2957== Memcheck, a memory error detector ==2957== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al. ==2957== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info ==2957== Command: /usr/local/bareos/sbin/bareos-dir -t ==2957== ==2957== Invalid write of size 1 ==2957== at 0x4C2C2F7: __GI_strncpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==2957== by 0x56AB800: bstrncpy(char*, char const*, int) (bsys.c:175) ==2957== by 0x547E1EF: CONFIG::parse_config() (parse_conf.c:281) ==2957== by 0x40C5BA: main (dird.c:282) ==2957== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==2957== This patch avoids the NULL pointer dereference by using the local cf variable instead of trying to create a copy. This bug was probably introduced in commit 12a0fdd0 (Config engine redesign Phase 1) a few months back, since the unpatched code would work fine if ->str was an array, and 12a0fdd0 changed the type from array to pointer: - char str[MAXSTRING]; /* string being scanned */ + POOLMEM *str; /* string being scanned */ Signed-off-by: Philipp Storz <philipp.storz@bareos.com> |
||
| mod - src/lib/parse_conf.c | Diff File | ||
|
master fbd5480a 2013-12-17 17:11 Andre Noll Committer: pstorz Ported: N/A Details Diff |
lib/parse_conf.c: Don't segfault on parse errors. During daemon startup, parse_config() calls lex_open_file() which returns a pointer to an initialized LEX structure on success or a NULL pointer on failure, for example because the given config file does not exist. In the error case parse_config() allocates a LEX structure of its own and initializes it with zeroes. In particular, this sets its POOLMEM pointer ->str to NULL. Since ->str is used as the destination for bstrncpy() a few lines later, a NULL pointer dereference results: ==2957== Memcheck, a memory error detector ==2957== Copyright (C) 2002-2011, and GNU GPL'd, by Julian Seward et al. ==2957== Using Valgrind-3.7.0 and LibVEX; rerun with -h for copyright info ==2957== Command: /usr/local/bareos/sbin/bareos-dir -t ==2957== ==2957== Invalid write of size 1 ==2957== at 0x4C2C2F7: __GI_strncpy (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==2957== by 0x56AB800: bstrncpy(char*, char const*, int) (bsys.c:175) ==2957== by 0x547E1EF: CONFIG::parse_config() (parse_conf.c:281) ==2957== by 0x40C5BA: main (dird.c:282) ==2957== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==2957== This patch avoids the NULL pointer dereference by using the local cf variable instead of trying to create a copy. This bug was probably introduced in commit 12a0fdd0 (Config engine redesign Phase 1) a few months back, since the unpatched code would work fine if ->str was an array, and 12a0fdd0 changed the type from array to pointer: - char str[MAXSTRING]; /* string being scanned */ + POOLMEM *str; /* string being scanned */ Signed-off-by: Philipp Storz <philipp.storz@bareos.com> |
||
| mod - src/lib/parse_conf.c | Diff File | ||
|
master b8292a5e 2013-12-13 17:23 Philipp Storz Committer: Marco van Wieringen Ported: N/A Details Diff |
Fix for SLES Fixed spec file to also build for SLES |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master 714fcb27 2013-12-13 16:23 Philipp Storz Committer: Marco van Wieringen Ported: N/A Details Diff |
Fixed disappeared status message somehow we lost the status output when the console connects to the director. This is now readded, thanks to Olivier DELESTRE for finding this problem. |
||
| mod - src/console/console.c | Diff File | ||
|
master b4d81dba 2013-12-13 16:23 Ported: N/A Details Diff |
Fix for SLES Fixed spec file to also build for SLES |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master fcbdd16d 2013-12-13 15:35 Philipp Storz Committer: Marco van Wieringen Ported: N/A Details Diff |
also package .pyc and .pyo files On rh/centos/fedora we now also package the .pyc and .pyo files |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master 36284bfc 2013-12-13 15:23 Ported: N/A Details Diff |
Fixed disappeared status message somehow we lost the status output when the console connects to the director. This is now readded, thanks to Olivier DELESTRE for finding this problem. |
||
| mod - src/console/console.c | Diff File | ||
|
master 064e712c 2013-12-13 14:35 Ported: N/A Details Diff |
also package .pyc and .pyo files On rh/centos/fedora we now also package the .pyc and .pyo files |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master 33d13871 2013-12-12 14:17 Philipp Storz Committer: Marco van Wieringen Ported: N/A Details Diff |
Packaging of the python plugins added As we now have the python plugin infrastructure running, we now also package that plugins and additional files into extra packages As RHEL5 and CentOS5 do have a too old python version we do not build the python plugins there and remove the dummy plugis |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master 0126482f 2013-12-12 13:17 Ported: N/A Details Diff |
Packaging of the python plugins added As we now have the python plugin infrastructure running, we now also package that plugins and additional files into extra packages As RHEL5 and CentOS5 do have a too old python version we do not build the python plugins there and remove the dummy plugis |
||
| mod - platforms/packaging/bareos.spec | Diff File | ||
|
master 49562357 2013-12-12 12:21 Marco van Wieringen Ported: N/A Details Diff |
Fix compiler warning. | ||
| mod - src/plugins/filed/python-fd.c | Diff File | ||
|
bareos-13.2 0169d434 2013-12-12 12:11 Marco van Wieringen Ported: N/A Details Diff |
Fix Solaris 10 build. Fixes 0000260: Unable to compile/install the client under Solaris 10 U11 |
||
| mod - platforms/Makefile.in | Diff File | ||
| mod - src/lib/bsys.c | Diff File | ||
|
master 94d20e15 2013-12-12 12:11 Marco van Wieringen Ported: N/A Details Diff |
Fix Solaris 10 build. Fixes 0000260: Unable to compile/install the client under Solaris 10 U11 |
||
| mod - platforms/Makefile.in | Diff File | ||
| mod - src/lib/bsys.c | Diff File | ||
|
master 4cbb0178 2013-12-12 11:21 Ported: N/A Details Diff |
Fix compiler warning. | ||
| mod - src/plugins/filed/python-fd.c | Diff File | ||
|
master f38ef0b5 2013-12-12 11:11 Ported: N/A Details Diff |
Fix Solaris 10 build. Fixes 0000260: Unable to compile/install the client under Solaris 10 U11 |
Affected Issues 0000260 |
|
| mod - platforms/Makefile.in | Diff File | ||
| mod - src/lib/bsys.c | Diff File | ||
|
bareos-13.2 2a515d93 2013-12-12 11:11 Ported: N/A Details Diff |
Fix Solaris 10 build. Fixes 0000260: Unable to compile/install the client under Solaris 10 U11 |
Affected Issues 0000260 |
|
| mod - platforms/Makefile.in | Diff File | ||
| mod - src/lib/bsys.c | Diff File | ||
|
bareos-12.4 10e79f4e 2013-12-12 11:11 Ported: N/A Details Diff |
Fix Solaris 10 build. Fixes 0000260: Unable to compile/install the client under Solaris 10 U11 |
Affected Issues 0000260 |
|
| mod - platforms/Makefile.in | Diff File | ||
| mod - src/lib/bsys.c | Diff File | ||
|
master 18749b68 2013-12-10 19:03 Marco van Wieringen Ported: N/A Details Diff |
Fix memory leak. | ||
| mod - src/dird/ua_server.c | Diff File | ||
|
master b5110c55 2013-12-10 18:31 Marco van Wieringen Ported: N/A Details Diff |
Fix NSI build. | ||
| mod - platforms/win32/winbareos-nsi.spec | Diff File | ||
|
master 8c211426 2013-12-10 18:03 Ported: N/A Details Diff |
Fix memory leak. | ||
| mod - src/dird/ua_server.c | Diff File | ||
|
master de596b85 2013-12-10 18:00 Marco van Wieringen Ported: N/A Details Diff |
Add dummy default for NDMP port. | ||
| mod - src/win32/compat/include/winhost.h | Diff File | ||
|
master 8702eef4 2013-12-10 17:50 Marco van Wieringen Ported: N/A Details Diff |
Fix windows Makefile for new socket abstraction. | ||
| mod - src/win32/lib/Makefile | Diff File | ||
|
master 2d8898e3 2013-12-10 17:31 Ported: N/A Details Diff |
Fix NSI build. | ||
| mod - platforms/win32/winbareos-nsi.spec | Diff File | ||
