Changesets: bareos

master 16731f3d

2024-03-05 00:04

stephand


Committer: Bareos Bot

Ported: N/A

Details Diff
VMware Plugin: Backup and Restore NVRAM

The NVRAM of VMs is now backed up and restored when a VM is recreated.
This ensures that EFI enabled VMs will boot successfully.

Additionally, the exception handling and error messages in the functions
connect_vmware() and retrieve_vcthumbprint() were enhanced.

The plugin now makes sure to store all files belonging to a recreated VM
in the same directory in VMFS.

This commit also contains some changes to improve the pylint score.
mod - core/src/plugins/filed/python/vmware/bareos-fd-vmware.py Diff File
mod - docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/VMwarePlugin.rst.inc Diff File

master e075c867

2024-03-04 12:49

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dird-cmd: fix using unchanging bool inside loop
mod - core/src/filed/dir_cmd.cc Diff File

master 13af6b10

2024-03-04 10:43

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix initializing mutex multiple times
mod - core/src/stored/reserve.cc Diff File

master f82282c2

2024-03-04 10:22

Sebastian Sura

Ported: N/A

Details Diff
append: fix not checking for errors
mod - core/src/stored/append.cc Diff File

master b683b43c

2024-03-04 10:17

Sebastian Sura

Ported: N/A

Details Diff
append: add jmsg on no reservation
mod - core/src/stored/append.cc Diff File

master c0d99c86

2024-03-04 10:10

Sebastian Sura

Ported: N/A

Details Diff
reserve: remove impossible if condition

Since SetupinewDcrDevice accesses dcr, dcr can never be null after
if (rct.store->append) { ... }, so the if would have never fired.

Since the branches of the if are basically the same, the
SetupNewDcrDevice was extracted out of them.
mod - core/src/stored/reserve.cc Diff File

master 812e0b0e

2024-03-04 10:06

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix error message not being jmsg
mod - core/src/stored/reserve.cc Diff File

master deb443eb

2024-03-04 09:14

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
test-config-parser-dir: fix memory leaks
mod - core/src/tests/CMakeLists.txt Diff File
mod - core/src/tests/test_config_parser_dir.cc Diff File

master e2bb411b

2024-03-04 08:51

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
restore-test: fix copyright notice
mod - systemtests/tests/restore/CMakeLists.txt Diff File
mod - systemtests/tests/restore/testrunner-archive-restore-dir Diff File
mod - systemtests/tests/restore/testrunner-check-hints Diff File
mod - systemtests/tests/restore/testrunner-create-backup Diff File
mod - systemtests/tests/restore/testrunner-error-full-restore Diff File
mod - systemtests/tests/restore/testrunner-full-restore Diff File
mod - systemtests/tests/restore/testrunner-multi Diff File
mod - systemtests/tests/restore/testrunner-restore-dir Diff File
mod - systemtests/tests/restore/testrunner-restore-file Diff File
mod - systemtests/tests/restore/testrunner-restore-fileregex Diff File
mod - systemtests/tests/restore/testrunner-restore-old-archive Diff File

master 08917401

2024-03-01 13:56

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
bdedup-estimate: fix up header order for windows
mod - core/src/lib/crypto.h Diff File
mod - core/src/tools/bdedup-estimate.cc Diff File

master f327300b

2024-03-01 11:45

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
job: fix not freeing plugin_options
mod - core/src/dird/job.cc Diff File

master 0f699e25

2024-03-01 11:43

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dird-jcr: fix various fname leaks

Instead of hunting down every place where this could get leaked, we
instead use PoolMem to do so automatically.
mod - core/src/dird/admin.cc Diff File
mod - core/src/dird/archive.cc Diff File
mod - core/src/dird/consolidate.cc Diff File
mod - core/src/dird/director_jcr_impl.h Diff File
mod - core/src/dird/fd_cmds.cc Diff File
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/verify.cc Diff File

master c3966a5b

2024-03-01 11:42

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
ua-restore: fix not freeing old ClientName before assignment
mod - core/src/dird/ua_restore.cc Diff File

master aaa96355

2024-03-01 11:41

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dbcheck-utils: fix not freeing namelists/idlists
mod - core/src/dird/dbcheck.cc Diff File
mod - core/src/dird/dbcheck_utils.cc Diff File
mod - core/src/dird/dbcheck_utils.h Diff File

master cccd415d

2024-03-01 11:40

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
runscript: fix not freeing ecmd in other branches
mod - core/src/lib/runscript.cc Diff File

master 9b04de29

2024-03-01 11:39

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
acquire: fix not cleaning up allocated storage
mod - core/src/stored/acquire.cc Diff File

master 02722642

2024-03-01 11:36

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
postgresql: fix memory leaks

PQfinish _always_ has to be called on db_handle_, if its not null:

https://www.postgresql.org/docs/current/libpq-connect.html

"Note that when PQconnectStart or PQconnectStartParams returns a
non-null pointer, you must call PQfinish when you are finished with
it, in order to dispose of the structure and any associated memory
blocks. This must be done even if the connection attempt fails or is
abandoned."

PQexec() always allocates a new result object, that always has to be
freed with PQclear()!
mod - core/src/cats/postgresql.cc Diff File

master 88fb5829

2024-03-01 11:31

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
postgresql: fix using multiple transactions
mod - core/src/cats/postgresql.cc Diff File

master c4415a03

2024-03-01 10:49

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
parser: fix leaking memory on error

When an error occurs during the resource scanning, then the scanned
resource is not added to any list, which means its memory is never
freed. As such we free the allocated resource here but calling the
appropriate callback.
mod - core/src/lib/parse_conf_state_machine.cc Diff File

master 237a52b8

2024-03-01 10:48

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
restore-test: fix missing fixture
mod - systemtests/tests/restore/CMakeLists.txt Diff File

master 2bfd3452

2024-03-01 10:46

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
console: fix history leak

Removing unecessary code since stifle_history() already ensures that
we only have at most history_max_entries inside our history.
Regardless this is a leak because remove_history returns to us a
HIST_ENTRY* that we are supposed to free on our own (which we do not
do!).
mod - core/src/console/console.cc Diff File

master 5f51b99b

2024-02-29 13:44

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
python-dir/sd: fix leak
mod - core/src/plugins/dird/python/python-dir.cc Diff File
mod - core/src/plugins/stored/python/python-sd.cc Diff File

master 0ac6b2cd

2024-02-28 18:45

smarsching


Committer: Bareos Bot

Ported: N/A

Details Diff
Fix warning about missing delcandidates table in director.

Pruning jobs would cause the following warning in the output of the
director (e.g. visible through
“systemctl status bareos-director.service”):

table "delcandidates" does not exist, skipping

This warning is harmless but clutters the output. With this commit, this
problem is fixed by disabling warnings for the PostgreSQL connection
that is established by the director.

See https://bugs.bareos.org/view.php?id=1561 and
https://bugs.bareos.org/view.php?id=1606.
mod - AUTHORS Diff File
mod - core/src/cats/postgresql.cc Diff File

master a688c4d0

2024-02-28 14:39

tuxmaster5000


Committer: Bareos Bot

Ported: N/A

Details Diff
Require python3 explicit
mod - contrib/misc/bsmc/bin/bsmc Diff File
mod - contrib/misc/triggerjob/bareos-triggerjob.py Diff File

master 18488d48

2024-02-28 13:28

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix sending data to dir during TryReserveAfterUse()

This should not happen since this function can be called during the
backup, where OK_device/NO_device does not make sense anymore.
mod - core/src/stored/reserve.cc Diff File
 First  Prev  1 2 3 ... 56 57 58 59 60 61 62 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 665 666 667  Next  Last