Changesets: bareos

master c3966a5b

2024-03-01 11:42

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
ua-restore: fix not freeing old ClientName before assignment
mod - core/src/dird/ua_restore.cc Diff File

master aaa96355

2024-03-01 11:41

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
dbcheck-utils: fix not freeing namelists/idlists
mod - core/src/dird/dbcheck.cc Diff File
mod - core/src/dird/dbcheck_utils.cc Diff File
mod - core/src/dird/dbcheck_utils.h Diff File

master cccd415d

2024-03-01 11:40

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
runscript: fix not freeing ecmd in other branches
mod - core/src/lib/runscript.cc Diff File

master 9b04de29

2024-03-01 11:39

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
acquire: fix not cleaning up allocated storage
mod - core/src/stored/acquire.cc Diff File

master 02722642

2024-03-01 11:36

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
postgresql: fix memory leaks

PQfinish _always_ has to be called on db_handle_, if its not null:

https://www.postgresql.org/docs/current/libpq-connect.html

"Note that when PQconnectStart or PQconnectStartParams returns a
non-null pointer, you must call PQfinish when you are finished with
it, in order to dispose of the structure and any associated memory
blocks. This must be done even if the connection attempt fails or is
abandoned."

PQexec() always allocates a new result object, that always has to be
freed with PQclear()!
mod - core/src/cats/postgresql.cc Diff File

master 88fb5829

2024-03-01 11:31

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
postgresql: fix using multiple transactions
mod - core/src/cats/postgresql.cc Diff File

master c4415a03

2024-03-01 10:49

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
parser: fix leaking memory on error

When an error occurs during the resource scanning, then the scanned
resource is not added to any list, which means its memory is never
freed. As such we free the allocated resource here but calling the
appropriate callback.
mod - core/src/lib/parse_conf_state_machine.cc Diff File

master 237a52b8

2024-03-01 10:48

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
restore-test: fix missing fixture
mod - systemtests/tests/restore/CMakeLists.txt Diff File

master 2bfd3452

2024-03-01 10:46

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
console: fix history leak

Removing unecessary code since stifle_history() already ensures that
we only have at most history_max_entries inside our history.
Regardless this is a leak because remove_history returns to us a
HIST_ENTRY* that we are supposed to free on our own (which we do not
do!).
mod - core/src/console/console.cc Diff File

master 5f51b99b

2024-02-29 13:44

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff
python-dir/sd: fix leak
mod - core/src/plugins/dird/python/python-dir.cc Diff File
mod - core/src/plugins/stored/python/python-sd.cc Diff File

master 0ac6b2cd

2024-02-28 18:45

smarsching


Committer: Bareos Bot

Ported: N/A

Details Diff
Fix warning about missing delcandidates table in director.

Pruning jobs would cause the following warning in the output of the
director (e.g. visible through
“systemctl status bareos-director.service”):

table "delcandidates" does not exist, skipping

This warning is harmless but clutters the output. With this commit, this
problem is fixed by disabling warnings for the PostgreSQL connection
that is established by the director.

See https://bugs.bareos.org/view.php?id=1561 and
https://bugs.bareos.org/view.php?id=1606.
mod - AUTHORS Diff File
mod - core/src/cats/postgresql.cc Diff File

master a688c4d0

2024-02-28 14:39

tuxmaster5000


Committer: Bareos Bot

Ported: N/A

Details Diff
Require python3 explicit
mod - contrib/misc/bsmc/bin/bsmc Diff File
mod - contrib/misc/triggerjob/bareos-triggerjob.py Diff File

master 18488d48

2024-02-28 13:28

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix sending data to dir during TryReserveAfterUse()

This should not happen since this function can be called during the
backup, where OK_device/NO_device does not make sense anymore.
mod - core/src/stored/reserve.cc Diff File

master 1e401c83

2024-02-28 13:27

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix not setting dcr in the read case

Sadly a lot of logic relies on the fact that jcr->dcr is always set
and jcr->read_dcr is just sometimes set, as such we need to set both
even when just reading (for now).
mod - core/src/stored/reserve.cc Diff File

master 5bf20603

2024-02-28 09:48

Sebastian Sura

Ported: N/A

Details Diff
reserve: switch to std::mutex

reservations_lock_count was not used (and was used improperly), so it
was removed. reservation_lock is defined as rwlock, but only ever
used as a normal lock, so it was replaced by a std::mutex.
mod - core/src/stored/reserve.cc Diff File

master d23372c4

2024-02-28 09:30

Sebastian Sura

Ported: N/A

Details Diff
reserve: remove jcr from reserve context
mod - core/src/stored/acquire.cc Diff File
mod - core/src/stored/reserve.cc Diff File
mod - core/src/stored/reserve.h Diff File

master 72b66db3

2024-02-28 08:58

Sebastian Sura

Ported: N/A

Details Diff
reserve: move definition of rctx
mod - core/src/stored/reserve.cc Diff File

master 4f152111

2024-02-28 08:57

Sebastian Sura

Ported: N/A

Details Diff
reserve: move locks into loop
mod - core/src/stored/reserve.cc Diff File

master 8345c618

2024-02-28 08:53

Sebastian Sura

Ported: N/A

Details Diff
reserve: rename ok, remove useless if
mod - core/src/stored/reserve.cc Diff File

master 9ae22b57

2024-02-28 08:53

Sebastian Sura

Ported: N/A

Details Diff
reserve: remove always false if
mod - core/src/stored/reserve.cc Diff File

master 4f5572a2

2024-02-28 08:51

Sebastian Sura

Ported: N/A

Details Diff
reserve: fix overriding jcr->sd_impl->dcr
mod - core/src/stored/reserve.cc Diff File

master 3156ff5b

2024-02-28 08:50

Sebastian Sura

Ported: N/A

Details Diff
reserve: make FindSuitableDeviceForJob static
mod - core/src/stored/reserve.cc Diff File
mod - core/src/stored/reserve.h Diff File

master fe612821

2024-02-27 17:59

slederer

Ported: N/A

Details Diff
expand documentation for the LDAP plugin
mod - docs/manuals/source/TasksAndConcepts/Plugins/FileDaemonPlugins/LDAPPlugin.rst.inc Diff File

master a4fb7800

2024-02-27 17:53

joergs


Committer: slederer

Ported: N/A

Details Diff
systemtests py3plug-fd-ldap: add another test case

Also test how the plugin behaves with wrong credentials.
add - systemtests/tests/py3plug-fd-ldap/etc/bareos/bareos-dir.d/fileset/PluginFailingTest.conf.in Diff File
add - systemtests/tests/py3plug-fd-ldap/testrunner-wrong_credentials Diff File

master cbf53c44

2024-02-27 16:57

joergs


Committer: slederer

Ported: N/A

Details Diff
systemtests py3plug-fd-ldap: accept port number

Accept SYSTEMTEST_LDAP_ADDRESS with port number, like
SYSTEMTEST_LDAP_ADDRESS=127.0.0.1:389
mod - systemtests/tests/py3plug-fd-ldap/CMakeLists.txt Diff File
mod - systemtests/tests/py3plug-fd-ldap/etc/bareos/bareos-dir.d/fileset/PluginTest.conf.in Diff File
 First  Prev  1 2 3 ... 33 34 35 36 37 38 39 ... 60 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 600 ... 641 642 643  Next  Last