Changesets: bareos

Search Browse Back to Index

master b50ae922

2024-11-07 15:20

Sebastian Sura

Ported: N/A

Details Diff		 config-dump: update test to include HonorNoDumpFlag
mod - systemtests/tests/config-dump/etc/bareos/bareos-dir-full.conf.in Diff File

master 703ae865

2024-11-07 14:40

Sebastian Sura

Ported: N/A

Details Diff		 cats: remove unnecessary macros

The removed macros were just used to inject line information into the
db calls. As this can now just be done by using source_location we
can remove them and just use proper functions.
mod - core/src/cats/bvfs.cc Diff File
mod - core/src/cats/cats.h Diff File
mod - core/src/cats/postgresql.cc Diff File
mod - core/src/cats/sql.cc Diff File
mod - core/src/cats/sql_create.cc Diff File
mod - core/src/cats/sql_delete.cc Diff File
mod - core/src/cats/sql_find.cc Diff File
mod - core/src/cats/sql_get.cc Diff File
mod - core/src/cats/sql_list.cc Diff File
mod - core/src/cats/sql_update.cc Diff File

master 6e18f924

2024-11-07 14:39

Sebastian Sura

Ported: N/A

Details Diff		 cats: enhance dblocker by adding line info

We used to supply LockDb/UnlockDb with pretty useless line numbers as
they were always the same regardless of which DbLocker it actually
was. Now we use the line information of the creation of the DbLocker.
mod - core/src/cats/cats.h Diff File

master c87856c9

2024-11-07 14:37

Sebastian Sura

Ported: N/A

Details Diff		 rwlock: enhance debugability

Now we get some line numbers in the assertion which should help us
figuring out the problem in case no backtrace is available.
mod - core/src/cats/cats.h Diff File
mod - core/src/lib/rwlock.cc Diff File
mod - core/src/lib/rwlock.h Diff File

master 2554379f

2024-11-07 14:23

bruno-at-bareos


Committer: Bareos Bot

Ported: N/A

Details Diff		 cmake: use VERSION_GREATER_EQUAL PG version 10

Our plugin is able to work with PostgreSQL 10.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
mod - systemtests/tests/py3plug-fd-postgresql/CMakeLists.txt Diff File

master 7ad95450

2024-11-07 13:36

Sebastian Sura

Ported: N/A

Details Diff		 wrap-test: fix missing <memory> include
mod - core/src/tests/wrap.cc Diff File

master bae62f42

2024-11-07 10:40

Sebastian Sura

Ported: N/A

Details Diff		 lib: add source_location polyfill
mod - core/cmake/BareosCheckFunctions.cmake Diff File
mod - core/src/include/config.h.in Diff File
add - core/src/lib/source_location.h Diff File
mod - core/src/win32/compat/include/mingwconfig.h Diff File

master ed1af63f

2024-11-07 09:22

Sebastian Sura

Ported: N/A

Details Diff		 sql: remove bad assertion

This function is only called when everything is stopped, so we should
not assert that we are the owner here ...
mod - core/src/cats/sql.cc Diff File

master 1d8529a3

2024-11-07 08:21

Sebastian Sura

Ported: N/A

Details Diff		 msgchan: make crash less likely

Behind the curtains pthread_cleanup_pop is a destructor and
pthread_cancel causes an exception (via a signal).

This means that if you try to cancel a job while that job is in the
process of ending, then you risk an unfixable crash. We want to make
this less likely and move the CleanupCall outside the destructor.

Note that this is just bandaid and not a real fix. There are still
multiple other destructors and pthread_cleanup_calls inside the call
stack, so this can always cause a crash.

The only way to prevent these crashes (even if they are very unlikely)
is to rewrite everything to not rely on pthread_cancel and instead use
some other mechanism for cancelation. This is very hard as we also
have to be able to cancel stuff like write/read/sleep/etc.

We would have to rewrite them with non blocking alternatives to have a
chance of achieving this (or by using the TIMEOUT signal, but that has
other issues ~> signal (un)safety).
mod - core/src/dird/msgchan.cc Diff File

master 0901b6f6

2024-11-06 15:34

bruno-at-bareos


Committer: Bareos Bot

Ported: N/A

Details Diff		 plugins: postgresql add support for version 17

- add support for PostgreSQL version 17, we now use dedicated
function pg_walfile_name_offset to retrieve filename and
check if offset is 0.
- database_local: set checkpoint timeout lower.
- add support for nanosecond integer resolution.
+ use ns in self.last_backup_stop_time as datetime object
are not serializable.
+ use ns for start_backup_time and remove datetime usage
for file comparison.
+ this support allow the plugin to not backup each time the
latest wal file.
- add fix for pg8000 < 1.30 returning a string instead tuple
with pg_walfile_name_offset.
- add a check if ROP last_time_backup is large enough
or convert it to ns (ease plugin version migration).
- remove unused modules datetime dateutil.
- use constant for `NANOSECONDS_PER_SECOND` and
`LAST_BACKUP_TIME_WITH_SECONDS`
- limit if/else block by using global functions current_time_ns()
- add comment about time.time_ns() when to remove it (python 3.7 eol)
- use directly os.stat().st_mtime_ns it has been introduced in
python 3.3 and we don't support python <= 3.6.
- add comment about checkpoint_timeout parameter in setup-local-db.
- use stat_obj instead of stat to avoid keyword redefining.
- improve docstring for __decode_lsn_filename_offset which return
True.
- remove unused lsn parameter from __wait_for_wal_archiving.
- add debug message when LAST_BACKUP_TIME_WITH_SECONDS is hit.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
mod - core/src/plugins/filed/python/postgresql/bareos-fd-postgresql.py Diff File
mod - systemtests/tests/py3plug-fd-postgresql/database/setup_local_db.sh Diff File

master 758e1646

2024-11-06 15:15

Sebastian Sura

Ported: N/A

Details Diff		 postgresql: fix race condition on connection

We should never use db_handle_ without ensuring that the db is
locked (which infact is not the case here).
mod - core/src/cats/postgresql.cc Diff File

master 5c27c961

2024-11-06 12:23

Bareos Bot


Committer: GitHub

Ported: N/A

Details Diff		 Merge pull request #1992

stored: fix volume size mismatch
mod - CHANGELOG.md Diff File
mod - core/src/include/version_hex.h Diff File
mod - core/src/plugins/filed/python/python-fd.cc Diff File
mod - core/src/stored/mount.cc Diff File

master 9862c250

2024-11-06 12:23

Bareos Bot

Ported: N/A

Details Diff		 Update CHANGELOG.md
mod - CHANGELOG.md Diff File

master f1b2358f

2024-11-06 10:43

Sebastian Sura

Ported: N/A

Details Diff		 restore: remove double cancel

NativeRestoreCleanup is already done on error in job_thread (job.cc)
in case an error occured, so there is no need to do it twice.

This may cause a crash because pthread_cancel and C++ dont mix well,
especially if we cancel the same thread in a short time interval.
(pthread_cancel causes an exception + destructor calling, which may
lead to an exception being caused inside a destructor, leading to a
crash.)
mod - core/src/dird/restore.cc Diff File

master 9fc3ae5d

2024-11-05 14:44

Sebastian Sura


Committer: Bareos Bot

Ported: N/A

Details Diff		 python-fd: fix version hex

Our python version hex was not correct for numbers >= 10. We
previously emitted e.g. 0x03100000 for 3.10, when its supposed to be
0x030A0000.

This was causing weird crashes because workarounds for old versions
that were not supposed to be enabled for newer versions were in fact
enabled.
mod - core/src/include/version_hex.h Diff File
mod - core/src/plugins/filed/python/python-fd.cc Diff File

master bdd7d0ed

2024-11-05 14:43

Sebastian Sura


Committer: arogge

Ported: N/A

Details Diff		 unit-tests: add testing for bpipe environment handling
mod - core/src/include/baconfig.h Diff File
mod - core/src/tests/CMakeLists.txt Diff File
add - core/src/tests/bpipe_env_test.cc Diff File
add - core/src/tests/bpipe_env_test.h Diff File
add - core/src/tests/env_tester.cc Diff File

master f721e1a6

2024-11-05 09:44

Sebastian Sura


Committer: arogge

Ported: N/A

Details Diff		 bpipe-win32: add support for custom environment variables
mod - core/src/lib/bpipe_win32.cc Diff File

master 418fe219

2024-11-05 09:34

Bareos Bot


Committer: GitHub

Ported: N/A

Details Diff		 Merge pull request #1998

docs: add debian howto start daemons instructions
mod - CHANGELOG.md Diff File
mod - docs/manuals/source/IntroductionAndTutorial/InstallingBareos.rst Diff File
mod - docs/manuals/source/IntroductionAndTutorial/Tutorial.rst Diff File

master 1c9410e4

2024-11-05 09:34

Bareos Bot

Ported: N/A

Details Diff		 Update CHANGELOG.md
mod - CHANGELOG.md Diff File

master ecd9a21b

2024-11-04 09:25

pstorz


Committer: Bareos Bot

Ported: N/A

Details Diff		 core/CMakeLists.txt: also search in SOURCES on F41

On Fedora 41, the new rpmbuild creates a subdirectory for building.
mod - core/CMakeLists.txt Diff File

master 502f4d03

2024-10-31 14:58

arogge

Ported: N/A

Details Diff		 systemtests: fix localfile-wrapper.sh for dplcompat

use `stat -f %z` instead of `stat --format=%s` on FreeBSD.
mod - systemtests/tests/dplcompat/etc/bareos/localfile-wrapper.sh Diff File

master d3234528

2024-10-31 14:05

bruno-at-bareos

Ported: N/A

Details Diff		 docs: add debian howto start daemons instructions

docs: extend tuturial about how to start the daemons
The name of the services differs depending in the distribution.

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Co-authored-by: Jörg Steffens <joergsteffens@users.noreply.github.com>
mod - docs/manuals/source/IntroductionAndTutorial/InstallingBareos.rst Diff File
mod - docs/manuals/source/IntroductionAndTutorial/Tutorial.rst Diff File

master a334b1dc

2024-10-31 13:35

pstorz


Committer: Bareos Bot

Ported: N/A

Details Diff		 pkglists: remove F38+39, add F41
rm - docs/pkglists/Fedora_39.x86_64 Diff File

master ad8733b5

2024-10-31 13:03

pstorz


Committer: Bareos Bot

Ported: N/A

Details Diff		 matrix: remove F38+39, add and switch to F41
mod - .matrix.yml Diff File

master 559a8e5c

2024-10-31 13:01

pstorz


Committer: Bareos Bot

Ported: N/A

Details Diff		 xattr.cc: check for nullptr before dereferencing

This prevents a crash in test bextract-autoxflate
on fedora 41
mod - core/src/findlib/xattr.cc Diff File
 First  Prev  1 2 3 ... 26 27 28 29 30 31 32 ... 70 ... 140 ... 210 ... 280 ... 350 ... 420 ... 490 ... 560 ... 630 ... 671 672 673  Next  Last