Changesets: bareos

Search Browse Back to Index

master ed5f1bef

2014-10-05 18:46

Marco van Wieringen

Ported: N/A

Details Diff		 Ditch useless unions in dird config.

In essence they save a maximum of one pointer value which is not worth
the side effect it has for printing a config data. To be able to
determine what data is actual in the union you need an extra variable
describing what is the pointer about so then there is little value left
in using an union.
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File

master dd9180e3

2014-10-05 17:41

Marco van Wieringen

Ported: N/A

Details Diff		 Tweak debug output.
mod - src/lib/res.c Diff File

master 1001bfc8

2014-10-05 16:46

mvwieringen

Ported: N/A

Details Diff		 Ditch useless unions in dird config.

In essence they save a maximum of one pointer value which is not worth
the side effect it has for printing a config data. To be able to
determine what data is actual in the union you need an extra variable
describing what is the pointer about so then there is little value left
in using an union.
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File

bareos-14.2 f13bcff8

2014-10-05 16:46

Marco van Wieringen

Ported: N/A

Details Diff		 Ditch useless unions in dird config.

In essence they save a maximum of one pointer value which is not worth
the side effect it has for printing a config data. To be able to
determine what data is actual in the union you need an extra variable
describing what is the pointer about so then there is little value left
in using an union.
mod - src/dird/dird_conf.c Diff File
mod - src/dird/dird_conf.h Diff File

master 62be21e7

2014-10-05 15:41

mvwieringen

Ported: N/A

Details Diff		 Tweak debug output.
mod - src/lib/res.c Diff File

bareos-14.2 e01afed3

2014-10-05 15:41

Marco van Wieringen

Ported: N/A

Details Diff		 Tweak debug output.
mod - src/lib/res.c Diff File

master 5374f09e

2014-10-05 13:45

Marco van Wieringen

Ported: N/A

Details Diff		 Print config should suppress data from JobDefs

Some specific config items in the Job resource could be coming from a
JobDef so we should not print those values in the actual Job resource.

We add a new bitmap analog to item_present bitmap already existing in
the RES class. When we mark that bit when we populate the jobdef in the
populate_jobdefs() function in src/dird/dird_conf.c we can check this
bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes)

We also use the same bitmap for defaults so we can use some shortcut
logic when printing the config as we then know that the default was
set and never replaced by an other setting. We clear the bit in all
other parse functions so we know the default is cleared. If the default
is replaced with the same value as the original default that is still
detected. Only real exception is when omit defaults is set to true
then we just like before always print the defaults (but not the data
populated from a JobDef.)

Fixes 0000343: Print config should suppress data from JobDefs
mod - src/dird/dird_conf.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/dird/run_conf.c Diff File
mod - src/filed/filed_conf.c Diff File
mod - src/lib/parse_conf.c Diff File
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File
mod - src/stored/stored_conf.c Diff File

master 6822b3ba

2014-10-05 11:45

mvwieringen

Ported: N/A

Details Diff		 Print config should suppress data from JobDefs

Some specific config items in the Job resource could be coming from a
JobDef so we should not print those values in the actual Job resource.

We add a new bitmap analog to item_present bitmap already existing in
the RES class. When we mark that bit when we populate the jobdef in the
populate_jobdefs() function in src/dird/dird_conf.c we can check this
bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes)

We also use the same bitmap for defaults so we can use some shortcut
logic when printing the config as we then know that the default was
set and never replaced by an other setting. We clear the bit in all
other parse functions so we know the default is cleared. If the default
is replaced with the same value as the original default that is still
detected. Only real exception is when omit defaults is set to true
then we just like before always print the defaults (but not the data
populated from a JobDef.)

Fixes 0000343: Print config should suppress data from JobDefs		 Affected Issues
0000343
mod - src/dird/dird_conf.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/dird/run_conf.c Diff File
mod - src/filed/filed_conf.c Diff File
mod - src/lib/parse_conf.c Diff File
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File
mod - src/stored/stored_conf.c Diff File

bareos-14.2 0af0d4c4

2014-10-05 11:45

Marco van Wieringen

Ported: N/A

Details Diff		 Print config should suppress data from JobDefs

Some specific config items in the Job resource could be coming from a
JobDef so we should not print those values in the actual Job resource.

We add a new bitmap analog to item_present bitmap already existing in
the RES class. When we mark that bit when we populate the jobdef in the
populate_jobdefs() function in src/dird/dird_conf.c we can check this
bit in the printing function. (Overhead is currently 80 / 8 = 10 bytes)

We also use the same bitmap for defaults so we can use some shortcut
logic when printing the config as we then know that the default was
set and never replaced by an other setting. We clear the bit in all
other parse functions so we know the default is cleared. If the default
is replaced with the same value as the original default that is still
detected. Only real exception is when omit defaults is set to true
then we just like before always print the defaults (but not the data
populated from a JobDef.)

Fixes 0000343: Print config should suppress data from JobDefs
mod - src/dird/dird_conf.c Diff File
mod - src/dird/inc_conf.c Diff File
mod - src/dird/run_conf.c Diff File
mod - src/filed/filed_conf.c Diff File
mod - src/lib/parse_conf.c Diff File
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File
mod - src/stored/stored_conf.c Diff File

master f5d05f93

2014-10-03 23:52

Marco van Wieringen

Ported: N/A

Details Diff		 First attempt to move python-sd plugin to use plugin options.
mod - src/plugins/stored/bareos-sd.py.template Diff File
mod - src/plugins/stored/bareos_sd_consts.py Diff File
mod - src/plugins/stored/python-sd.c Diff File
mod - src/plugins/stored/python-sd.h Diff File

master f7fdf847

2014-10-03 21:52

mvwieringen

Ported: N/A

Details Diff		 First attempt to move python-sd plugin to use plugin options.
mod - src/plugins/stored/bareos-sd.py.template Diff File
mod - src/plugins/stored/bareos_sd_consts.py Diff File
mod - src/plugins/stored/python-sd.c Diff File
mod - src/plugins/stored/python-sd.h Diff File

bareos-14.2 e79950d3

2014-10-03 21:52

Marco van Wieringen

Ported: N/A

Details Diff		 First attempt to move python-sd plugin to use plugin options.
mod - src/plugins/stored/bareos-sd.py.template Diff File
mod - src/plugins/stored/bareos_sd_consts.py Diff File
mod - src/plugins/stored/python-sd.c Diff File
mod - src/plugins/stored/python-sd.h Diff File

master ae49552a

2014-10-03 18:12

Marco van Wieringen

Ported: N/A

Details Diff		 Fix SD_NR_EVENTS.
mod - src/stored/sd_plugins.h Diff File

master ad18050b

2014-10-03 16:12

mvwieringen

Ported: N/A

Details Diff		 Fix SD_NR_EVENTS.
mod - src/stored/sd_plugins.h Diff File

bareos-14.2 853adec8

2014-10-03 16:12

Marco van Wieringen

Ported: N/A

Details Diff		 Fix SD_NR_EVENTS.
mod - src/stored/sd_plugins.h Diff File

master 77326aa5

2014-10-02 12:02

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff		 Fix coverity detected defects
mod - src/plugins/stored/autoxflate-sd.c Diff File

master 6b78bea9

2014-10-02 10:02

pstorz

Ported: N/A

Details Diff		 Fix coverity detected defects
mod - src/plugins/stored/autoxflate-sd.c Diff File

bareos-14.2 2cc58430

2014-10-02 10:02

Philipp Storz


Committer: Marco van Wieringen

Ported: N/A

Details Diff		 Fix coverity detected defects
mod - src/plugins/stored/autoxflate-sd.c Diff File

master 823ad90d

2014-10-01 22:12

Marco van Wieringen

Ported: N/A

Details Diff		 First attempt to move python-dir plugin to use plugin options.
mod - src/plugins/dird/bareos-dir.py.template Diff File
mod - src/plugins/dird/bareos_dir_consts.py Diff File
mod - src/plugins/dird/python-dir.c Diff File
mod - src/plugins/dird/python-dir.h Diff File
mod - src/plugins/filed/bareos-fd.py.template Diff File

master a3f175b7

2014-10-01 20:12

mvwieringen

Ported: N/A

Details Diff		 First attempt to move python-dir plugin to use plugin options.
mod - src/plugins/dird/bareos-dir.py.template Diff File
mod - src/plugins/dird/bareos_dir_consts.py Diff File
mod - src/plugins/dird/python-dir.c Diff File
mod - src/plugins/dird/python-dir.h Diff File
mod - src/plugins/filed/bareos-fd.py.template Diff File

bareos-14.2 827a8fc4

2014-10-01 20:12

Marco van Wieringen

Ported: N/A

Details Diff		 First attempt to move python-dir plugin to use plugin options.
mod - src/plugins/dird/bareos-dir.py.template Diff File
mod - src/plugins/dird/bareos_dir_consts.py Diff File
mod - src/plugins/dird/python-dir.c Diff File
mod - src/plugins/dird/python-dir.h Diff File
mod - src/plugins/filed/bareos-fd.py.template Diff File

master d7753340

2014-09-30 18:01

Marco van Wieringen

Ported: N/A

Details Diff		 Fix compiler warning.
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File

master c87484ef

2014-09-30 16:01

mvwieringen

Ported: N/A

Details Diff		 Fix compiler warning.
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File

bareos-14.2 af3d7c82

2014-09-30 16:01

Marco van Wieringen

Ported: N/A

Details Diff		 Fix compiler warning.
mod - src/lib/parse_conf.h Diff File
mod - src/lib/res.c Diff File

bareos-14.2 13392251

2014-09-30 15:05

pstorz

Ported: N/A

Details Diff		 Revert "Backport some obvious fixes for the core from Bacula 7."

This reverts commit 56560ce54e594c6bdd33c6f0fcc6210a96d6811c.
mod - src/console/console.c Diff File
mod - src/dird/fd_cmds.c Diff File
mod - src/filed/dir_cmd.c Diff File
mod - src/filed/heartbeat.c Diff File
mod - src/lib/address_conf.c Diff File
mod - src/lib/berrno.c Diff File
mod - src/lib/jcr.c Diff File
mod - src/lib/lex.c Diff File
mod - src/stored/bls.c Diff File
mod - src/stored/btape.c Diff File
mod - src/stored/dir_cmd.c Diff File
mod - src/stored/stored.c Diff File
 First  Prev  1 2 3 ... 60 ... 120 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 525 526 527 528 529 530 531 ... 540 ... 600 ... 608 609 610  Next  Last