Bareos Bug Tracker
Bareos Bug Tracker

View Issue Details Jump to Notes ] Related Changesets ] Issue History ] Print ]
IDProjectCategoryView StatusDate SubmittedLast Update
0000617bareos-core[All Projects] storage daemonpublic2016-02-10 19:562016-02-12 21:37
Reportermatt01 
Assigned Tomvwieringen 
PrioritynormalSeverityminorReproducibilityalways
StatusresolvedResolutionfixed 
PlatformLinuxOSanyOS Version3
Product Version15.2.2 
Target VersionFixed in Version 
Summary0000617: Add support for rados_striper functions in rados_device.c where it currently dosn't exist.
DescriptionNot all of the calls in rados_device.c will use their rados_striper alternatives if HAVE_RADOS_STRIPER is defined.

rados_striper functions need to be provided m_striper.
TagsNo tags attached.
bareos-master: impact
bareos-master: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action
Attached Filespatch file icon 0001-add-support-for-rados_striper-functions-in-rados_dev.patch [^] (4,039 bytes) 2016-02-10 19:56 [Show Content]

- Relationships

-  Notes
(0002189)
mvwieringen (developer)
2016-02-11 10:00

There are a couple of problems with this patch. Next to that I have some
other patches pending so I took the patch and tried merging the changes.
Problem with the striper stuff was that it was fully new when I added the
code and docs where nowhere to be found. So it was more a proof of concept
then anything that might work at all.
(0002190)
mvwieringen (developer)
2016-02-11 10:05

I pushed a temporary branch to github under https://github.com/bareos/bareos/commits/mvw/ceph-changes [^] which includes some more fixes. It may need some
work but is probably a better base to start fixing.
(0002191)
matt01 (reporter)
2016-02-11 11:07

Ok Thanks,

I agree there doesn't seem to be any documentation on the striper functions, Looking at the header files all of the functions appear to be the same as the non striper alternatives. Hopefully documentation will appear soon.

We will be looking at using ceph for backups here and striping is desirable so I plan on testing this heavily soon.

Matt
(0002192)
mvwieringen (developer)
2016-02-11 12:49

Yes CEPH is kind of sloppy with documenting their API they also changed
the write API in some version from returning the number of bytes and then
all of a sudden return true or false. When doing the rados_create2 interface
last week I run into something similar as it seems it existed before but
then only had 2 arguments nowadays 4 and you have to look in the git repo
when they changed it and then look forward in the commits to see when the
API version number gets bumped.

Honestly I have not to much interest in every possible storage platform
but when we started S3 I already found out quickly that the native APIs
of CEPH and Gluster are much better suited for the way we work then the
S3 api which you also can use on those platforms. Now that storage backends
are abstracted as part of cloud storage stuff we can easily plugin new ones.
But for most we are depended somewhat on end-users as keeping them all in shape
is not something that we can spend numerous hours on.

You might run into some problems with the branch I mentioned as some stuff
is based on the limited documentation available.
(0002194)
mvwieringen (developer)
2016-02-12 21:37

Fix committed to bareos master branch with changesetid 6132.

- Related Changesets
bareos: master 01c224cf
Timestamp: 2016-02-10 15:27:08
Author: mr245
Committer: mvwieringen
Ported: N/A
Details ] Diff ]
ceph: Add more support for rados_striper functions.

Fixes 0000617: Add support for rados_striper functions in rados_device.c
where it currently dosn't exist.

Signed-off-by: Marco van Wieringen <marco.van.wieringen@bareos.com>
mod - src/stored/backends/rados_device.c Diff ] File ]
mod - src/stored/backends/rados_device.h Diff ] File ]

- Issue History
Date Modified Username Field Change
2016-02-10 19:56 matt01 New Issue
2016-02-10 19:56 matt01 File Added: 0001-add-support-for-rados_striper-functions-in-rados_dev.patch
2016-02-11 10:00 mvwieringen Note Added: 0002189
2016-02-11 10:05 mvwieringen Note Added: 0002190
2016-02-11 10:06 mvwieringen Assigned To => mvwieringen
2016-02-11 10:06 mvwieringen Status new => feedback
2016-02-11 11:07 matt01 Note Added: 0002191
2016-02-11 11:07 matt01 Status feedback => assigned
2016-02-11 12:49 mvwieringen Note Added: 0002192
2016-02-11 12:50 mvwieringen Status assigned => feedback
2016-02-12 21:37 mvwieringen Changeset attached => bareos master 01c224cf
2016-02-12 21:37 mvwieringen Note Added: 0002194
2016-02-12 21:37 mvwieringen Status feedback => resolved
2016-02-12 21:37 mvwieringen Resolution open => fixed


Copyright © 2000 - 2018 MantisBT Team
Powered by Mantis Bugtracker