0000881: B_DB::escape_object truncates output string

ID	Project	Category	View Status	Date Submitted	Last Update

0000881	bareos-core	director	public	2017-12-06 20:36	2023-07-04 15:11

Reporter	cunio	Assigned To	bruno-at-bareos
Priority	normal	Severity	minor	Reproducibility	always
Status	closed	Resolution	won't fix
Platform	Linux	OS	Debian	OS Version	7
Product Version	16.2.4

Summary	0000881: B_DB::escape_object truncates output string
Description	In B_DB::escape_object function in cats/cats.c file bin_to_base64 is called with output buffer equal to encoded string but this function uses last byte for string termination Returned encoded string is truncated by one character. It produces truncated RestoreObject in database It breaks restore job with percona plugin
Tags	No tags attached.

joergs 2017-12-07 12:21 developer ~0002833	I've a quick look at the code, but didn't find an error. Can you give us more information? What database backend to you use?

cunio 2017-12-07 23:43 reporter ~0002835	I use sqlite (builtin) restore_object has size 141 bytes which gives 188 after base64 Only 187 bytes is stored in database Look at line 137 in lib/base64.c buflen is 188 from B_DB::db_escape_object in cats/cats.c After this line is 187 but result needs 188

bruno-at-bareos 2023-07-04 15:11 manager ~0005125	sqlite is no more used in recent version of code.

Date Modified	Username	Field	Change
2017-12-06 20:36	cunio	New Issue
2017-12-07 12:21	joergs	Note Added: 0002833
2017-12-07 12:21	joergs	Status	new => feedback
2017-12-07 23:43	cunio	Note Added: 0002835
2017-12-07 23:43	cunio	Status	feedback => new
2023-07-04 15:11	bruno-at-bareos	Assigned To	=> bruno-at-bareos
2023-07-04 15:11	bruno-at-bareos	Status	new => closed
2023-07-04 15:11	bruno-at-bareos	Resolution	open => won't fix
2023-07-04 15:11	bruno-at-bareos	Note Added: 0005125