View Issue Details

IDProjectCategoryView StatusLast Update
0001235bareos-core[All Projects] webuipublic2021-09-14 12:19
ReporterkabassanovAssigned Tofrank 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSDebianOS Version9
Product Version19.2.7 
Fixed in Version 
Summary0001235: Special characters not escaped in translations
DescriptionHi,

I observed erros in in some (at least one ) webpages generation, in presence of special characters in translation strings.

Here is an example:
module/Media/view/media/media/details.phtml: html.push('<th><?php echo $this->translate("Volume writes"); ?></th>');
with French translation containing ' . I customized translations a little bit, so I'm not sure the original translation of this one had this character, but it is a general issue.

Thanks.
Steps To ReproduceJust take a translation containing an apostrophe and observe that webpage is not completely displayed. In debug window you'll see:

      html.push('<th>Nombre d'√©critures sur le volume</th>');

where the apostrophe in "Nombre d'écritures" will be considered as push string end character.
TagsNo tags attached.
bareos-master: impact
bareos-master: action
bareos-19.2: impact
bareos-19.2: action
bareos-18.2: impact
bareos-18.2: action
bareos-17.2: impact
bareos-17.2: action
bareos-16.2: impact
bareos-16.2: action
bareos-15.2: impact
bareos-15.2: action
bareos-14.2: impact
bareos-14.2: action
bareos-13.2: impact
bareos-13.2: action
bareos-12.4: impact
bareos-12.4: action

Relationships

related to 0001384 closedarogge_adm Release Bareos 19.2.11 
related to 0001361 closedarogge Release Bareos 20.0.3 

Activities

frank

frank

2021-08-10 11:22

manager   ~0004208

Fix committed to bareos bareos-19.2 branch with changesetid 15101.

Related Changesets

bareos: bareos-19.2 3a563720

2021-07-13 09:51:49

gnieark


Committer: frank

Ported: N/A

Details Diff
webui: quote strings with slashes in media details view

(cherry picked from commit a3fd053f40760d175ca1d9dcfc8a352fc9bef6b8)

Fixes 0001235: Special characters not escaped in translations
Affected Issues
0001235
mod - webui/module/Media/view/media/media/details.phtml Diff File

bareos: bareos-19.2 680c9e74

2021-07-15 10:13:17

gnieark


Committer: frank

Ported: N/A

Details Diff
webui: quote strings with slashes in dashboards index view

Strings coming from "translate" function can contain apostrophes
that need to be escaped.

(cherry picked from commit 3c3e2272eb6a64235c801fde003ce3c18d05e4a6)

Fixes 0001235: Special characters not escaped in translations
Affected Issues
0001235
mod - webui/module/Dashboard/view/dashboard/dashboard/index.phtml Diff File

bareos: bareos-19.2 d29b16dc

2021-07-15 10:31:20

gnieark


Committer: frank

Ported: N/A

Details Diff
webui: quote strings with slashes in job index and details view

Strings coming from "translate" function can contain apostrophes
that need to be escaped.

(cherry picked from commit d72df730e8229b6c849eefac83f329fe204e71db)

Fixes 0001235: Special characters not escaped in translations
Affected Issues
0001235
mod - webui/module/Job/view/job/job/details.phtml Diff File
mod - webui/module/Job/view/job/job/index.phtml Diff File

bareos: bareos-19.2 77ae1e6a

2021-07-15 10:48:21

gnieark


Committer: frank

Ported: N/A

Details Diff
webui: quote strings with slashes in pool details view

Strings coming from "translate" function can contain apostrophes
that need to be escaped.

(cherry picked from commit 344a272f57666d94060eee24ae321d65540b3553)

Fixes 0001235: Special characters not escaped in translations
Affected Issues
0001235
mod - webui/module/Pool/view/pool/pool/details.phtml Diff File

Issue History

Date Modified Username Field Change
2020-04-26 18:43 kabassanov New Issue
2021-04-29 10:49 frank Assigned To => frank
2021-04-29 10:49 frank Status new => assigned
2021-07-15 17:31 frank Status assigned => confirmed
2021-08-10 11:22 frank Changeset attached => bareos bareos-19.2 3a563720
2021-08-10 11:22 frank Changeset attached => bareos bareos-19.2 680c9e74
2021-08-10 11:22 frank Changeset attached => bareos bareos-19.2 d29b16dc
2021-08-10 11:22 frank Changeset attached => bareos bareos-19.2 77ae1e6a
2021-08-10 11:22 frank Note Added: 0004208
2021-08-10 11:22 frank Status confirmed => resolved
2021-08-10 11:22 frank Resolution open => fixed
2021-09-14 10:53 arogge_adm Relationship added related to 0001384
2021-09-14 12:19 arogge_adm Relationship added related to 0001361