bareos: bareos-14.2 747d34cf

Author Committer Branch Timestamp Parent
mvwieringen mvwieringen bareos-14.2 2016-03-11 10:59 bareos-14.2 fab6eade Pending
Affected Issues  0000632: fd-bpipe plugin merges stderr with stdout, which can result in corrupted backups.
Changeset bpipe-fd: stderr is merged with stdout, possible corruption.

When changing from using popen() to open_bpipe() it was overlooked that
popen() just ignores stderr but open_bpipe() dups both stdout and stderr
onto the read pipe used. This patch adds a flag to open_bpipe() which is
by default set to true to dup stderr or not. For now this fixes the
problem but a better solution could probably be coded by adding an extra
member to the BPIPE class with the name efd which is the error handle
just as we now have a write and read handle.

Fixes 0000632: fd-bpipe plugin merges stderr with stdout, which can result
            in corrupted backups.
mod - src/lib/bpipe.c Diff File
mod - src/lib/protos.h Diff File
mod - src/plugins/filed/bpipe-fd.c Diff File