bareos: bareos-14.2 04ff7665
|mvwieringen||mvwieringen||bareos-14.2||2015-09-14 23:54||bareos-14.2 43f4a256||Pending|
|Affected Issues||0000446: bareos-dir segfault|
|Changeset||Rename silent flag to interactive.
- Lets call the silent flag of the cancel_storage_daemon_job() function
interactive which covers the actual meaning a bit better e.g. are we
doing an interactive cancel or not.
- When we are doing a non-interactive cancel we shouldn't kill the
thread as we are on the cancel path our self. There are some safeguards
in place that catch the thread id not being the same as pthread_self()
so we shouldn't be able to commit suicide but as we know we are in the
cancel path there is no need for all the trickery. For an interactive
cancel e.g. one invoked by the user an external thread is canceling so
we should let the actual Job thread that is doing the actual work know
things are being canceled.
Fixes 0000446: bareos-dir segfault
|mod - src/dird/protos.h||Diff File|
|mod - src/dird/sd_cmds.c||Diff File|