bareos: master 568102c8

Diff Back to Repository
Author Committer Branch Timestamp Parent
Sebastian Sura Bareos Bot master 2024-07-11 08:15 master ddf0be28 Pending
Changeset db: fix not locking the db to print its error

db->strerror() should only be called with the lock held unless the db
is private. 90% of the time db calls look like
```
if (!db->Function()) {
   Error(db->strerror());
}
```
In these cases we can need to lock the db during the if, otherwise we
could read stale info (or even run into a race condition as strerror
is unsynchronized).
mod - core/src/cats/postgresql.cc Diff File
mod - core/src/dird/admin.cc Diff File
mod - core/src/dird/archive.cc Diff File
mod - core/src/dird/backup.cc Diff File
mod - core/src/dird/bsr.cc Diff File
mod - core/src/dird/catreq.cc Diff File
mod - core/src/dird/check_catalog.cc Diff File
mod - core/src/dird/consolidate.cc Diff File
mod - core/src/dird/dbcheck.cc Diff File
mod - core/src/dird/dbcheck_utils.cc Diff File
mod - core/src/dird/fd_cmds.cc Diff File
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/migrate.cc Diff File
mod - core/src/dird/ndmp_dma_backup_NDMP_BAREOS.cc Diff File
mod - core/src/dird/ndmp_dma_backup_NDMP_NATIVE.cc Diff File
mod - core/src/dird/ndmp_dma_backup_common.cc Diff File
mod - core/src/dird/ndmp_dma_restore_NDMP_BAREOS.cc Diff File
mod - core/src/dird/ndmp_dma_restore_NDMP_NATIVE.cc Diff File
mod - core/src/dird/ndmp_fhdb_helpers.cc Diff File
mod - core/src/dird/ndmp_ndmmedia_db_helpers.cc Diff File
mod - core/src/dird/newvol.cc Diff File
mod - core/src/dird/next_vol.cc Diff File
mod - core/src/dird/quota.cc Diff File
mod - core/src/dird/restore.cc Diff File
mod - core/src/dird/ua_cmds.cc Diff File
mod - core/src/dird/ua_dotcmds.cc Diff File
mod - core/src/dird/ua_output.cc Diff File
mod - core/src/dird/ua_run.cc Diff File
mod - core/src/dird/vbackup.cc Diff File
mod - core/src/dird/verify.cc Diff File
mod - core/src/stored/bscan.cc Diff File