bareos: master 9d22ae2a

Diff Back to Repository
Author Committer Branch Timestamp Parent
arogge pstorz master 2022-11-08 18:09 master 95f1be87 Pending
Changeset core: distinct names for JobControlRecordPrivate

When we moved the daemon-specific functionality of the JobControlRecord
into JobControlRecordPrivate, we essentially introduced three different
types that were all named JobControlRecordPrivate - one for the
Director, one for the Storage Daemon and one for the File Daemon. This
could lead to ODR violations when you tried to link parts of the daemons
together.
In fact, that implementation already behaved like a union of the three
different types (i.e. requiring per-implementation initialisation and
teardown, undefined behaviour when accessing via the wrong type, etc.).

This patch renames the daemon's individual JobControlRecordPrivate to
DirectorJcrImpl, StoredJcrImpl and FiledJcrImpl. The impl-pointer was
changed to a union of dir_impl, sd_impl and fd_impl.
With this change applied you can now build programs that use two or more
of the JCR types.
mod - core/src/dird/admin.cc Diff File
mod - core/src/dird/archive.cc Diff File
mod - core/src/dird/authenticate.cc Diff File
mod - core/src/dird/autoprune.cc Diff File
mod - core/src/dird/backup.cc Diff File
mod - core/src/dird/bsr.cc Diff File
mod - core/src/dird/catreq.cc Diff File
mod - core/src/dird/consolidate.cc Diff File
mod - core/src/dird/dbcopy/database_connection.h Diff File
mod - core/src/dird/dbcopy/dbcopy.cc Diff File
mod - core/src/dird/dir_plugins.cc Diff File
mod - core/src/dird/dird_conf.cc Diff File
mod - core/src/dird/expand.cc Diff File
mod - core/src/dird/fd_cmds.cc Diff File
mod - core/src/dird/get_database_connection.cc Diff File
mod - core/src/dird/getmsg.cc Diff File
mod - core/src/dird/inc_conf.cc Diff File
mod - core/src/dird/jcr_util.cc Diff File
mod - core/src/dird/jcr_util.h Diff File
mod - core/src/dird/job.cc Diff File
mod - core/src/dird/jobq.cc Diff File
mod - core/src/dird/migrate.cc Diff File
mod - core/src/dird/msgchan.cc Diff File
mod - core/src/dird/ndmp_dma_backup_NDMP_BAREOS.cc Diff File
mod - core/src/dird/ndmp_dma_backup_NDMP_NATIVE.cc Diff File
mod - core/src/dird/ndmp_dma_backup_common.cc Diff File
mod - core/src/dird/ndmp_dma_generic.cc Diff File
mod - core/src/dird/ndmp_dma_restore_NDMP_BAREOS.cc Diff File
mod - core/src/dird/ndmp_dma_restore_NDMP_NATIVE.cc Diff File
mod - core/src/dird/ndmp_dma_restore_common.cc Diff File
mod - core/src/dird/ndmp_dma_storage.cc Diff File
mod - core/src/dird/newvol.cc Diff File
mod - core/src/dird/next_vol.cc Diff File
mod - core/src/dird/quota.cc Diff File
mod - core/src/dird/recycle.cc Diff File
mod - core/src/dird/restore.cc Diff File
mod - core/src/dird/run_on_incoming_connect_interval.cc Diff File
mod - core/src/dird/scheduler.cc Diff File
mod - core/src/dird/scheduler_private.cc Diff File
mod - core/src/dird/sd_cmds.cc Diff File
mod - core/src/dird/stats.cc Diff File
mod - core/src/dird/storage.cc Diff File
mod - core/src/dird/testfind.cc Diff File
mod - core/src/dird/ua_cmds.cc Diff File
mod - core/src/dird/ua_db.cc Diff File
mod - core/src/dird/ua_dotcmds.cc Diff File
mod - core/src/dird/ua_label.cc Diff File
mod - core/src/dird/ua_output.cc Diff File
mod - core/src/dird/ua_purge.cc Diff File
mod - core/src/dird/ua_restore.cc Diff File
mod - core/src/dird/ua_run.cc Diff File
mod - core/src/dird/ua_select.cc Diff File
mod - core/src/dird/ua_server.cc Diff File
mod - core/src/dird/ua_status.cc Diff File
mod - core/src/dird/ua_update.cc Diff File
mod - core/src/dird/vbackup.cc Diff File
mod - core/src/dird/verify.cc Diff File
mod - core/src/filed/accurate.cc Diff File
mod - core/src/filed/authenticate.cc Diff File
mod - core/src/filed/backup.cc Diff File
mod - core/src/filed/compression.cc Diff File
mod - core/src/filed/crypto.cc Diff File
mod - core/src/filed/dir_cmd.cc Diff File
mod - core/src/filed/estimate.cc Diff File
mod - core/src/filed/evaluate_job_command.cc Diff File
mod - core/src/filed/fd_plugins.cc Diff File
mod - core/src/filed/filed.cc Diff File
mod - core/src/filed/fileset.cc Diff File
mod - core/src/filed/heartbeat.cc Diff File
mod - core/src/filed/restore.cc Diff File
mod - core/src/filed/sd_cmds.cc Diff File
mod - core/src/filed/status.cc Diff File
mod - core/src/filed/verify.cc Diff File
mod - core/src/filed/verify_vol.cc Diff File
mod - core/src/include/jcr.h Diff File
mod - core/src/plugins/stored/scsicrypto/scsicrypto-sd.cc Diff File
mod - core/src/stored/acquire.cc Diff File
mod - core/src/stored/append.cc Diff File
mod - core/src/stored/authenticate.cc Diff File
mod - core/src/stored/bcopy.cc Diff File
mod - core/src/stored/bextract.cc Diff File
mod - core/src/stored/bls.cc Diff File
mod - core/src/stored/bscan.cc Diff File
mod - core/src/stored/bsr.cc Diff File
mod - core/src/stored/btape.cc Diff File
mod - core/src/stored/butil.cc Diff File
mod - core/src/stored/dev.cc Diff File
mod - core/src/stored/device.cc Diff File
mod - core/src/stored/dir_cmd.cc Diff File
mod - core/src/stored/fd_cmds.cc Diff File
mod - core/src/stored/job.cc Diff File
mod - core/src/stored/label.cc Diff File
mod - core/src/stored/mac.cc Diff File
mod - core/src/stored/mount.cc Diff File
mod - core/src/stored/ndmp_tape.cc Diff File
mod - core/src/stored/read.cc Diff File
mod - core/src/stored/read_record.cc Diff File
mod - core/src/stored/record.cc Diff File