bareos: bareos-18.2 d0d1ccb9

Author Committer Branch Timestamp Parent
franku franku bareos-18.2 2018-10-08 16:27 bareos-18.2 75949f13 Pending
Changeset dird: refactored sd_cmds.cc due to failed tls_duplicate_job_test

- ConnectToStorageDaemon is now the only function deletes the
  BareosSocket for the storage daemon upon failure during handshake
  using a std::unique_ptr
- all other functions now use TerminateAndCloseJcrStoreSocket to shutdown
  a socket on errors that happen after the connection has been established
- the function call to AuthenticateWithStorageDaemon has now the
  BareosSocket* as argument, not the hidden jcr->store_bsock, that
  could be altered in this function

- replaced NULL with nullptr
- removed obvious comments
- renamed a function name to match its purpose
mod - core/src/dird/authenticate.cc Diff File
mod - core/src/dird/authenticate.h Diff File
mod - core/src/dird/msgchan.cc Diff File
mod - core/src/dird/sd_cmds.cc Diff File
mod - core/src/dird/sd_cmds.h Diff File