Changesets: bareos

master d2cde678

2022-01-31 15:13

Andreas Rogge

Ported: N/A

Details Diff
dird: fix call on null object

if jcr->batch_started == false, then also jcr->db_batch == NULL.
Therefore we should not call jcr->db_batch->WriteBatchFileRecords(), as
it would call the method on the NULL object (which might be perfectly
safe in this specific case, but is undefined behaviour).
mod - core/src/dird/backup.cc Diff File

master 59fd6feb

2022-01-31 14:54

Andreas Rogge

Ported: N/A

Details Diff
lib: only unlink() when we have a pidfile
mod - core/src/lib/bsys.cc Diff File

master a85f7f2d

2022-01-31 14:54

Andreas Rogge

Ported: N/A

Details Diff
lib: fix off-by-one error in edit_pthread()
mod - core/src/lib/edit.cc Diff File

master f54a490a

2022-01-31 14:06

pstorz


Committer: arogge

Ported: N/A

Details Diff
ndmp_tape: cleanup
mod - core/src/stored/ndmp_tape.cc Diff File

master 6099ca5d

2022-01-31 14:01

pstorz


Committer: arogge

Ported: N/A

Details Diff
ndmp_tape.cc: add message how device needs to be setup in error message
mod - core/src/stored/ndmp_tape.cc Diff File

master 5b22a99a

2022-01-31 13:04

pstorz


Committer: arogge

Ported: N/A

Details Diff
ndmp_tape.cc: use ok variable
mod - core/src/stored/ndmp_tape.cc Diff File

master eec82800

2022-01-28 18:04

Andreas Rogge

Ported: N/A

Details Diff
lib: remove pointer-artihmetic from hlist<>

Previously hlist<> got two pointers on construction that were used to
determine the offset of T::link at runtime. As this is now done at
compile-time, the pointer-arithmetic is not needed anymore and
construction doesn't need the pointers anymore.
This patch removes the pointers, finally removing the undefined
behaviour from hlist.
mod - core/src/cats/bvfs.cc Diff File
mod - core/src/dird/ndmp_fhdb_mem.cc Diff File
mod - core/src/filed/accurate_htable.cc Diff File
mod - core/src/findlib/hardlink.cc Diff File
mod - core/src/lib/htable.cc Diff File
mod - core/src/lib/htable.h Diff File
mod - core/src/lib/path_list.cc Diff File
mod - core/src/lib/tree.cc Diff File
mod - core/src/tests/htable_test.cc Diff File

master 4e68f7db

2022-01-28 17:49

Andreas Rogge

Ported: N/A

Details Diff
lib: make htable buffersize a template parameter

Previously you could name the number of pages you wanted htable to
allocate per BigBuf when calling the constructor. This can now be
selected as small/medium/large as a template parameter. As before the
default is large to provide best performance, but also produce maximum
overhead.
mod - core/src/dird/ndmp_fhdb_mem.cc Diff File
mod - core/src/findlib/find.h Diff File
mod - core/src/findlib/hardlink.cc Diff File
mod - core/src/lib/htable.h Diff File
mod - core/src/lib/tree.cc Diff File
mod - core/src/lib/tree.h Diff File

master d0e6d57c

2022-01-28 17:22

Alaa Eddine Elamri

Ported: N/A

Details Diff
applying `bareos-check-sources`
mod - core/src/dird/stats.cc Diff File
mod - core/src/dird/stats.h Diff File
mod - core/src/stored/sd_stats.cc Diff File
mod - core/src/stored/sd_stats.h Diff File
mod - core/src/stored/stored_conf.cc Diff File
mod - core/src/tests/CMakeLists.txt Diff File
mod - core/src/tests/addresses_and_ports.cc Diff File
mod - core/src/tests/bsock_test_connection_setup.cc Diff File
mod - core/src/tests/dir_statistics_thread.cc Diff File
mod - core/src/tests/sd_statistics_thread.cc Diff File
mod - core/src/tests/testing_common.h Diff File
mod - core/src/tests/testing_dir_common.cc Diff File
mod - core/src/tests/testing_dir_common.h Diff File
mod - core/src/tests/testing_sd_common.cc Diff File
mod - core/src/tests/testing_sd_common.h Diff File

master a27e023f

2022-01-28 17:21

Andreas Rogge

Ported: N/A

Details Diff
lib: refactor htable and htableImpl

* remove parameter nr_entries that is not used by any caller
* extract calculation of loffset out of htableImpl::init()
* delay allocation of BigBuf to first call of hash_malloc()
* require second initialization pointer to be of type hlink*
mod - core/src/lib/htable.cc Diff File
mod - core/src/lib/htable.h Diff File

master 21d42038

2022-01-28 15:25

Alaa Eddine Elamri

Ported: N/A

Details Diff
dird: stored: error messages when statistics thread is not started
mod - core/src/dird/stats.cc Diff File
mod - core/src/stored/sd_stats.cc Diff File

master 25aef1e6

2022-01-28 15:23

Alaa Eddine Elamri

Ported: N/A

Details Diff
systemtest: preparing test for sd statistics thread
mod - core/src/tests/CMakeLists.txt Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/default_config/bareos-sd.d/device/tape1.conf Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/default_config/bareos-sd.d/storage/myself.conf Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/only_collect_set/bareos-sd.d/device/tape1.conf Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/only_collect_set/bareos-sd.d/storage/myself.conf Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/only_interval_set/bareos-sd.d/device/tape1.conf Diff File
add - core/src/tests/configs/statistics_thread/sd_statistics_thread/only_interval_set/bareos-sd.d/storage/myself.conf Diff File
add - core/src/tests/sd_statistics_thread.cc Diff File
add - core/src/tests/testing_sd_common.cc Diff File
add - core/src/tests/testing_sd_common.h Diff File

master d71cbfbc

2022-01-28 15:23

Alaa Eddine Elamri

Ported: N/A

Details Diff
stored: modify default statistics collection interval value
mod - core/src/stored/sd_stats.cc Diff File
mod - core/src/stored/sd_stats.h Diff File
mod - core/src/stored/stored_conf.cc Diff File

master 2b28641e

2022-01-28 15:21

Alaa Eddine Elamri

Ported: N/A

Details Diff
systemtest: modify director test config paths
mod - core/src/tests/dir_statistics_thread.cc Diff File

master 87d1f026

2022-01-28 15:11

Alaa Eddine Elamri

Ported: N/A

Details Diff
testing: avoiding duplication of common testing tools

also refactoring addresses and ports test
mod - core/src/tests/CMakeLists.txt Diff File
mod - core/src/tests/addresses_and_ports.cc Diff File
mod - core/src/tests/bsock_test_connection_setup.cc Diff File
mod - core/src/tests/dir_statistics_thread.cc Diff File
add - core/src/tests/testing_common.h Diff File
add - core/src/tests/testing_dir_common.cc Diff File
add - core/src/tests/testing_dir_common.h Diff File

master 5a5e1f30

2022-01-28 15:10

Alaa Eddine Elamri

Ported: N/A

Details Diff
gtest: creating test for statistics_thread
mod - core/src/tests/CMakeLists.txt Diff File
add - core/src/tests/configs/statistics_thread/default_config/bareos-dir.d/director/bareos-dir.conf Diff File
add - core/src/tests/configs/statistics_thread/default_config/bareos-dir.d/storage/File.conf Diff File
add - core/src/tests/configs/statistics_thread/only_collect_set/bareos-dir.d/director/bareos-dir.conf Diff File
add - core/src/tests/configs/statistics_thread/only_collect_set/bareos-dir.d/storage/File.conf Diff File
add - core/src/tests/configs/statistics_thread/only_interval_set/bareos-dir.d/director/bareos-dir.conf Diff File
add - core/src/tests/configs/statistics_thread/only_interval_set/bareos-dir.d/storage/File.conf Diff File
add - core/src/tests/dir_statistics_thread.cc Diff File

master 8398ea96

2022-01-28 15:07

Alaa Eddine Elamri

Ported: N/A

Details Diff
dir: don't start stats thread when no storage asks for it
mod - core/src/dird/stats.cc Diff File
mod - core/src/dird/stats.h Diff File

master 4b291648

2022-01-28 14:21

Andreas Rogge

Ported: N/A

Details Diff
lib: make htable into typesafe htable<Key,T>
mod - core/src/cats/bvfs.cc Diff File
mod - core/src/dird/ndmp_fhdb_mem.cc Diff File
mod - core/src/filed/accurate.h Diff File
mod - core/src/filed/accurate_htable.cc Diff File
mod - core/src/findlib/find.h Diff File
mod - core/src/findlib/hardlink.cc Diff File
mod - core/src/include/jcr.h Diff File
mod - core/src/lib/htable.h Diff File
mod - core/src/lib/path_list.cc Diff File
mod - core/src/lib/path_list.h Diff File
mod - core/src/lib/tree.cc Diff File
mod - core/src/lib/tree.h Diff File
mod - core/src/plugins/filed/cephfs/cephfs-fd.cc Diff File
mod - core/src/plugins/filed/gfapi/gfapi-fd.cc Diff File
mod - core/src/tests/htable_test.cc Diff File

master a09ad519

2022-01-28 13:16

Alaa Eddine Elamri

Ported: N/A

Details Diff
systemtest: updated autochanger test to have subtests
mod - systemtests/tests/autochanger/CMakeLists.txt Diff File
add - systemtests/tests/autochanger/test-setup Diff File
add - systemtests/tests/autochanger/testrunner-backup-restore Diff File

master 74b5a677

2022-01-28 12:30

Andreas Rogge

Ported: N/A

Details Diff
lib: wrap htable in a pimpl class
mod - core/src/findlib/hardlink.cc Diff File
mod - core/src/lib/htable.cc Diff File
mod - core/src/lib/htable.h Diff File

master a55e198a

2022-01-28 12:28

Andreas Rogge

Ported: N/A

Details Diff
lib: stop using htable::init()/htable::destroy()

This patch replaces uses if htable::init() with new htable() and uses of
htable::destroy() with either delete or std::destroy_at()
mod - core/src/cats/bvfs.cc Diff File
mod - core/src/dird/ndmp_fhdb_mem.cc Diff File
mod - core/src/filed/accurate_htable.cc Diff File
mod - core/src/findlib/find_one.cc Diff File
mod - core/src/findlib/hardlink.cc Diff File
mod - core/src/lib/path_list.cc Diff File
mod - core/src/lib/tree.cc Diff File
mod - core/src/tests/htable_test.cc Diff File

master a9358e93

2022-01-28 10:57

Andreas Rogge

Ported: N/A

Details Diff
lib: construct MessageItemQueue correctly
mod - core/src/lib/message.cc Diff File

master 17c61058

2022-01-28 10:57

Andreas Rogge

Ported: N/A

Details Diff
console: always use ITEM() in console config
mod - core/src/console/console_conf.cc Diff File

master a098fca6

2022-01-27 21:30

pstorz


Committer: GitHub

Ported: N/A

Details Diff
Merge pull request 0001048

systemtests: wait for mariadb shutdown
mod - CHANGELOG.md Diff File
mod - systemtests/tests/py2plug-fd-mariabackup/testrunner Diff File

master 3cf9cf7a

2022-01-27 18:29

Andreas Rogge

Ported: N/A

Details Diff
lib: make dlist<T> follow rule-of-five

This patch disables copy and move operations on dlist<T> as they won't
produce a meaningful result.
mod - core/src/lib/dlist.h Diff File
 First  Prev  1 2 3 ... 60 ... 120 121 122 123 124 125 126 ... 180 ... 240 ... 300 ... 360 ... 420 ... 480 ... 540 ... 600 ... 610 611 612  Next  Last