View Issue Details

IDProjectCategoryView StatusLast Update
0000591bareos-coredirectorpublic2019-12-18 15:25
Reporterpstorz Assigned Topstorz  
PrioritynormalSeverityminorReproducibilityhave not tried
Status closedResolutionfixed 
PlatformLinuxOSanyOS Version3
Product Version15.2.2 
Summary0000591: config pretty-printer does not print filesets correctly
DescriptionThe following fileset:
============================
FileSet {
  Name = "SKAppServerFileset"

  Include {
    Options {
      Exclude = yes
      Wild = "/var/www/*/public_html/WEB-INF/tmp/*"
      Wild = "/var/lib/postgresql/9.4/main/*"
      Wild = "/tmp/*"
      Wild = "/var/cache/apt/archives/*"
      Wild = "/var/lib/nginx/static-cache/*"
    }

    Options {
      Signature = SHA1
      Compression = LZ4HC
      noatime = yes
      checkfilechanges = yes
    }

    File = /
    File = /dev
  }

  Exclude {
    File = /.journal
    File = /.fsck
    File = /.autofsck
  }
}
============================

is printed in "show filesets" as:


============================
FileSet {
  Name = "SKAppServerFileset"
  Include {
    Options {
      Exclude = yes
      Wild = "/var/www/*/public_html/WEB-INF/tmp/*"
      Wild = "/var/lib/postgresql/9.4/main/*"
      Wild = "/tmp/*"
      Wild = "/var/cache/apt/archives/*"
      Wild = "/var/lib/nginx/static-cache/*"
      Signature = SHA1
      Compression = LZ4HC
      NoAtime = Yes
      CheckFileChanges = yes
    }
    File = "/"
    File = "/dev"
  }
  Exclude {
    File = "/.journal"
    File = "/.fsck"
    File = "/.autofsck"
  }
}
============================

the options blocks get merged which is not correct.

However, the backup operation is done correctly, only the text representation is wrong.

TagsNo tags attached.

Relationships

child of 0000584 closedjoergs Release bareos-14.2.7 

Activities

mvwieringen

mvwieringen

2016-01-07 19:44

developer   ~0002074

Fix committed to bareos master branch with changesetid 6052.
mvwieringen

mvwieringen

2016-07-08 14:34

developer   ~0002309

Fix committed to bareos bareos-14.2 branch with changesetid 6413.

Related Changesets

bareos: master 2975943b

2016-01-06 14:03

mvwieringen

Ported: N/A

Details Diff
dird: Fix pretty printing of Options blocks.

Print Options inside the for loop and also close it there.

Fixes 0000591: config pretty-printer does not print filesets correctly
Affected Issues
0000591
mod - src/dird/dird_conf.c Diff File

bareos: bareos-14.2 41fb810b

2016-01-06 14:03

mvwieringen

Ported: N/A

Details Diff
dird: Fix pretty printing of Options blocks.

Print Options inside the for loop and also close it there.

Fixes 0000591: config pretty-printer does not print filesets correctly
Affected Issues
0000591
mod - src/dird/dird_conf.c Diff File

Issue History

Date Modified Username Field Change
2016-01-06 09:25 pstorz New Issue
2016-01-06 09:25 pstorz Assigned To => pstorz
2016-01-06 09:25 pstorz Status new => acknowledged
2016-01-07 19:44 mvwieringen Changeset attached => bareos master 2975943b
2016-01-07 19:44 mvwieringen Note Added: 0002074
2016-01-07 19:44 mvwieringen Status acknowledged => resolved
2016-01-07 19:44 mvwieringen Resolution open => fixed
2016-07-05 11:49 joergs Relationship added child of 0000584
2016-07-08 14:34 mvwieringen Changeset attached => bareos bareos-14.2 41fb810b
2016-07-08 14:34 mvwieringen Note Added: 0002309
2019-12-18 15:25 arogge Status resolved => closed