 |
As we have added the su option to fix 0000417, the pitfall was that I've checked that it works on SLES11 which has logrotate-3.7.x packages. Now looked at SLES* logrotate source rpms, they backport the su option in their packages. As of https://fedorahosted.org/logrotate/browser/tags/r3-9-1/CHANGES the upstream project added it with the 3.8.0 version. Seeing that, the logrotate version is a useless criterion. Looking at how other projects handle this, found out that the spacewalk project has the su line in git commented out like this: #LOGROTATE-3.8# su root apache (see https://github.com/spacewalkproject/spacewalk/blob/0e5a18207c74cc83b2dd65bd1242a4b082549774/backend/logrotate/spacewalk-backend-app) and in the spec-file they are using this: %if 0%{?fedora} || 0%{?rhel} > 6 sed -i 's/#LOGROTATE-3.8#//' $RPM_BUILD_ROOT%{_sysconfdir}/logrotate.d/spacewalk-backend-* %endif (see https://github.com/spacewalkproject/spacewalk/blob/master/backend/spacewalk-backend.spec) From all the dists that 15.2 packages are built for, only the following do not have the su option in logrotate: - CentOS_5 - CentOS_6 - RHEL_5 - RHEL_6 - xUbuntu_12.04 |
|
|
Commenting it out seems to be an acceptable solution. |
|
|
Yes, although I'd rather consider it a workaround to comment out or remove the su line from the /etc/logrotate.d/bareos-dir file. As it's marked as config file in the RPMs, it won't be overwritten by package updates. However, when the su line is present, but logrotate does not support it, then logrotate outputs an error, but as it's then ignored, the rotations works anyway: # /usr/sbin/logrotate -d /etc/logrotate.conf reading config file /etc/logrotate.conf including /etc/logrotate.d reading config file bareos-dir reading config info for /var/log/bareos/bareos*.log error: bareos-dir:14 unknown option 'su' -- ignoring line error: bareos-dir:14 unexpected text ... rotating pattern: /var/log/bareos/bareos*.log monthly (6 rotations) empty log files are not rotated, old logs are removed considering log /var/log/bareos/bareos.log log needs rotating rotating log /var/log/bareos/bareos.log, log->rotateCount is 6 dateext suffix '-20151016' glob pattern '-[0-9][0-9][0-9][0-9][0-9][0-9][0-9][0-9]' fscreate context set to system_u:object_r:var_log_t:s0 renaming /var/log/bareos/bareos.log to /var/log/bareos/bareos.log-20151016 creating new /var/log/bareos/bareos.log mode = 0640 uid = 497 gid = 498 removing old log /var/log/bareos/bareos.log-20150227 With 0000417 the situaiton was worse, because on logrotate version which have the su option, it did not rotate at all without the proper su line. But as this generates cron error mail every time, the best workaround for the time beeing is commenting out or remove the su. |
|
|
As we also need a fix for deb packaging, may be build time check is the best choice, checking if logrotate support the su option with something like this: touch /tmp/dummy.log echo -e "/tmp/dummy.log {\n su root root\n}" > /tmp/logrotate-check-su if logrotate -d /tmp/logrotate-check-su 2>&1 | grep -q "unknown option 'su'"; then echo "logrotate does not support su option" else echo "logrotate supports su option" fi rm -f /tmp/dummy.log /tmp/logrotate-check-su |
|
|
...other than the fact that the filenames should be generated with mktemp(1) and not predictable, this should work. |
|
|
Fix committed to bareos bareos-15.2 branch with changesetid 5711. |
|
|
Fix committed to bareos bareos-14.2 branch with changesetid 5806. |
- Anonymous
